SilverStripe\ActiveDirectory\Tasks\LDAPGroupSyncTask::run()

Complexity

Conditions	8
Paths	6

Size

Total Lines	76
Code Lines	41

Duplication

Lines	31
Ratio	40.79 %

Importance

Changes

0

<?php
    public function run($request)
    {
        // get all groups from LDAP, but only get the attributes we need.
        // this is useful to avoid holding onto too much data in memory
        // especially in the case where getGroups() would return a lot of groups
        $ldapGroups = $this->ldapService->getGroups(

The property ldapService does not exist. Did you maybe forget to declare it?

            false,
            ['objectguid', 'samaccountname', 'dn', 'name', 'description'],
            // Change the indexing attribute so we can look up by GUID during the deletion process below.
            'objectguid'
        );

        $start = time();

        $count = 0;

        foreach ($ldapGroups as $data) {

This code seems to be duplicated across your project.

            $group = Group::get()->filter('GUID', $data['objectguid'])->limit(1)->first();

            if (!($group && $group->exists())) {
                // create the initial Group with some internal fields
                $group = new Group();
                $group->GUID = $data['objectguid'];

                $this->log(sprintf(
                    'Creating new Group (ID: %s, GUID: %s, sAMAccountName: %s)',
                    $group->ID,
                    $data['objectguid'],
                    $data['samaccountname']
                ));
            } else {
                $this->log(sprintf(
                    'Updating existing Group "%s" (ID: %s, GUID: %s, sAMAccountName: %s)',
                    $group->getTitle(),
                    $group->ID,
                    $data['objectguid'],
                    $data['samaccountname']
                ));
            }

            $this->ldapService->updateGroupFromLDAP($group, $data);

            // cleanup object from memory
            $group->destroy();

            $count++;
        }

        // remove Group records that were previously imported, but no longer exist in the directory
        // NOTE: DB::query() here is used for performance and so we don't run out of memory
        if ($this->config()->destructive) {
            foreach (DB::query('SELECT "ID", "GUID" FROM "Group" WHERE "GUID" IS NOT NULL') as $record) {
                if (!isset($ldapGroups[$record['GUID']])) {
                    $group = Group::get()->byId($record['ID']);
                    // Cascade into mappings, just to clean up behind ourselves.
                    foreach ($group->LDAPGroupMappings() as $mapping) {
                        $mapping->delete();
                    }
                    $group->delete();

                    $this->log(sprintf(
                        'Removing Group "%s" (GUID: %s) that no longer exists in LDAP.',
                        $group->Title,
                        $group->GUID
                    ));

                    // cleanup object from memory
                    $group->destroy();
                }
            }
        }

        $end = time() - $start;

        $this->log(sprintf('Done. Processed %s records. Duration: %s seconds', $count, round($end, 0)));
    }