SilverStripe\ActiveDirectory\Model\LDAPUtil

Complexity

Total Complexity

14

Size/Duplication

Total Lines	109
Duplicated Lines	8.26 %

Coupling/Cohesion

Components	0
Dependencies	0

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	validGuid()	0	7	2
A	bin_to_str_guid()	9	20	4
B	str_to_hex_guid()	0	27	4
A	bin_to_str_sid()	0	16	2
A	little_endian()	0	8	2

<?php

namespace SilverStripe\ActiveDirectory\Model;

/**
 * Class LDAPUtil
 *
 * Provides some commonly used functions for LDAP and SAML.
 *
 * @package activedirectory
 */
class LDAPUtil
{
    /**
     * Checks if the string is a valid guid in the format of A98C5A1E-A742-4808-96FA-6F409E799937
     *
     * @param  string $guid
     * @return bool
     */
    public static function validGuid($guid)
    {
        if (preg_match('/^[A-Z0-9]{8}-[A-Z0-9]{4}-[A-Z0-9]{4}-[A-Z0-9]{4}-[A-Z0-9]{12}?$/', $guid)) {
            return true;
        }
        return false;
    }

    /**
     * @param  string $object_guid
     * @return string
     */
    public static function bin_to_str_guid($object_guid)
    {
        $hex_guid = bin2hex($object_guid);
        $hex_guid_to_guid_str = '';
        for ($k = 1; $k <= 4; ++$k) {

This code seems to be duplicated across your project.

            $hex_guid_to_guid_str .= substr($hex_guid, 8 - 2 * $k, 2);
        }
        $hex_guid_to_guid_str .= '-';
        for ($k = 1; $k <= 2; ++$k) {

This code seems to be duplicated across your project.

            $hex_guid_to_guid_str .= substr($hex_guid, 12 - 2 * $k, 2);
        }
        $hex_guid_to_guid_str .= '-';
        for ($k = 1; $k <= 2; ++$k) {

This code seems to be duplicated across your project.

            $hex_guid_to_guid_str .= substr($hex_guid, 16 - 2 * $k, 2);
        }
        $hex_guid_to_guid_str .= '-' . substr($hex_guid, 16, 4);
        $hex_guid_to_guid_str .= '-' . substr($hex_guid, 20);

        return strtoupper($hex_guid_to_guid_str);
    }

    /**
     * @param  string $str_guid
     * @param  bool   $escape
     * @return string
     */
    public static function str_to_hex_guid($str_guid, $escape = false)
    {
        $str_guid = str_replace('-', '', $str_guid);

        $octet_str = substr($str_guid, 6, 2);
        $octet_str .= substr($str_guid, 4, 2);
        $octet_str .= substr($str_guid, 2, 2);
        $octet_str .= substr($str_guid, 0, 2);
        $octet_str .= substr($str_guid, 10, 2);
        $octet_str .= substr($str_guid, 8, 2);
        $octet_str .= substr($str_guid, 14, 2);
        $octet_str .= substr($str_guid, 12, 2);
        $octet_str .= substr($str_guid, 16, strlen($str_guid));

        if ($escape) {
            $escaped = '\\';
            for ($i = 0; $i < strlen($octet_str); $i+=2) {
                $escaped .= substr($octet_str, $i, 2);
                if ($i != strlen($octet_str) - 2) {
                    $escaped .= '\\';
                }
            }
            return $escaped;
        }

        return $octet_str;
    }

    /**
     * @param  string $binsid
     * @return string
     */
    public static function bin_to_str_sid($binsid)
    {
        $hex_sid = bin2hex($binsid);
        $rev = hexdec(substr($hex_sid, 0, 2));
        $subcount = hexdec(substr($hex_sid, 2, 2));
        $auth = hexdec(substr($hex_sid, 4, 12));
        $result = "$rev-$auth";

        for ($x = 0; $x < $subcount; $x++) {
            $subauth[$x] = hexdec(self::little_endian(substr($hex_sid, 16 + ($x * 8), 8)));

$subauth was never initialized. Although not strictly required by PHP, it is generally a good practice to add $subauth = array(); before regardless.

            $result .= '-' . $subauth[$x];

The variable $subauth does not seem to be defined for all execution paths leading up to this point.

        }

        // Cheat by tacking on the S-
        return 'S-' . $result;
    }

    /**
     * Converts a little-endian hex-number to one, that 'hexdec' can convert
     * @param  string $hex
     * @return string
     */
    public static function little_endian($hex)
    {
        $result = '';
        for ($x = strlen($hex) - 2; $x >= 0; $x = $x - 2) {
            $result .= substr($hex, $x, 2);
        }
        return $result;
    }
}