SilverStripe\ActiveDirectory\Model\LDAPGroupMapping

Complexity

Total Complexity

3

Size/Duplication

Total Lines	73
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	3

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
B	getCMSFields()	0	31	3

<?php

namespace SilverStripe\ActiveDirectory\Model;

use SilverStripe\Forms\DropdownField;
use SilverStripe\ORM\DataObject;

/**
 * Class LDAPGroupMapping
 *
 * An individual mapping of an LDAP group to a SilverStripe {@link Group}
 */
class LDAPGroupMapping extends DataObject
{
    /**
     * {@inheritDoc}
     * @var string
     */
    private static $table_name = 'LDAPGroupMapping';

Consider using a different property name as you override a private property of the parent class.

The property $table_name is not used and could be removed.

    /**
     * @var array
     */
    private static $db = [

Consider using a different property name as you override a private property of the parent class.

The property $db is not used and could be removed.

        'DN' => 'Text', // the DN value of the LDAP object in AD, e.g. CN=Users,DN=playpen,DN=local
        'Scope' => 'Enum("Subtree,OneLevel","Subtree")' // the scope of the mapping
    ];

    /**
     * @var array
     */
    private static $has_one = [

Consider using a different property name as you override a private property of the parent class.

The property $has_one is not used and could be removed.

        'Group' => 'SilverStripe\\Security\\Group'
    ];

    /**
     * @var array
     */
    private static $summary_fields = [

Consider using a different property name as you override a private property of the parent class.

The property $summary_fields is not used and could be removed.

        'DN'
    ];

    /**
     * @var array
     */
    private static $dependencies = [

The property $dependencies is not used and could be removed.

        'ldapService' => '%$SilverStripe\\ActiveDirectory\\Services\\LDAPService'
    ];

    /**
     * {@inheritDoc}
     * @return FieldList
     */
    public function getCMSFields()
    {
        $fields = parent::getCMSFields();
        $fields->removeByName('DN');

        $field = DropdownField::create('DN', _t('LDAPGroupMapping.LDAPGROUP', 'LDAP Group'));
        $field->setEmptyString(_t('LDAPGroupMapping.SELECTONE', 'Select one'));
        $groups = $this->ldapService->getGroups(true, ['dn', 'name']);

The property ldapService does not exist on object<SilverStripe\ActiveDirectory\Model\LDAPGroupMapping>. Since you implemented __get, maybe consider adding a @property annotation.

        if ($groups) {
            foreach ($groups as $dn => $record) {
                $source[$dn] = sprintf('%s (%s)', $record['name'], $dn);

$source was never initialized. Although not strictly required by PHP, it is generally a good practice to add $source = array(); before regardless.

            }
        }
        asort($source);
        $field->setSource($source);
        $fields->addFieldToTab('Root.Main', $field);

        $fields->removeByName('Scope');
        $fields->addFieldToTab(
            'Root.Main',
            DropdownField::create('Scope', _t('LDAPGroupMapping.SCOPE', 'Scope'), [
                'Subtree' => _t(
                    'LDAPGroupMapping.SUBTREE_DESCRIPTION',
                    'Users within this group and all nested groups within'
                ),
                'OneLevel' => _t('LDAPGroupMapping.ONELEVEL_DESCRIPTION', 'Only users within this group'),
            ])
        );

        return $fields;
    }
}