Completed
Pull Request — master (#116)
by Franco
01:50
created
src/Forms/LDAPChangePasswordForm.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -79,7 +79,7 @@
 block discarded – undo
79 79
      * Change the password
80 80
      *
81 81
      * @param array $data The user submitted data
82
-     * @return HTTPResponse
82
+     * @return \SilverStripe\Control\HTTPResponse
83 83
      */
84 84
     public function doChangePassword(array $data)
85 85
     {
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -5,7 +5,6 @@
 block discarded – undo
5 5
 use Exception;
6 6
 use SilverStripe\Control\Director;
7 7
 use SilverStripe\Control\HTTP;
8
-use SilverStripe\Control\Session;
9 8
 use SilverStripe\Core\Config\Config;
10 9
 use SilverStripe\Core\Injector\Injector;
11 10
 use SilverStripe\Forms\TextField;
Please login to merge, or discard this patch.
src/Authenticators/LDAPAuthenticator.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -82,7 +82,7 @@
 block discarded – undo
82 82
      * @param array $data
83 83
      * @param HTTPRequest $request
84 84
      * @param ValidationResult|null $result
85
-     * @return bool|Member
85
+     * @return null|\SilverStripe\ORM\DataObject
86 86
      * @internal param Form $form
87 87
      */
88 88
     public function authenticate(array $data, HTTPRequest $request, ValidationResult &$result = null)
Please login to merge, or discard this patch.
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -6,13 +6,11 @@
 block discarded – undo
6 6
 use SilverStripe\Control\Controller;
7 7
 use SilverStripe\Control\Email\Email;
8 8
 use SilverStripe\Control\HTTPRequest;
9
-use SilverStripe\Control\Session;
10 9
 use SilverStripe\Core\Config\Config;
11 10
 use SilverStripe\Core\Injector\Injector;
12 11
 use SilverStripe\ORM\ValidationResult;
13 12
 use SilverStripe\Security\Authenticator;
14 13
 use SilverStripe\Security\Member;
15
-use SilverStripe\Security\MemberAuthenticator\LogoutHandler;
16 14
 use SilverStripe\Security\MemberAuthenticator\MemberAuthenticator;
17 15
 
18 16
 /**
Please login to merge, or discard this patch.
src/Authenticators/LDAPLoginForm.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -5,7 +5,6 @@
 block discarded – undo
5 5
 use SilverStripe\ActiveDirectory\Control\LDAPSecurityController;
6 6
 use SilverStripe\ActiveDirectory\Services\LDAPService;
7 7
 use SilverStripe\Control\Email\Email;
8
-use SilverStripe\Control\Session;
9 8
 use SilverStripe\Core\Config\Config;
10 9
 use SilverStripe\Core\Injector\Injector;
11 10
 use SilverStripe\Forms\LiteralField;
Please login to merge, or discard this patch.
src/Authenticators/SAMLLoginForm.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -2,7 +2,6 @@
 block discarded – undo
2 2
 
3 3
 namespace SilverStripe\ActiveDirectory\Authenticators;
4 4
 
5
-use SilverStripe\Control\Session;
6 5
 use SilverStripe\Forms\FieldList;
7 6
 use SilverStripe\Forms\HiddenField;
8 7
 use SilverStripe\Forms\FormAction;
Please login to merge, or discard this patch.
src/Control/SAMLController.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -7,7 +7,6 @@
 block discarded – undo
7 7
 use SilverStripe\ActiveDirectory\Model\LDAPUtil;
8 8
 use SilverStripe\Control\Controller;
9 9
 use SilverStripe\Control\Director;
10
-use SilverStripe\Control\Session;
11 10
 use SilverStripe\Core\Injector\Injector;
12 11
 use SilverStripe\Forms\Form;
13 12
 use SilverStirpe\Security\Member;
Please login to merge, or discard this patch.
src/Authenticators/SAMLAuthenticator.php 1 patch
Unused Use Statements   -4 removed lines patch added patch discarded remove patch
@@ -6,15 +6,11 @@
 block discarded – undo
6 6
 use SilverStripe\Control\Controller;
7 7
 use Silverstripe\Control\Director;
8 8
 use SilverStripe\Control\HTTPRequest;
9
-use SilverStripe\Control\Session;
10 9
 use SilverStripe\Core\Config\Config;
11 10
 use SilverStripe\Core\Injector\Injector;
12 11
 use SilverStripe\Forms\Form;
13 12
 use SilverStripe\ORM\ValidationResult;
14
-use SilverStripe\Security\Authenticator;
15 13
 use SilverStripe\Security\Member;
16
-use SilverStripe\Security\MemberAuthenticator\LoginHandler;
17
-use SilverStripe\Security\MemberAuthenticator\LDAPLogoutHandler;
18 14
 use SilverStripe\Security\MemberAuthenticator\MemberAuthenticator;
19 15
 
20 16
 /**
Please login to merge, or discard this patch.
src/Control/LDAPSecurityController.php 2 patches
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -55,7 +55,7 @@  discard block
 block discarded – undo
55 55
     /**
56 56
      * Factory method for the lost password form
57 57
      *
58
-     * @return Form Returns the lost password form
58
+     * @return LDAPChangePasswordForm Returns the lost password form
59 59
      */
60 60
     public function ChangePasswordForm()
61 61
     {
@@ -103,7 +103,7 @@  discard block
 block discarded – undo
103 103
     /**
104 104
      * Factory method for the lost password form
105 105
      *
106
-     * @return Form Returns the lost password form
106
+     * @return LDAPLoginForm Returns the lost password form
107 107
      */
108 108
     public function LostPasswordForm()
109 109
     {
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -7,7 +7,6 @@
 block discarded – undo
7 7
 use SilverStripe\Control\Controller;
8 8
 use SilverStripe\Control\Director;
9 9
 use SilverStripe\Core\Convert;
10
-use SilverStripe\Core\Object;
11 10
 use SilverStripe\Core\Config\Config;
12 11
 use SilverStripe\Forms\EmailField;
13 12
 use SilverStripe\Forms\FormAction;
Please login to merge, or discard this patch.