silverstripe / silverstripe-activedirectory

src/Services/LDAPService.php

Doc Comments +3 added lines, -3 removed lines

@@ -273,7 +273,7 @@ 
      * Note that these get cached in-memory per-request for performance to avoid re-querying for the same results.
      *
      * @param string $dn
-     * @param array $attributes List of specific AD attributes to return. Empty array means return everything.
+     * @param string[] $attributes List of specific AD attributes to return. Empty array means return everything.
      * @return array
      */
     public function getNestedGroups($dn, $attributes = [])
@@ -477,7 +477,7 @@ 
      * @param Member
      * @param array|null $data If passed, this is pre-existing AD attribute data to update the Member with.
      *            If not given, the data will be looked up by the user's GUID.
-     * @return bool
+     * @return false|null
      */
     public function updateMemberFromLDAP(Member $member, $data = null)
     {
@@ -657,7 +657,7 @@ 
      * @param Group $group An existing Group or a new Group object
      * @param array $data LDAP group object data
      *
-     * @return bool
+     * @return false|null
      */
     public function updateGroupFromLDAP(Group $group, $data)
     {

src/Control/LDAPDebugController.php

Doc Comments +1 added lines, -1 removed lines

@@ -54,7 +54,7 @@
     /**
      * @param HTTPRequest $request
      *
-     * @return string
+     * @return \SilverStripe\ORM\FieldType\DBHTMLText
      */
     public function index(HTTPRequest $request)
     {

src/Authenticators/LDAPAuthenticator.php

Doc Comments +1 added lines, -1 removed lines

@@ -82,7 +82,7 @@
      * @param array $data
      * @param HTTPRequest $request
      * @param ValidationResult|null $result
-     * @return null|Member
+     * @return null|\SilverStripe\ORM\DataObject
      */
     public function authenticate(array $data, HTTPRequest $request, ValidationResult &$result = null)
     {

Unused Use Statements -2 removed lines

@@ -6,13 +6,11 @@
 use SilverStripe\Control\Controller;
 use SilverStripe\Control\Email\Email;
 use SilverStripe\Control\HTTPRequest;
-use SilverStripe\Control\Session;
 use SilverStripe\Core\Config\Config;
 use SilverStripe\Core\Injector\Injector;
 use SilverStripe\ORM\ValidationResult;
 use SilverStripe\Security\Authenticator;
 use SilverStripe\Security\Member;
-use SilverStripe\Security\MemberAuthenticator\LogoutHandler;
 use SilverStripe\Security\MemberAuthenticator\MemberAuthenticator;
 use Zend\Authentication\Result;
 

src/Authenticators/SAMLAuthenticator.php

Unused Use Statements -2 removed lines

@@ -6,10 +6,8 @@
 use SilverStripe\Control\Controller;
 use Silverstripe\Control\Director;
 use SilverStripe\Control\HTTPRequest;
-use SilverStripe\Control\Session;
 use SilverStripe\Core\Config\Config;
 use SilverStripe\Core\Injector\Injector;
-use SilverStripe\Forms\Form;
 use SilverStripe\ORM\ValidationResult;
 use SilverStripe\Security\Authenticator;
 use SilverStripe\Security\Member;