silverstripe / deploynaut

code/backends/DeploymentStrategy.php

Braces +6 added lines, -2 removed lines

@@ -110,8 +110,12 @@
 		// Normalise "empty" values into dashes so comparisons are done properly.
 		// This means there is no diference between an empty string and a null
 		// but "0" is considered to be non-empty.
-		if(empty($from) && !strlen($from)) $from = '-';
-		if(empty($to) && !strlen($from)) $to = '-';
+		if(empty($from) && !strlen($from)) {
+			$from = '-';
+		}
+		if(empty($to) && !strlen($from)) {
+			$to = '-';
+		}
 
 		return $this->changes[$title] = array(
 			'from' => $from,

Spacing +3 added lines, -3 removed lines

@@ -136,10 +136,10 @@
 	 */
 	public function getChangesModificationNeeded() {
 		$filtered = [];
-		foreach ($this->getChanges() as $change => $details) {
-			if (array_key_exists('description', $details)) {
+		foreach($this->getChanges() as $change => $details) {
+			if(array_key_exists('description', $details)) {
 				$filtered[$change] = $details;
-			} else if (
+			} else if(
 				(array_key_exists('from', $details) || array_key_exists('to', $details))
 				&& $details['from'] !== $details['to']
 			) {

code/model/jobs/DNDeployment.php

Braces +9 added lines, -3 removed lines

@@ -201,12 +201,16 @@ 
 	 */
 	public function getFullDeployMessages() {
 		$strategy = $this->getDeploymentStrategy();
-		if ($strategy->getActionCode()!=='full') return null;
+		if ($strategy->getActionCode()!=='full') {
+			return null;
+		}
 
 		$changes = $strategy->getChangesModificationNeeded();
 		$messages = [];
 		foreach ($changes as $change => $details) {
-			if ($change==='Code version') continue;
+			if ($change==='Code version') {
+				continue;
+			}
 
 			$messages[] = [
 				'Flag' => sprintf(
@@ -260,7 +264,9 @@ 
 		$list = new ArrayList();
 		$strategy = $this->getDeploymentStrategy();
 		foreach($strategy->getChanges() as $name => $change) {
-			if(empty($change['to']) || $change['to'] == '-') continue;
+			if(empty($change['to']) || $change['to'] == '-') {
+				continue;
+			}
 
 			$list->push(new ArrayData([
 				'Name' => $name,