silverstripe / deploynaut

code/control/DeployDispatcher.php

Doc Comments +2 added lines, -2 removed lines

@@ -55,7 +55,7 @@ 
 	 *
 	 * @param \SS_HTTPRequest $request
 	 *
-	 * @return \HTMLText|\SS_HTTPResponse
+	 * @return SS_HTTPResponse|null
 	 */
 	public function index(\SS_HTTPRequest $request) {
 		return $this->redirect(\Controller::join_links($this->Link(), 'history'), 302);
@@ -174,7 +174,7 @@ 
 	 *
 	 * @param SS_HTTPRequest $request
 	 *
-	 * @return string
+	 * @return SS_HTTPResponse|null
 	 * @throws SS_HTTPResponse_Exception
 	 */
 	public function log(SS_HTTPRequest $request) {

Spacing +6 added lines, -6 removed lines

@@ -68,21 +68,21 @@ 
 		$data = [];
 		$list = $this->DeployHistory();
 		$page = $request->getVar('page') ?: 1;
-		if ($page > $list->TotalPages()) {
+		if($page > $list->TotalPages()) {
 			$page = 1;
 		}
-		if ($page < 1) {
+		if($page < 1) {
 			$page = 1;
 		}
 		$start = ($page - 1) * $list->getPageLength();
-		$list->setPageStart((int) $start);
-		if (empty($list)) {
+		$list->setPageStart((int)$start);
+		if(empty($list)) {
 			return $this->getAPIResponse(['list' => []], 200);
 		}
 
 		$currentBuild = $this->environment->CurrentBuild();
 
-		foreach ($list as $deployment) {
+		foreach($list as $deployment) {
 			$data[] = [
 				'DeploymentID' => $deployment->ID,
 				'CreatedDate' => $deployment->Created,
@@ -112,7 +112,7 @@ 
 	 */
 	public function currentbuild(SS_HTTPRequest $request) {
 		$currentBuild = $this->environment->CurrentBuild();
-		if (!$currentBuild) {
+		if(!$currentBuild) {
 			return $this->getAPIResponse(['build' => []], 200);
 		}
 

code/model/jobs/DNDeployment.php

Spacing +11 added lines, -11 removed lines

@@ -101,7 +101,7 @@ 
 	}
 
 	public function LogLink() {
-		return $this->Link() . '/log';
+		return $this->Link().'/log';
 	}
 
 	public function canView($member = null) {
@@ -177,18 +177,18 @@ 
 	 */
 	public function getCommitURL() {
 		$environment = $this->Environment();
-		if (!$environment) {
+		if(!$environment) {
 			return null;
 		}
 		$project = $environment->Project();
-		if (!$project) {
+		if(!$project) {
 			return null;
 		}
 		$interface = $project->getRepositoryInterface();
-		if (!$interface) {
+		if(!$interface) {
 			return null;
 		}
-		return $interface->CommitURL . '/' . $this->SHA;
+		return $interface->CommitURL.'/'.$this->SHA;
 	}
 
 	/**
@@ -237,12 +237,12 @@ 
 	 */
 	public function getFullDeployMessages() {
 		$strategy = $this->getDeploymentStrategy();
-		if ($strategy->getActionCode()!=='full') return null;
+		if($strategy->getActionCode() !== 'full') return null;
 
 		$changes = $strategy->getChangesModificationNeeded();
 		$messages = [];
-		foreach ($changes as $change => $details) {
-			if ($change==='Code version') continue;
+		foreach($changes as $change => $details) {
+			if($change === 'Code version') continue;
 
 			$messages[] = [
 				'Flag' => sprintf(
@@ -253,7 +253,7 @@ 
 			];
 		}
 
-		if (empty($messages)) {
+		if(empty($messages)) {
 			$messages[] = [
 				'Flag' => '',
 				'Text' => '<i>Environment changes have been made.</i>'
@@ -302,7 +302,7 @@ 
 
 			// if there is a compare URL, and a description or a change (something actually changed)
 			// then show the URL. Otherwise don't show anything, as there is no comparison to be made.
-			if ($changed || $description) {
+			if($changed || $description) {
 				$compareUrl = isset($change['compareUrl']) ? $change['compareUrl'] : '';
 			}
 
@@ -366,7 +366,7 @@ 
 
 	public function getSigFile() {
 		$dir = DNData::inst()->getSignalDir();
-		if (!is_dir($dir)) {
+		if(!is_dir($dir)) {
 			`mkdir $dir`;
 		}
 		return sprintf(