Inspection of "fetch the deploy strategy from the environment ins..." - silverstripe/deploynaut - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#527)

by Stig

created 2016-03-04 01:26 UTC

Status

Spacing +19 added lines, -19 removed lines patch added patch discarded remove patch

@@ -216,7 +216,7 @@  discard block
 block discarded – undo
 	 * @return DeploymentStrategy
 	 */
 	public function getDeployStrategy(\SS_HTTPRequest $request) {
-		return $this->Backend()->planDeploy($this, $request);;
+		return $this->Backend()->planDeploy($this, $request); ;
 	}
 
 	public function Menu() {
@@ -408,10 +408,10 @@  discard block
 block discarded – undo
 		}
 		// Must be logged in to check permissions
 
-		if ($this->Usage==='Production' || $this->Usage==='Unspecified') {
-			if ($this->Project()->allowed(DNRoot::ALLOW_PROD_DEPLOYMENT, $member)) return true;
+		if($this->Usage === 'Production' || $this->Usage === 'Unspecified') {
+			if($this->Project()->allowed(DNRoot::ALLOW_PROD_DEPLOYMENT, $member)) return true;
 		} else {
-			if ($this->Project()->allowed(DNRoot::ALLOW_NON_PROD_DEPLOYMENT, $member)) return true;
+			if($this->Project()->allowed(DNRoot::ALLOW_NON_PROD_DEPLOYMENT, $member)) return true;
 		}
 
 		return $this->Deployers()->byID($member->ID)
@@ -443,10 +443,10 @@  discard block
 block discarded – undo
 		}
 		// Must be logged in to check permissions
 
-		if ($this->Usage==='Production' || $this->Usage==='Unspecified') {
-			if ($this->Project()->allowed(DNRoot::ALLOW_PROD_SNAPSHOT, $member)) return true;
+		if($this->Usage === 'Production' || $this->Usage === 'Unspecified') {
+			if($this->Project()->allowed(DNRoot::ALLOW_PROD_SNAPSHOT, $member)) return true;
 		} else {
-			if ($this->Project()->allowed(DNRoot::ALLOW_NON_PROD_SNAPSHOT, $member)) return true;
+			if($this->Project()->allowed(DNRoot::ALLOW_NON_PROD_SNAPSHOT, $member)) return true;
 		}
 
 		return $this->CanRestoreMembers()->byID($member->ID)
@@ -474,10 +474,10 @@  discard block
 block discarded – undo
 			return false;
 		}
 
-		if ($this->Usage==='Production' || $this->Usage==='Unspecified') {
-			if ($this->Project()->allowed(DNRoot::ALLOW_PROD_SNAPSHOT, $member)) return true;
+		if($this->Usage === 'Production' || $this->Usage === 'Unspecified') {
+			if($this->Project()->allowed(DNRoot::ALLOW_PROD_SNAPSHOT, $member)) return true;
 		} else {
-			if ($this->Project()->allowed(DNRoot::ALLOW_NON_PROD_SNAPSHOT, $member)) return true;
+			if($this->Project()->allowed(DNRoot::ALLOW_NON_PROD_SNAPSHOT, $member)) return true;
 		}
 
 		return $this->CanBackupMembers()->byID($member->ID)
@@ -509,10 +509,10 @@  discard block
 block discarded – undo
 		}
 		// Must be logged in to check permissions
 
-		if ($this->Usage==='Production' || $this->Usage==='Unspecified') {
-			if ($this->Project()->allowed(DNRoot::ALLOW_PROD_SNAPSHOT, $member)) return true;
+		if($this->Usage === 'Production' || $this->Usage === 'Unspecified') {
+			if($this->Project()->allowed(DNRoot::ALLOW_PROD_SNAPSHOT, $member)) return true;
 		} else {
-			if ($this->Project()->allowed(DNRoot::ALLOW_NON_PROD_SNAPSHOT, $member)) return true;
+			if($this->Project()->allowed(DNRoot::ALLOW_NON_PROD_SNAPSHOT, $member)) return true;
 		}
 
 		return $this->ArchiveUploaders()->byID($member->ID)
@@ -535,10 +535,10 @@  discard block
 block discarded – undo
 		}
 		// Must be logged in to check permissions
 
-		if ($this->Usage==='Production' || $this->Usage==='Unspecified') {
-			if ($this->Project()->allowed(DNRoot::ALLOW_PROD_SNAPSHOT, $member)) return true;
+		if($this->Usage === 'Production' || $this->Usage === 'Unspecified') {
+			if($this->Project()->allowed(DNRoot::ALLOW_PROD_SNAPSHOT, $member)) return true;
 		} else {
-			if ($this->Project()->allowed(DNRoot::ALLOW_NON_PROD_SNAPSHOT, $member)) return true;
+			if($this->Project()->allowed(DNRoot::ALLOW_NON_PROD_SNAPSHOT, $member)) return true;
 		}
 
 		return $this->ArchiveDownloaders()->byID($member->ID)
@@ -604,10 +604,10 @@  discard block
 block discarded – undo
 		}
 		// Must be logged in to check permissions
 
-		if ($this->Usage==='Production' || $this->Usage==='Unspecified') {
-			if ($this->Project()->allowed(DNRoot::ALLOW_PROD_SNAPSHOT, $member)) return true;
+		if($this->Usage === 'Production' || $this->Usage === 'Unspecified') {
+			if($this->Project()->allowed(DNRoot::ALLOW_PROD_SNAPSHOT, $member)) return true;
 		} else {
-			if ($this->Project()->allowed(DNRoot::ALLOW_NON_PROD_SNAPSHOT, $member)) return true;
+			if($this->Project()->allowed(DNRoot::ALLOW_NON_PROD_SNAPSHOT, $member)) return true;
 		}
 
 		return $this->ArchiveDeleters()->byID($member->ID)

Please login to merge, or discard this patch.

		@@ -216,7 +216,7 @@ discard block
		block discarded – undo
216	216	* @return DeploymentStrategy
217	217	*/
218	218	public function getDeployStrategy(\SS_HTTPRequest $request) {
219		- return $this->Backend()->planDeploy($this, $request);;
	219	+ return $this->Backend()->planDeploy($this, $request); ;
220	220	}
221	221
222	222	public function Menu() {
		@@ -408,10 +408,10 @@ discard block
		block discarded – undo
408	408	}
409	409	// Must be logged in to check permissions
410	410
411		- if ($this->Usage==='Production' \|\| $this->Usage==='Unspecified') {
412		- if ($this->Project()->allowed(DNRoot::ALLOW_PROD_DEPLOYMENT, $member)) return true;
	411	+ if($this->Usage === 'Production' \|\| $this->Usage === 'Unspecified') {
	412	+ if($this->Project()->allowed(DNRoot::ALLOW_PROD_DEPLOYMENT, $member)) return true;
413	413	} else {
414		- if ($this->Project()->allowed(DNRoot::ALLOW_NON_PROD_DEPLOYMENT, $member)) return true;
	414	+ if($this->Project()->allowed(DNRoot::ALLOW_NON_PROD_DEPLOYMENT, $member)) return true;
415	415	}
416	416
417	417	return $this->Deployers()->byID($member->ID)
		@@ -443,10 +443,10 @@ discard block
		block discarded – undo
443	443	}
444	444	// Must be logged in to check permissions
445	445
446		- if ($this->Usage==='Production' \|\| $this->Usage==='Unspecified') {
447		- if ($this->Project()->allowed(DNRoot::ALLOW_PROD_SNAPSHOT, $member)) return true;
	446	+ if($this->Usage === 'Production' \|\| $this->Usage === 'Unspecified') {
	447	+ if($this->Project()->allowed(DNRoot::ALLOW_PROD_SNAPSHOT, $member)) return true;
448	448	} else {
449		- if ($this->Project()->allowed(DNRoot::ALLOW_NON_PROD_SNAPSHOT, $member)) return true;
	449	+ if($this->Project()->allowed(DNRoot::ALLOW_NON_PROD_SNAPSHOT, $member)) return true;
450	450	}
451	451
452	452	return $this->CanRestoreMembers()->byID($member->ID)
		@@ -474,10 +474,10 @@ discard block
		block discarded – undo
474	474	return false;
475	475	}
476	476
477		- if ($this->Usage==='Production' \|\| $this->Usage==='Unspecified') {
478		- if ($this->Project()->allowed(DNRoot::ALLOW_PROD_SNAPSHOT, $member)) return true;
	477	+ if($this->Usage === 'Production' \|\| $this->Usage === 'Unspecified') {
	478	+ if($this->Project()->allowed(DNRoot::ALLOW_PROD_SNAPSHOT, $member)) return true;
479	479	} else {
480		- if ($this->Project()->allowed(DNRoot::ALLOW_NON_PROD_SNAPSHOT, $member)) return true;
	480	+ if($this->Project()->allowed(DNRoot::ALLOW_NON_PROD_SNAPSHOT, $member)) return true;
481	481	}
482	482
483	483	return $this->CanBackupMembers()->byID($member->ID)
		@@ -509,10 +509,10 @@ discard block
		block discarded – undo
509	509	}
510	510	// Must be logged in to check permissions
511	511
512		- if ($this->Usage==='Production' \|\| $this->Usage==='Unspecified') {
513		- if ($this->Project()->allowed(DNRoot::ALLOW_PROD_SNAPSHOT, $member)) return true;
	512	+ if($this->Usage === 'Production' \|\| $this->Usage === 'Unspecified') {
	513	+ if($this->Project()->allowed(DNRoot::ALLOW_PROD_SNAPSHOT, $member)) return true;
514	514	} else {
515		- if ($this->Project()->allowed(DNRoot::ALLOW_NON_PROD_SNAPSHOT, $member)) return true;
	515	+ if($this->Project()->allowed(DNRoot::ALLOW_NON_PROD_SNAPSHOT, $member)) return true;
516	516	}
517	517
518	518	return $this->ArchiveUploaders()->byID($member->ID)
		@@ -535,10 +535,10 @@ discard block
		block discarded – undo
535	535	}
536	536	// Must be logged in to check permissions
537	537
538		- if ($this->Usage==='Production' \|\| $this->Usage==='Unspecified') {
539		- if ($this->Project()->allowed(DNRoot::ALLOW_PROD_SNAPSHOT, $member)) return true;
	538	+ if($this->Usage === 'Production' \|\| $this->Usage === 'Unspecified') {
	539	+ if($this->Project()->allowed(DNRoot::ALLOW_PROD_SNAPSHOT, $member)) return true;
540	540	} else {
541		- if ($this->Project()->allowed(DNRoot::ALLOW_NON_PROD_SNAPSHOT, $member)) return true;
	541	+ if($this->Project()->allowed(DNRoot::ALLOW_NON_PROD_SNAPSHOT, $member)) return true;
542	542	}
543	543
544	544	return $this->ArchiveDownloaders()->byID($member->ID)
		@@ -604,10 +604,10 @@ discard block
		block discarded – undo
604	604	}
605	605	// Must be logged in to check permissions
606	606
607		- if ($this->Usage==='Production' \|\| $this->Usage==='Unspecified') {
608		- if ($this->Project()->allowed(DNRoot::ALLOW_PROD_SNAPSHOT, $member)) return true;
	607	+ if($this->Usage === 'Production' \|\| $this->Usage === 'Unspecified') {
	608	+ if($this->Project()->allowed(DNRoot::ALLOW_PROD_SNAPSHOT, $member)) return true;
609	609	} else {
610		- if ($this->Project()->allowed(DNRoot::ALLOW_NON_PROD_SNAPSHOT, $member)) return true;
	610	+ if($this->Project()->allowed(DNRoot::ALLOW_NON_PROD_SNAPSHOT, $member)) return true;
611	611	}
612	612
613	613	return $this->ArchiveDeleters()->byID($member->ID)

silverstripe / deploynaut

Pull Request — master (#527)

Status

Category

Spacing +19 added lines, -19 removed lines patch added patch discarded remove patch