silverstripe / deploynaut

code/control/DeployDispatcher.php

Doc Comments +1 added lines, -1 removed lines

@@ -46,7 +46,7 @@
 	 *
 	 * @param \SS_HTTPRequest $request
 	 *
-	 * @return \HTMLText|\SS_HTTPResponse
+	 * @return SS_HTTPResponse|null
 	 */
 	public function index(\SS_HTTPRequest $request) {
 		return $this->redirect(\Controller::join_links($this->Link(), 'history'), 302);

Spacing +17 added lines, -17 removed lines

@@ -41,13 +41,13 @@ 
 
 		$this->project = $this->getCurrentProject();
 
-		if (!$this->project) {
+		if(!$this->project) {
 			return $this->project404Response();
 		}
 
 		// Performs canView permission check by limiting visible projects
 		$this->environment = $this->getCurrentEnvironment($this->project);
-		if (!$this->environment) {
+		if(!$this->environment) {
 			return $this->environment404Response();
 		}
 	}
@@ -68,19 +68,19 @@ 
 		$data = [];
 		$list = $this->DeployHistory();
 		$page = $request->getVar('page') ?: 1;
-		if ($page > $list->TotalPages()) {
+		if($page > $list->TotalPages()) {
 			$page = 1;
 		}
-		if ($page < 1) {
+		if($page < 1) {
 			$page = 1;
 		}
 		$start = ($page - 1) * $list->getPageLength();
-		$list->setPageStart((int) $start);
-		if (empty($list)) {
+		$list->setPageStart((int)$start);
+		if(empty($list)) {
 			return $this->getAPIResponse(['list' => []], 200);
 		}
 
-		foreach ($list as $deployment) {
+		foreach($list as $deployment) {
 			$data[] = $this->getDeploymentData($deployment);
 		}
 
@@ -98,7 +98,7 @@ 
 	 */
 	public function currentbuild(SS_HTTPRequest $request) {
 		$currentBuild = $this->environment->CurrentBuild();
-		if (!$currentBuild) {
+		if(!$currentBuild) {
 			return $this->getAPIResponse(['deployment' => []], 200);
 		}
 		return $this->getAPIResponse(['deployment' => $this->getDeploymentData($currentBuild)], 200);
@@ -110,10 +110,10 @@ 
 	 */
 	public function show(SS_HTTPRequest $request) {
 		$deployment = DNDeployment::get()->byId($request->param('ID'));
-		if (!$deployment || !$deployment->exists()) {
+		if(!$deployment || !$deployment->exists()) {
 			return $this->getAPIResponse(['message' => 'This deployment does not exist'], 404);
 		}
-		if (!$deployment->canView()) {
+		if(!$deployment->canView()) {
 			return $this->getAPIResponse(['message' => 'You are not authorised to deploy this environment'], 403);
 		}
 		return $this->getAPIResponse(['deployment' => $this->getDeploymentData($deployment)], 200);
@@ -125,10 +125,10 @@ 
 	 */
 	public function log(SS_HTTPRequest $request) {
 		$deployment = DNDeployment::get()->byId($request->params('ID'));
-		if (!$deployment || !$deployment->exists) {
+		if(!$deployment || !$deployment->exists) {
 			return $this->getAPIResponse(['message' => 'This deployment does not exist'], 404);
 		}
-		if (!$deployment->canView()) {
+		if(!$deployment->canView()) {
 			return $this->getAPIResponse(['message' => 'You are not authorised to view this environment'], 403);
 		}
 
@@ -146,7 +146,7 @@ 
 	public function start(SS_HTTPRequest $request) {
 		$this->checkSecurityToken();
 
-		if (!$this->environment->canDeploy(Member::currentUser())) {
+		if(!$this->environment->canDeploy(Member::currentUser())) {
 			return $this->getAPIResponse(['message' => 'You are not authorised to deploy this environment'], 403);
 		}
 
@@ -202,12 +202,12 @@ 
 
 		$deployer = $deployment->Deployer();
 		$deployerData = null;
-		if ($deployer && $deployer->exists()) {
+		if($deployer && $deployer->exists()) {
 			$deployerData = $this->getStackMemberData($deployer);
 		}
 		$approver = $deployment->Approver();
 		$approverData = null;
-		if ($approver && $approver->exists()) {
+		if($approver && $approver->exists()) {
 			$approverData = $this->getStackMemberData($approver);
 		}
 
@@ -241,8 +241,8 @@ 
 		$stackMembers = $this->project->listMembers();
 		$role = null;
 
-		foreach ($stackMembers as $stackMember) {
-			if ($stackMember['MemberID'] !== $member->ID) {
+		foreach($stackMembers as $stackMember) {
+			if($stackMember['MemberID'] !== $member->ID) {
 				continue;
 			}