Completed
Pull Request — master (#643)
by Stig
07:07
created
code/model/jobs/DNDataTransfer.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -112,7 +112,7 @@  discard block
 block discarded – undo
112 112
 	}
113 113
 
114 114
 	public function getTitle() {
115
-		return $this->dbObject('Created')->Nice() . " (Status: {$this->Status})";
115
+		return $this->dbObject('Created')->Nice()." (Status: {$this->Status})";
116 116
 	}
117 117
 
118 118
 	public function Link() {
@@ -233,14 +233,14 @@  discard block
 block discarded – undo
233 233
 		$envName = $this->Environment()->getFullName();
234 234
 		if($this->Direction == 'get') {
235 235
 			if($this->Origin == 'ManualUpload') {
236
-				$description = 'Manual upload of ' . $this->getModeNice() . ' to ' . $envName;
236
+				$description = 'Manual upload of '.$this->getModeNice().' to '.$envName;
237 237
 			} elseif($this->IsBackupDataTransfer()) {
238
-				$description = 'Automated backup of ' . $this->getModeNice() . ' from ' . $envName;
238
+				$description = 'Automated backup of '.$this->getModeNice().' from '.$envName;
239 239
 			} else {
240
-				$description = 'Backup of ' . $this->getModeNice() . ' to ' . $envName;
240
+				$description = 'Backup of '.$this->getModeNice().' to '.$envName;
241 241
 			}
242 242
 		} else {
243
-			$description = 'Restore ' . $this->getModeNice() . ' to ' . $envName;
243
+			$description = 'Restore '.$this->getModeNice().' to '.$envName;
244 244
 		}
245 245
 
246 246
 		return $description;
Please login to merge, or discard this patch.
code/model/DNBranch.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -50,19 +50,19 @@
 block discarded – undo
50 50
 	 * @return string
51 51
 	 */
52 52
 	public function Name() {
53
-		return (string) htmlentities($this->branch->getName());
53
+		return (string)htmlentities($this->branch->getName());
54 54
 	}
55 55
 
56 56
 	public function Link() {
57 57
 		// Use a get-var for branch so that it can handle unsafe chars better
58
-		return Controller::join_links($this->project->Link(), 'branch?name=' . urlencode($this->Name()));
58
+		return Controller::join_links($this->project->Link(), 'branch?name='.urlencode($this->Name()));
59 59
 	}
60 60
 
61 61
 	/**
62 62
 	 * @return string
63 63
 	 */
64 64
 	public function SHA() {
65
-		return (string) htmlentities($this->branch->getCommit()->getHash());
65
+		return (string)htmlentities($this->branch->getCommit()->getHash());
66 66
 	}
67 67
 
68 68
 	/**
Please login to merge, or discard this patch.
code/model/jobs/DNDeployment.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -101,7 +101,7 @@  discard block
 block discarded – undo
101 101
 	}
102 102
 
103 103
 	public function LogLink() {
104
-		return $this->Link() . '/log';
104
+		return $this->Link().'/log';
105 105
 	}
106 106
 
107 107
 	public function canView($member = null) {
@@ -176,7 +176,7 @@  discard block
 block discarded – undo
176 176
 		if (!$interface) {
177 177
 			return null;
178 178
 		}
179
-		return $interface->CommitURL . '/' . $this->SHA;
179
+		return $interface->CommitURL.'/'.$this->SHA;
180 180
 	}
181 181
 
182 182
 	/**
Please login to merge, or discard this patch.
code/model/DNDataArchive.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -227,7 +227,7 @@  discard block
 block discarded – undo
227 227
 			return false;
228 228
 		}
229 229
 
230
-		$key = $memberID . '-' . $this->EnvironmentID;
230
+		$key = $memberID.'-'.$this->EnvironmentID;
231 231
 		if (!isset(self::$_cache_can_restore[$key])) {
232 232
 			self::$_cache_can_restore[$key] = $this->Environment()->canUploadArchive($member);
233 233
 		}
@@ -248,7 +248,7 @@  discard block
 block discarded – undo
248 248
 			return false;
249 249
 		}
250 250
 
251
-		$key = $memberID . '-' . $this->EnvironmentID;
251
+		$key = $memberID.'-'.$this->EnvironmentID;
252 252
 		if (!isset(self::$_cache_can_download[$key])) {
253 253
 			self::$_cache_can_download[$key] = $this->Environment()->canDownloadArchive($member);
254 254
 		}
@@ -313,7 +313,7 @@  discard block
 block discarded – undo
313 313
 	public function validTargetEnvironments() {
314 314
 		$archive = $this;
315 315
 		$envs = $this->Environment()->Project()->DNEnvironmentList()
316
-			->filterByCallback(function ($item) use ($archive) {
316
+			->filterByCallback(function($item) use ($archive) {
317 317
 				return $archive->EnvironmentID != $item->ID && $archive->canMoveTo($item);
318 318
 			});
319 319
 
@@ -407,7 +407,7 @@  discard block
 block discarded – undo
407 407
 			mkdir($workingDir, 0700, true);
408 408
 		}
409 409
 
410
-		$cleanupFn = function () use ($workingDir) {
410
+		$cleanupFn = function() use ($workingDir) {
411 411
 			$process = new AbortableProcess(sprintf('rm -rf %s', escapeshellarg($workingDir)));
412 412
 			$process->setTimeout(120);
413 413
 			$process->run();
@@ -428,7 +428,7 @@  discard block
 block discarded – undo
428 428
 		}
429 429
 
430 430
 		// Extract database.sql.gz to <workingdir>/database.sql
431
-		if (file_exists($workingDir . DIRECTORY_SEPARATOR . 'database.sql.gz')) {
431
+		if (file_exists($workingDir.DIRECTORY_SEPARATOR.'database.sql.gz')) {
432 432
 			$process = new AbortableProcess('gunzip database.sql.gz', $workingDir);
433 433
 			$process->setTimeout(3600);
434 434
 			$process->run();
@@ -439,7 +439,7 @@  discard block
 block discarded – undo
439 439
 		}
440 440
 
441 441
 		// Extract assets.tar.gz to <workingdir>/assets/
442
-		if (file_exists($workingDir . DIRECTORY_SEPARATOR . 'assets.tar.gz')) {
442
+		if (file_exists($workingDir.DIRECTORY_SEPARATOR.'assets.tar.gz')) {
443 443
 			$process = new AbortableProcess('tar xzf assets.tar.gz', $workingDir);
444 444
 			$process->setTimeout(3600);
445 445
 			$process->run();
Please login to merge, or discard this patch.
code/model/DNProject.php 1 patch
Spacing   +16 added lines, -16 removed lines patch added patch discarded remove patch
@@ -311,7 +311,7 @@  discard block
 block discarded – undo
311 311
 			return true;
312 312
 		}
313 313
 
314
-		return (bool) $this->Environments()->filterByCallback(function ($env) use ($member) {
314
+		return (bool)$this->Environments()->filterByCallback(function($env) use ($member) {
315 315
 			return $env->canRestore($member);
316 316
 		})->Count();
317 317
 	}
@@ -332,7 +332,7 @@  discard block
 block discarded – undo
332 332
 			return true;
333 333
 		}
334 334
 
335
-		return (bool) $this->Environments()->filterByCallback(function ($env) use ($member) {
335
+		return (bool)$this->Environments()->filterByCallback(function($env) use ($member) {
336 336
 			return $env->canBackup($member);
337 337
 		})->Count();
338 338
 	}
@@ -353,7 +353,7 @@  discard block
 block discarded – undo
353 353
 			return true;
354 354
 		}
355 355
 
356
-		return (bool) $this->Environments()->filterByCallback(function ($env) use ($member) {
356
+		return (bool)$this->Environments()->filterByCallback(function($env) use ($member) {
357 357
 			return $env->canUploadArchive($member);
358 358
 		})->Count();
359 359
 	}
@@ -374,7 +374,7 @@  discard block
 block discarded – undo
374 374
 			return true;
375 375
 		}
376 376
 
377
-		return (bool) $this->Environments()->filterByCallback(function ($env) use ($member) {
377
+		return (bool)$this->Environments()->filterByCallback(function($env) use ($member) {
378 378
 			return $env->canDownloadArchive($member);
379 379
 		})->Count();
380 380
 	}
@@ -433,7 +433,7 @@  discard block
 block discarded – undo
433 433
 			// Key-pair is available, use it.
434 434
 			$processEnv = [
435 435
 				'IDENT_KEY' => $this->getPrivateKeyPath(),
436
-				'GIT_SSH' => BASE_PATH . "/deploynaut/git-deploy.sh"
436
+				'GIT_SSH' => BASE_PATH."/deploynaut/git-deploy.sh"
437 437
 			];
438 438
 		} else {
439 439
 			$processEnv = [];
@@ -521,7 +521,7 @@  discard block
 block discarded – undo
521 521
 
522 522
 		$currentMember = self::$_current_member_cache;
523 523
 		return $this->Environments()
524
-			->filterByCallBack(function ($item) use ($currentMember) {
524
+			->filterByCallBack(function($item) use ($currentMember) {
525 525
 				return $item->canView($currentMember);
526 526
 			});
527 527
 	}
@@ -540,14 +540,14 @@  discard block
 block discarded – undo
540 540
 	 * @return false|DNDeployment
541 541
 	 */
542 542
 	public function currentBuilds() {
543
-		if (!isset(self::$relation_cache['currentBuilds.' . $this->ID])) {
543
+		if (!isset(self::$relation_cache['currentBuilds.'.$this->ID])) {
544 544
 			$currentBuilds = [];
545 545
 			foreach ($this->Environments() as $env) {
546 546
 				$currentBuilds[$env->Name] = $env->CurrentBuild();
547 547
 			}
548
-			self::$relation_cache['currentBuilds.' . $this->ID] = $currentBuilds;
548
+			self::$relation_cache['currentBuilds.'.$this->ID] = $currentBuilds;
549 549
 		}
550
-		return self::$relation_cache['currentBuilds.' . $this->ID];
550
+		return self::$relation_cache['currentBuilds.'.$this->ID];
551 551
 	}
552 552
 
553 553
 	/**
@@ -788,7 +788,7 @@  discard block
 block discarded – undo
788 788
 	 */
789 789
 	public function getPublicKeyPath() {
790 790
 		if ($privateKey = $this->getPrivateKeyPath()) {
791
-			return $privateKey . '.pub';
791
+			return $privateKey.'.pub';
792 792
 		}
793 793
 		return null;
794 794
 	}
@@ -803,7 +803,7 @@  discard block
 block discarded – undo
803 803
 		if (!empty($keyDir)) {
804 804
 			$filter = FileNameFilter::create();
805 805
 			$name = $filter->filter($this->Name);
806
-			return $keyDir . '/' . $name;
806
+			return $keyDir.'/'.$name;
807 807
 		}
808 808
 		return null;
809 809
 	}
@@ -822,7 +822,7 @@  discard block
 block discarded – undo
822 822
 		$filter = FileNameFilter::create();
823 823
 		$name = $filter->filter($this->Name);
824 824
 
825
-		return $this->DNData()->getKeyDir() . '/' . $name;
825
+		return $this->DNData()->getKeyDir().'/'.$name;
826 826
 	}
827 827
 
828 828
 	/**
@@ -848,7 +848,7 @@  discard block
 block discarded – undo
848 848
 		/* Look for each whitelisted hostname */
849 849
 		foreach ($interfaces as $host => $interface) {
850 850
 			/* See if the CVS Path is for this hostname, followed by some junk (maybe a port), then the path */
851
-			if (preg_match('{^[^.]*' . $host . '(.*?)([/a-zA-Z].+)}', $this->CVSPath, $match)) {
851
+			if (preg_match('{^[^.]*'.$host.'(.*?)([/a-zA-Z].+)}', $this->CVSPath, $match)) {
852 852
 
853 853
 				$path = $match[2];
854 854
 
@@ -859,10 +859,10 @@  discard block
 block discarded – undo
859 859
 				$components = explode('.', $host);
860 860
 
861 861
 				foreach ($regex as $pattern => $replacement) {
862
-					$path = preg_replace('/' . $pattern . '/', $replacement, $path);
862
+					$path = preg_replace('/'.$pattern.'/', $replacement, $path);
863 863
 				}
864 864
 
865
-				$uxurl = Controller::join_links($scheme . '://', $host, $path);
865
+				$uxurl = Controller::join_links($scheme.'://', $host, $path);
866 866
 
867 867
 				if (array_key_exists('commit', $interface) && $interface['commit'] == false) {
868 868
 					$commiturl = false;
@@ -989,7 +989,7 @@  discard block
 block discarded – undo
989 989
 		// {@see DataObject::extendedCan()}
990 990
 		$isDone = $this->extend('isProjectReady');
991 991
 		if ($isDone && is_array($isDone)) {
992
-			$isDone = array_filter($isDone, function ($val) {
992
+			$isDone = array_filter($isDone, function($val) {
993 993
 				return !is_null($val);
994 994
 			});
995 995
 
Please login to merge, or discard this patch.
code/model/DNEnvironment.php 1 patch
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -774,7 +774,7 @@  discard block
 block discarded – undo
774 774
 				->buildPermissionField('ArchiveUploaderGroups', 'ArchiveUploaders', $groups, $members)
775 775
 				->setTitle('Who can upload?')
776 776
 				->setDescription(
777
-					'Users who can upload archives linked to this environment into Deploynaut.<br />' .
777
+					'Users who can upload archives linked to this environment into Deploynaut.<br />'.
778 778
 					'Linking them to an environment allows limiting download permissions (see below).'
779 779
 				),
780 780
 
@@ -821,7 +821,7 @@  discard block
 block discarded – undo
821 821
 		// Add actions
822 822
 		$action = new FormAction('check', 'Check Connection');
823 823
 		$action->setUseButtonTag(true);
824
-		$dataURL = Director::absoluteBaseURL() . 'naut/api/' . $this->Project()->Name . '/' . $this->Name . '/ping';
824
+		$dataURL = Director::absoluteBaseURL().'naut/api/'.$this->Project()->Name.'/'.$this->Name.'/ping';
825 825
 		$action->setAttribute('data-url', $dataURL);
826 826
 		$fields->insertBefore($action, 'Name');
827 827
 
@@ -834,8 +834,8 @@  discard block
 block discarded – undo
834 834
 	 */
835 835
 	public function onBeforeWrite() {
836 836
 		parent::onBeforeWrite();
837
-		if ($this->Name && $this->Name . '.rb' != $this->Filename) {
838
-			$this->Filename = $this->Name . '.rb';
837
+		if ($this->Name && $this->Name.'.rb' != $this->Filename) {
838
+			$this->Filename = $this->Name.'.rb';
839 839
 		}
840 840
 		$this->checkEnvironmentPath();
841 841
 		$this->writeConfigFile();
@@ -885,7 +885,7 @@  discard block
 block discarded – undo
885 885
 		if (!$this->Filename) {
886 886
 			return '';
887 887
 		}
888
-		return $this->DNData()->getEnvironmentDir() . '/' . $this->Project()->Name . '/' . $this->Filename;
888
+		return $this->DNData()->getEnvironmentDir().'/'.$this->Project()->Name.'/'.$this->Filename;
889 889
 	}
890 890
 
891 891
 	/**
@@ -947,9 +947,9 @@  discard block
 block discarded – undo
947 947
 			if ($repo !== false) {
948 948
 				$commit = new \Gitonomy\Git\Commit($repo, $sha);
949 949
 				return [
950
-					'AuthorName' => (string) Convert::raw2xml($commit->getAuthorName()),
951
-					'AuthorEmail' => (string) Convert::raw2xml($commit->getAuthorEmail()),
952
-					'Message' => (string) Convert::raw2xml($commit->getMessage()),
950
+					'AuthorName' => (string)Convert::raw2xml($commit->getAuthorName()),
951
+					'AuthorEmail' => (string)Convert::raw2xml($commit->getAuthorEmail()),
952
+					'Message' => (string)Convert::raw2xml($commit->getMessage()),
953 953
 					'ShortHash' => Convert::raw2xml($commit->getFixedShortHash(8)),
954 954
 					'Hash' => Convert::raw2xml($commit->getHash())
955 955
 				];
@@ -1039,7 +1039,7 @@  discard block
 block discarded – undo
1039 1039
 			&& $this->Filename
1040 1040
 			&& $this->CreateEnvConfig
1041 1041
 		) {
1042
-			$templateFile = $this->config()->template_file ?: BASE_PATH . '/deploynaut/environment.template';
1042
+			$templateFile = $this->config()->template_file ?: BASE_PATH.'/deploynaut/environment.template';
1043 1043
 			file_put_contents($this->getConfigFilename(), file_get_contents($templateFile));
1044 1044
 		} else if ($this->envFileExists() && $this->DeployConfig) {
1045 1045
 			file_put_contents($this->getConfigFilename(), $this->DeployConfig);
Please login to merge, or discard this patch.