Completed
Pull Request — master (#598)
by Sean
06:33 queued 03:19
created
code/control/DNRoot.php 1 patch
Spacing   +28 added lines, -28 removed lines patch added patch discarded remove patch
@@ -174,8 +174,8 @@  discard block
 block discarded – undo
174 174
 		Requirements::javascript('deploynaut/javascript/material.js');
175 175
 
176 176
 		// Load the buildable dependencies only if not loaded centrally.
177
-		if (!is_dir(BASE_PATH . DIRECTORY_SEPARATOR . 'static')) {
178
-			if (\Director::isDev()) {
177
+		if(!is_dir(BASE_PATH.DIRECTORY_SEPARATOR.'static')) {
178
+			if(\Director::isDev()) {
179 179
 				\Requirements::javascript('deploynaut/static/bundle-debug.js');
180 180
 			} else {
181 181
 				\Requirements::javascript('deploynaut/static/bundle.js');
@@ -238,7 +238,7 @@  discard block
 block discarded – undo
238 238
 		}
239 239
 
240 240
 		// Block framework jquery
241
-		Requirements::block(FRAMEWORK_DIR . '/thirdparty/jquery/jquery.js');
241
+		Requirements::block(FRAMEWORK_DIR.'/thirdparty/jquery/jquery.js');
242 242
 
243 243
 		self::include_requirements();
244 244
 	}
@@ -257,7 +257,7 @@  discard block
 block discarded – undo
257 257
 	 * @return \SS_HTTPResponse
258 258
 	 */
259 259
 	public function index(SS_HTTPRequest $request) {
260
-		return $this->redirect($this->Link() . 'projects/');
260
+		return $this->redirect($this->Link().'projects/');
261 261
 	}
262 262
 
263 263
 	/**
@@ -417,7 +417,7 @@  discard block
 block discarded – undo
417 417
 		$form->disableSecurityToken();
418 418
 		$form->addExtraClass('fields-wide');
419 419
 		// Tweak the action so it plays well with our fake URL structure.
420
-		$form->setFormAction($project->Link() . '/UploadSnapshotForm');
420
+		$form->setFormAction($project->Link().'/UploadSnapshotForm');
421 421
 
422 422
 		return $form;
423 423
 	}
@@ -467,7 +467,7 @@  discard block
 block discarded – undo
467 467
 		$dataArchive->DataTransfers()->add($dataTransfer);
468 468
 		$form->saveInto($dataArchive);
469 469
 		$dataArchive->write();
470
-		$workingDir = TEMP_FOLDER . DIRECTORY_SEPARATOR . 'deploynaut-transfer-' . $dataTransfer->ID;
470
+		$workingDir = TEMP_FOLDER.DIRECTORY_SEPARATOR.'deploynaut-transfer-'.$dataTransfer->ID;
471 471
 
472 472
 		$cleanupFn = function() use($workingDir, $dataTransfer, $dataArchive) {
473 473
 			$process = new AbortableProcess(sprintf('rm -rf %s', escapeshellarg($workingDir)));
@@ -569,7 +569,7 @@  discard block
 block discarded – undo
569 569
 		$form->disableSecurityToken();
570 570
 		$form->addExtraClass('fields-wide');
571 571
 		// Tweak the action so it plays well with our fake URL structure.
572
-		$form->setFormAction($project->Link() . '/PostSnapshotForm');
572
+		$form->setFormAction($project->Link().'/PostSnapshotForm');
573 573
 
574 574
 		return $form;
575 575
 	}
@@ -708,7 +708,7 @@  discard block
 block discarded – undo
708 708
 		$branchName = $request->getVar('name');
709 709
 		$branch = $project->DNBranchList()->byName($branchName);
710 710
 		if(!$branch) {
711
-			return new SS_HTTPResponse("Branch '" . Convert::raw2xml($branchName) . "' not found.", 404);
711
+			return new SS_HTTPResponse("Branch '".Convert::raw2xml($branchName)."' not found.", 404);
712 712
 		}
713 713
 
714 714
 		return $this->render(array(
@@ -844,7 +844,7 @@  discard block
 block discarded – undo
844 844
 		);
845 845
 
846 846
 		// Tweak the action so it plays well with our fake URL structure.
847
-		$form->setFormAction($project->Link() . '/CreateEnvironmentForm');
847
+		$form->setFormAction($project->Link().'/CreateEnvironmentForm');
848 848
 
849 849
 		return $form;
850 850
 	}
@@ -877,7 +877,7 @@  discard block
 block discarded – undo
877 877
 		$job->write();
878 878
 		$job->start();
879 879
 
880
-		return $this->redirect($project->Link('createenv') . '/' . $job->ID);
880
+		return $this->redirect($project->Link('createenv').'/'.$job->ID);
881 881
 	}
882 882
 
883 883
 	/**
@@ -938,7 +938,7 @@  discard block
 block discarded – undo
938 938
 	 */
939 939
 	public function getPlatformSpecificStrings() {
940 940
 		$strings = $this->config()->platform_specific_strings;
941
-		if ($strings) {
941
+		if($strings) {
942 942
 			return new ArrayList($strings);
943 943
 		}
944 944
 	}
@@ -1003,7 +1003,7 @@  discard block
 block discarded – undo
1003 1003
 
1004 1004
 				$isCurrentEnvironment = false;
1005 1005
 				if($project && $currentEnvironment) {
1006
-					$isCurrentEnvironment = (bool) $project->DNEnvironmentList()->find('ID', $currentEnvironment->ID);
1006
+					$isCurrentEnvironment = (bool)$project->DNEnvironmentList()->find('ID', $currentEnvironment->ID);
1007 1007
 				}
1008 1008
 
1009 1009
 				$navigation->push(array(
@@ -1073,7 +1073,7 @@  discard block
 block discarded – undo
1073 1073
 			return $body;
1074 1074
 		}
1075 1075
 
1076
-		$form->setFormAction($this->getRequest()->getURL() . '/DeployForm');
1076
+		$form->setFormAction($this->getRequest()->getURL().'/DeployForm');
1077 1077
 		return $form;
1078 1078
 	}
1079 1079
 
@@ -1229,7 +1229,7 @@  discard block
 block discarded – undo
1229 1229
 	}
1230 1230
 
1231 1231
 	protected function applyRedeploy(SS_HTTPRequest $request, &$data) {
1232
-		if (!$request->getVar('redeploy')) return;
1232
+		if(!$request->getVar('redeploy')) return;
1233 1233
 
1234 1234
 		$project = $this->getCurrentProject();
1235 1235
 		if(!$project) {
@@ -1243,12 +1243,12 @@  discard block
 block discarded – undo
1243 1243
 		}
1244 1244
 
1245 1245
 		$current = $env->CurrentBuild();
1246
-		if ($current && $current->exists()) {
1246
+		if($current && $current->exists()) {
1247 1247
 			$data['preselect_tab'] = 3;
1248 1248
 			$data['preselect_sha'] = $current->SHA;
1249 1249
 		} else {
1250 1250
 			$master = $project->DNBranchList()->byName('master');
1251
-			if ($master) {
1251
+			if($master) {
1252 1252
 				$data['preselect_tab'] = 1;
1253 1253
 				$data['preselect_sha'] = $master->SHA();
1254 1254
 			}
@@ -1379,7 +1379,7 @@  discard block
 block discarded – undo
1379 1379
 		$deployment->getMachine()->apply(DNDeployment::TR_QUEUE);
1380 1380
 
1381 1381
 		return json_encode(array(
1382
-			'url' => Director::absoluteBaseURL() . $deployment->Link()
1382
+			'url' => Director::absoluteBaseURL().$deployment->Link()
1383 1383
 		), JSON_PRETTY_PRINT);
1384 1384
 	}
1385 1385
 
@@ -1483,7 +1483,7 @@  discard block
 block discarded – undo
1483 1483
 			throw new LogicException("Project in URL doesn't match this deploy");
1484 1484
 		}
1485 1485
 
1486
-		if (!in_array($deployment->Status, ['Queued', 'Deploying', 'Aborting'])) {
1486
+		if(!in_array($deployment->Status, ['Queued', 'Deploying', 'Aborting'])) {
1487 1487
 			throw new LogicException(sprintf("Cannot abort from %s state.", $deployment->Status));
1488 1488
 		}
1489 1489
 
@@ -1521,7 +1521,7 @@  discard block
 block discarded – undo
1521 1521
 					->addExtraClass('btn')
1522 1522
 			)
1523 1523
 		);
1524
-		$form->setFormAction($this->getRequest()->getURL() . '/DataTransferForm');
1524
+		$form->setFormAction($this->getRequest()->getURL().'/DataTransferForm');
1525 1525
 
1526 1526
 		return $form;
1527 1527
 	}
@@ -1593,12 +1593,12 @@  discard block
 block discarded – undo
1593 1593
 
1594 1594
 		$backupMode = null;
1595 1595
 		// if we're only restoring the database, there's no need to backup the assets
1596
-		if (!empty($data['BackupFirst']) && $data['Mode'] == 'db') {
1596
+		if(!empty($data['BackupFirst']) && $data['Mode'] == 'db') {
1597 1597
 			$backupMode = 'db';
1598
-		} elseif (!empty($data['BackupFirst'])) {
1598
+		} elseif(!empty($data['BackupFirst'])) {
1599 1599
 			$backupMode = 'all';
1600 1600
 		}
1601
-		if ($backupMode !== null && $data['Direction'] == 'push') {
1601
+		if($backupMode !== null && $data['Direction'] == 'push') {
1602 1602
 			$backupTransfer = DNDataTransfer::create();
1603 1603
 			$backupTransfer->EnvironmentID = $environment->ID;
1604 1604
 			$backupTransfer->Direction = 'get';
@@ -1740,7 +1740,7 @@  discard block
 block discarded – undo
1740 1740
 					->addExtraClass('btn')
1741 1741
 			)
1742 1742
 		);
1743
-		$form->setFormAction($project->Link() . '/DataTransferRestoreForm');
1743
+		$form->setFormAction($project->Link().'/DataTransferRestoreForm');
1744 1744
 
1745 1745
 		return $form;
1746 1746
 	}
@@ -1838,7 +1838,7 @@  discard block
 block discarded – undo
1838 1838
 					->addExtraClass('btn')
1839 1839
 			)
1840 1840
 		);
1841
-		$form->setFormAction($project->Link() . '/DeleteForm');
1841
+		$form->setFormAction($project->Link().'/DeleteForm');
1842 1842
 
1843 1843
 		return $form;
1844 1844
 	}
@@ -1944,7 +1944,7 @@  discard block
 block discarded – undo
1944 1944
 					->addExtraClass('btn')
1945 1945
 			)
1946 1946
 		);
1947
-		$form->setFormAction($this->getCurrentProject()->Link() . '/MoveForm');
1947
+		$form->setFormAction($this->getCurrentProject()->Link().'/MoveForm');
1948 1948
 
1949 1949
 		return $form;
1950 1950
 	}
@@ -2236,7 +2236,7 @@  discard block
 block discarded – undo
2236 2236
 	 */
2237 2237
 	protected function project404Response() {
2238 2238
 		return new SS_HTTPResponse(
2239
-			"Project '" . Convert::raw2xml($this->getRequest()->param('Project')) . "' not found.",
2239
+			"Project '".Convert::raw2xml($this->getRequest()->param('Project'))."' not found.",
2240 2240
 			404
2241 2241
 		);
2242 2242
 	}
@@ -2246,7 +2246,7 @@  discard block
 block discarded – undo
2246 2246
 	 */
2247 2247
 	protected function environment404Response() {
2248 2248
 		$envName = Convert::raw2xml($this->getRequest()->param('Environment'));
2249
-		return new SS_HTTPResponse("Environment '" . $envName . "' not found.", 404);
2249
+		return new SS_HTTPResponse("Environment '".$envName."' not found.", 404);
2250 2250
 	}
2251 2251
 
2252 2252
 	/**
@@ -2313,7 +2313,7 @@  discard block
 block discarded – undo
2313 2313
 	public function AmbientMenu() {
2314 2314
 		$list = new ArrayList();
2315 2315
 
2316
-		if (Member::currentUserID()) {
2316
+		if(Member::currentUserID()) {
2317 2317
 			$list->push(new ArrayData(array(
2318 2318
 				'Classes' => 'logout',
2319 2319
 				'FaIcon' => 'sign-out',
Please login to merge, or discard this patch.