silverstripe / cwp

code/model/QuickLink.php

Spacing +3 added lines, -3 removed lines

@@ -34,7 +34,7 @@ 
 			$url = parse_url($this->ExternalLink);
 
 			// if no scheme set in the link, default to http
-			if(!isset($url['scheme'])) {
+			if (!isset($url['scheme'])) {
 				return 'http://' . $this->ExternalLink;
 			}
 
@@ -72,7 +72,7 @@ 
 		$fields->removeByName('SortOrder');
 		$externalLinkField->addExtraClass('noBorder');
 
-		$fields->addFieldToTab('Root.Main',CompositeField::create(
+		$fields->addFieldToTab('Root.Main', CompositeField::create(
 			array(
 				TreeDropdownField::create(
 					'InternalLinkID', 
@@ -83,7 +83,7 @@ 
 				$wrap = CompositeField::create(
 					$extraLabel = LiteralField::create(
 						'NoteOverride', 
-						_t('Quicklink.Note','<div class="message good notice">Note:  If you specify an External Link, the Internal Link will be ignored.</div>')
+						_t('Quicklink.Note', '<div class="message good notice">Note:  If you specify an External Link, the Internal Link will be ignored.</div>')
 					)
 				)
 			)

code/pagetypes/EventHolder.php

Spacing +2 added lines, -2 removed lines

@@ -14,7 +14,7 @@ 
 
 	private static $icon = 'cwp/images/icons/sitetree_images/event_holder.png';
 
-	public $pageIcon =  'images/icons/sitetree_images/event_holder.png';
+	public $pageIcon = 'images/icons/sitetree_images/event_holder.png';
 
 	private static $singular_name = 'Event Holder';
 
@@ -58,7 +58,7 @@ 
 	public function getUpdateName() {
 		$params = $this->parseParams();
 		if ($params['upcomingOnly']) {
-			return _t('EventHolder.Upcoming','Upcoming events');
+			return _t('EventHolder.Upcoming', 'Upcoming events');
 		}
 
 		return 'Events';

code/pagetypes/NewsHolder.php

Spacing +1 added lines, -1 removed lines

@@ -14,7 +14,7 @@
 
 	private static $icon = 'cwp/images/icons/sitetree_images/news_listing.png';
 
-	public $pageIcon =  'images/icons/sitetree_images/news_listing.png';
+	public $pageIcon = 'images/icons/sitetree_images/news_listing.png';
 
 	private static $singular_name = 'News Holder';
 

code/pagetypes/DatedUpdateHolder.php

Braces +30 added lines, -10 removed lines

@@ -313,13 +313,25 @@ 
 		$year = $this->request->getVar('year');
 		$month = $this->request->getVar('month');
 
-		if ($tag=='') $tag = null;
-		if ($from=='') $from = null;
-		if ($to=='') $to = null;
-		if ($year=='') $year = null;
-		if ($month=='') $month = null;
+		if ($tag=='') {
+			$tag = null;
+		}
+		if ($from=='') {
+			$from = null;
+		}
+		if ($to=='') {
+			$to = null;
+		}
+		if ($year=='') {
+			$year = null;
+		}
+		if ($month=='') {
+			$month = null;
+		}
 
-		if (isset($tag)) $tag = (int)$tag;
+		if (isset($tag)) {
+			$tag = (int)$tag;
+		}
 		if (isset($from)) {
 			$from = urldecode($from);
 			$parser = new SS_Datetime;
@@ -332,8 +344,12 @@ 
 			$parser->setValue($to);
 			$to = $parser->Format('Y-m-d');
 		}
-		if (isset($year)) $year = (int)$year;
-		if (isset($month)) $month = (int)$month;
+		if (isset($year)) {
+			$year = (int)$year;
+		}
+		if (isset($month)) {
+			$month = (int)$month;
+		}
 
 		// If only "To" has been provided filter by single date. Normalise by swapping with "From".
 		if (isset($to) && !isset($from)) {
@@ -499,7 +515,9 @@ 
 		// Build the link - keep the tag, but reset month, year and pagination.
 		$link = HTTP::setGetVar('from', $params['from'], $this->AbsoluteLink(), '&');
 		$link = HTTP::setGetVar('to', $params['to'], $link, '&');
-		if (isset($params['tag'])) $link = HTTP::setGetVar('tag', $params['tag'], $link, '&');
+		if (isset($params['tag'])) {
+			$link = HTTP::setGetVar('tag', $params['tag'], $link, '&');
+		}
 
 		$this->redirect($link);
 	}
@@ -509,7 +527,9 @@ 
 
 		// Reset the link - only include the tag.
 		$link = $this->AbsoluteLink();
-		if (isset($params['tag'])) $link = HTTP::setGetVar('tag', $params['tag'], $link, '&');
+		if (isset($params['tag'])) {
+			$link = HTTP::setGetVar('tag', $params['tag'], $link, '&');
+		}
 
 		$this->redirect($link);
 	}

Spacing +16 added lines, -16 removed lines

@@ -86,8 +86,8 @@ 
 
 		// Filter down to single month.
 		if (isset($year) && isset($monthNumber)) {
-			$year = (int)$year;
-			$monthNumber = (int)$monthNumber;
+			$year = (int) $year;
+			$monthNumber = (int) $monthNumber;
 
 			$beginDate = sprintf("%d-%d-01 00:00:00", $year, $monthNumber);
 			$endDate = date('Y-m-d H:i:s', strtotime("{$beginDate} +1 month"));
@@ -159,7 +159,7 @@ 
 			// Check if the currently processed month is the one that is selected via GET params.
 			$active = false;
 			if (isset($year) && isset($monthNumber)) {
-				$active = (((int)$currentYear)==$year && ((int)$currentMonthNumber)==$monthNumber);
+				$active = (((int) $currentYear) == $year && ((int) $currentMonthNumber) == $monthNumber);
 			}
 
 			// Build the link - keep the tag and date filter, but reset the pagination.
@@ -238,7 +238,7 @@ 
 	public function getMetaTitle() {
 		$title = $this->data()->getTitle();
 		$filter = $this->FilterDescription();
-		if($filter) {
+		if ($filter) {
 			$title = "{$title} - {$filter}";
 		}
 
@@ -309,13 +309,13 @@ 
 		$year = $this->request->getVar('year');
 		$month = $this->request->getVar('month');
 
-		if ($tag=='') $tag = null;
-		if ($from=='') $from = null;
-		if ($to=='') $to = null;
-		if ($year=='') $year = null;
-		if ($month=='') $month = null;
+		if ($tag == '') $tag = null;
+		if ($from == '') $from = null;
+		if ($to == '') $to = null;
+		if ($year == '') $year = null;
+		if ($month == '') $month = null;
 
-		if (isset($tag)) $tag = (int)$tag;
+		if (isset($tag)) $tag = (int) $tag;
 		if (isset($from)) {
 			$from = urldecode($from);
 			$parser = new SS_Datetime;
@@ -328,8 +328,8 @@ 
 			$parser->setValue($to);
 			$to = $parser->Format('Y-m-d');
 		}
-		if (isset($year)) $year = (int)$year;
-		if (isset($month)) $month = (int)$month;
+		if (isset($year)) $year = (int) $year;
+		if (isset($month)) $month = (int) $month;
 
 		// If only "To" has been provided filter by single date. Normalise by swapping with "From".
 		if (isset($to) && !isset($from)) {
@@ -337,13 +337,13 @@ 
 		}
 
 		// Flip the dates if the order is wrong.
-		if (isset($to) && isset($from) && strtotime($from)>strtotime($to)) {
+		if (isset($to) && isset($from) && strtotime($from) > strtotime($to)) {
 			list($to, $from) = array($from, $to);
 
 			if ($produceErrorMessages) {
 				Session::setFormMessage(
 					'Form_DateRangeForm',
-					_t('DateUpdateHolder.FilterAppliedMessage','Filter has been applied with the dates reversed.'),
+					_t('DateUpdateHolder.FilterAppliedMessage', 'Filter has been applied with the dates reversed.'),
 					'warning'
 				);
 			}
@@ -354,7 +354,7 @@ 
 			if ($produceErrorMessages) {
 				Session::setFormMessage(
 					'Form_DateRangeForm',
-					_t('DateUpdateHolder.DateRangeFilterMessage','Filtered by a single date.'),
+					_t('DateUpdateHolder.DateRangeFilterMessage', 'Filtered by a single date.'),
 					'warning'
 				);
 			}
@@ -410,7 +410,7 @@ 
 		$tagID = $this->request->getVar('tag');
 
 		if (isset($tagID)) {
-			return TaxonomyTerm::get_by_id('TaxonomyTerm', (int)$tagID);
+			return TaxonomyTerm::get_by_id('TaxonomyTerm', (int) $tagID);
 		}
 	}
 

code/extensions/CwpWorkflowDefinitionExtension.php

Spacing +2 added lines, -2 removed lines

@@ -14,10 +14,10 @@
 	private static $create_default_workflow = true;
 
 	public function requireDefaultRecords() {
-		if(Config::inst()->get('CwpWorkflowDefinitionExtension', 'create_default_workflow')) {
+		if (Config::inst()->get('CwpWorkflowDefinitionExtension', 'create_default_workflow')) {
 			// Only proceed if a definition using this template has not been created yet
 			$definition = WorkflowDefinition::get()->filter("Template", "Review and Approve")->First();
-			if($definition && $definition->exists()) return;
+			if ($definition && $definition->exists()) return;
 
 			//generate from the template, which happens after we write the definition
 			$definition = WorkflowDefinition::create();

Braces +3 added lines, -1 removed lines

@@ -17,7 +17,9 @@
 		if(Config::inst()->get('CwpWorkflowDefinitionExtension', 'create_default_workflow')) {
 			// Only proceed if a definition using this template has not been created yet
 			$definition = WorkflowDefinition::get()->filter("Template", "Review and Approve")->First();
-			if($definition && $definition->exists()) return;
+			if($definition && $definition->exists()) {
+				return;
+			}
 
 			//generate from the template, which happens after we write the definition
 			$definition = WorkflowDefinition::create();

code/extensions/SynonymValidator.php

Spacing +11 added lines, -11 removed lines

@@ -25,8 +25,8 @@ 
 	 * @return mixed
 	 */
 	public function php($data) {
-		foreach($this->fieldNames as $fieldName) {
-			if(empty($data[$fieldName])) {
+		foreach ($this->fieldNames as $fieldName) {
+			if (empty($data[$fieldName])) {
 				return;
 			}
 
@@ -41,7 +41,7 @@ 
 	 * @param mixed $value
 	 */
 	protected function validateField($fieldName, $value) {
-		if(!$this->validateValue($value)) {
+		if (!$this->validateValue($value)) {
 			$this->validationError(
 				$fieldName,
 				_t(
@@ -66,15 +66,15 @@ 
 		);
 
 		// strip comments (lines beginning with "#")
-		$lines = array_filter($lines, function ($line) {
+		$lines = array_filter($lines, function($line) {
 			$line = trim($line);
 
 			return !empty($line) && $line[0] !== '#';
 		});
 
 		// validate each line
-		foreach($lines as $line) {
-			if(!$this->validateLine($line)) {
+		foreach ($lines as $line) {
+			if (!$this->validateLine($line)) {
 				return false;
 			}
 		}
@@ -95,8 +95,8 @@ 
 		$parts = explode(',', $line);
 		$parts = array_filter($parts);
 
-		foreach($parts as $part) {
-			if(!$this->validatePart($part)) {
+		foreach ($parts as $part) {
+			if (!$this->validatePart($part)) {
 				return false;
 			}
 		}
@@ -112,11 +112,11 @@ 
 	 * @return bool
 	 */
 	protected function validatePart($part) {
-		if(strpos($part, '=>') !== false) {
+		if (strpos($part, '=>') !== false) {
 			$subs = explode('=>', $part);
 			$subs = array_filter($subs);
 
-			foreach($subs as $sub) {
+			foreach ($subs as $sub) {
 				if (!$this->validateNoSpaces($sub)) {
 					return false;
 				}
@@ -138,7 +138,7 @@ 
 		$value = trim($value);
 
 		// does the value contain 1 or more whitespace characters?
-		if(preg_match('/\s+/', $value)) {
+		if (preg_match('/\s+/', $value)) {
 			return false;
 		}
 

code/extensions/SynonymsSiteConfig.php

Spacing +2 added lines, -2 removed lines

@@ -12,7 +12,7 @@ 
 	
 	public function updateCMSFields(FieldList $fields) {
 		// Don't show this field if you're not an admin
-		if(!Permission::check('ADMIN')) {
+		if (!Permission::check('ADMIN')) {
 			return;
 		}
 		
@@ -22,7 +22,7 @@ 
 			TextareaField::create('SearchSynonyms', _t('CwpConfig.SearchSynonyms', 'Search Synonyms'))
 				->setDescription(_t(
 					'CwpConfig.SearchSynonyms_Description',
-					'Enter as many comma separated synonyms as you wish, where '.
+					'Enter as many comma separated synonyms as you wish, where ' .
 					'each line represents a group of synonyms.<br /> ' .
 					'You will need to run <a rel="external" target="_blank" href="dev/tasks/Solr_Configure">Solr_Configure</a> if you make any changes'
 				))

code/search/CwpSearchResult.php

Spacing +7 added lines, -7 removed lines

@@ -54,11 +54,11 @@ 
 	 */
 	public function __construct($terms = '', ArrayData $results = null) {
 		$this->query = $terms;
-		if($results) {
+		if ($results) {
 			// Clean up the results.
 			$matches = $results->Matches;
-			foreach($matches as $result) {
-				if(!$result->canView()) {
+			foreach ($matches as $result) {
+				if (!$result->canView()) {
 					$matches->remove($result);
 				}
 			}
@@ -177,12 +177,12 @@ 
 	 * @return string|null
 	 */
 	protected function getLink($terms, $format = null) {
-		if(!$terms) {
+		if (!$terms) {
 			return null;
 		}
-		$link = 'search/SearchForm?Search='.rawurlencode($terms);
-		if($format) {
-			$link .= '&format='.rawurlencode($format);
+		$link = 'search/SearchForm?Search=' . rawurlencode($terms);
+		if ($format) {
+			$link .= '&format=' . rawurlencode($format);
 		}
 		return $link;
 	}

code/search/CwpSearchPage.php

Spacing +2 added lines, -2 removed lines

@@ -8,7 +8,7 @@ 
 	private static $hide_ancestor = 'CwpSearchPage';
 	
 	public function canViewStage($stage = 'Live', $member = null) {
-		if(Permission::checkMember($member, 'VIEW_DRAFT_CONTENT')) {
+		if (Permission::checkMember($member, 'VIEW_DRAFT_CONTENT')) {
 			return true;
 		}
 		
@@ -37,7 +37,7 @@ 
 	}
 	
 	public function __construct($dataRecord = null) {
-		if(!$dataRecord) {
+		if (!$dataRecord) {
 			$dataRecord = $this->generateSearchRecord();
 		}
 		parent::__construct($dataRecord);