NewsHolderController::atom() - Code Metrics - Inspection of "FIX Update syntax, get tests passing" - silverstripe/cwp - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#13)

by Robbie

created 2017-12-21 23:08 UTC

NewsHolderController::atom() A

↳ Parent: NewsHolderController

Complexity

Conditions	1
Paths	1

Size

Total Lines	9
Code Lines	6

Duplication

Lines	9
Ratio	100 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	1
eloc	6
nc	1
nop	0
dl	9
loc	9
rs	9.6666
c	1
b	0
f	0

<?php

namespace CWP\CWP\PageTypes;

use CWP\Core\Feed\CwpAtomFeed;
use SilverStripe\Control\RSS\RSSFeed;

class NewsHolderController extends DatedUpdateHolderController
{
    private static $allowed_actions = [

        'rss',
        'atom',
    ];

    public function rss()

    {
        $rss = RSSFeed::create(
            $this->Updates()->sort('Created DESC')->limit(20),
            $this->Link('rss'),
            $this->getSubscriptionTitle()
        );
        $rss->setTemplate('NewsHolder_rss');
        return $rss->outputToBrowser();
    }

    public function atom()

    {
        $atom = CwpAtomFeed::create(
            $this->Updates()->sort('Created DESC')->limit(20),
            $this->Link('atom'),
            $this->getSubscriptionTitle()
        );
        $atom->setTemplate('NewsHolder_atom');
        return $atom->outputToBrowser();
    }
}


1		<?php
2
3		namespace CWP\CWP\PageTypes;
4
5		use CWP\Core\Feed\CwpAtomFeed;
6		use SilverStripe\Control\RSS\RSSFeed;
7
8		class NewsHolderController extends DatedUpdateHolderController
9		{
10		private static $allowed_actions = [
		0 ignored issues – show introduced 2017-12-21 23:06 UTC by Report Bug Copy Issue Report The private property `$allowed_actions` is not used, and could be removed. Loading history...
11		'rss',
12		'atom',
13		];
14
15	View Code Duplication	public function rss()
		0 ignored issues – show Duplication introduced 2017-12-14 22:02 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
16		{
17		$rss = RSSFeed::create(
18		$this->Updates()->sort('Created DESC')->limit(20),
19		$this->Link('rss'),
20		$this->getSubscriptionTitle()
21		);
22		$rss->setTemplate('NewsHolder_rss');
23		return $rss->outputToBrowser();
24		}
25
26	View Code Duplication	public function atom()
		0 ignored issues – show Duplication introduced 2017-12-14 22:02 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
27		{
28		$atom = CwpAtomFeed::create(
29		$this->Updates()->sort('Created DESC')->limit(20),
30		$this->Link('atom'),
31		$this->getSubscriptionTitle()
32		);
33		$atom->setTemplate('NewsHolder_atom');
34		return $atom->outputToBrowser();
35		}
36		}
37

silverstripe / cwp

Pull Request — master (#13)

NewsHolderController::atom() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like