CWP\CWP\PageTypes\NewsHolderController

Complexity

Total Complexity

2

Size/Duplication

Total Lines	27
Duplicated Lines	70.37 %

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	atom()	9	9	1
A	rss()	9	9	1

<?php

namespace CWP\CWP\PageTypes;

use CWP\Core\Feed\CwpAtomFeed;
use SilverStripe\Control\RSS\RSSFeed;

class NewsHolderController extends DatedUpdateHolderController
{
    private static $allowed_actions = [

The private property $allowed_actions is not used, and could be removed.

        'rss',
        'atom',
    ];

    public function rss()

This method seems to be duplicated in your project.

    {
        $rss = RSSFeed::create(
            $this->Updates()->sort('Created DESC')->limit(20),
            $this->Link('rss'),
            $this->getSubscriptionTitle()
        );
        $rss->setTemplate('NewsHolder_rss');
        return $rss->outputToBrowser();
    }

    public function atom()

This method seems to be duplicated in your project.

    {
        $atom = CwpAtomFeed::create(
            $this->Updates()->sort('Created DESC')->limit(20),
            $this->Link('atom'),
            $this->getSubscriptionTitle()
        );
        $atom->setTemplate('NewsHolder_atom');
        return $atom->outputToBrowser();
    }
}