Passed
Pull Request — master (#29)
by Robbie
02:59
created
tests/Control/InitialisationMiddlewareTest.php 1 patch
Indentation   +101 added lines, -101 removed lines patch added patch discarded remove patch
@@ -10,105 +10,105 @@
 block discarded – undo
10 10
 
11 11
 class InitialisationMiddlewareTest extends FunctionalTest
12 12
 {
13
-    /**
14
-     * @var HTTPRequest
15
-     */
16
-    protected $request;
17
-
18
-    /**
19
-     * @var InitialisationMiddleware
20
-     */
21
-    protected $middleware;
22
-
23
-    protected function setUp()
24
-    {
25
-        parent::setUp();
26
-
27
-        $this->request = new HTTPRequest('GET', '/');
28
-        $this->middleware = new InitialisationMiddleware();
29
-
30
-        Environment::setEnv('SS_OUTBOUND_PROXY', '');
31
-        Environment::setEnv('SS_OUTBOUND_PROXY_PORT', '');
32
-        Environment::setEnv('NO_PROXY', '');
33
-    }
34
-
35
-    public function testDoNotConfigureProxyIfNoEnvironmentVarsAreSet()
36
-    {
37
-        $this->runMiddleware();
38
-
39
-        $this->assertEmpty(
40
-            Environment::getEnv('http_proxy'),
41
-            'Proxy information is not set if no outbound proxy is configured'
42
-        );
43
-    }
44
-
45
-    public function testConfigureEgressProxyWhenVarsAreSet()
46
-    {
47
-        Environment::setEnv('SS_OUTBOUND_PROXY', 'http://example.com');
48
-        Environment::setEnv('SS_OUTBOUND_PROXY_PORT', '8024');
49
-
50
-        $this->runMiddleware();
51
-
52
-        $this->assertEquals(
53
-            'http://example.com:8024',
54
-            Environment::getEnv('http_proxy'),
55
-            'Proxy is configured with proxy and port'
56
-        );
57
-    }
58
-
59
-    public function testDoNotConfigureProxyDomainExclusionsWhenNoneAreDefined()
60
-    {
61
-        Config::modify()->remove(InitialisationMiddleware::class, 'egress_proxy_exclude_domains');
62
-
63
-        $this->runMiddleware();
64
-
65
-        $this->assertSame(
66
-            '',
67
-            Environment::getEnv('NO_PROXY'),
68
-            'No domain exclusions are set when none are defined'
69
-        );
70
-    }
71
-
72
-    public function testConfigureEgressProxyDomainExclusions()
73
-    {
74
-        Config::modify()->set(
75
-            InitialisationMiddleware::class,
76
-            'egress_proxy_exclude_domains',
77
-            'example.com'
78
-        );
79
-
80
-        Environment::setEnv('NO_PROXY', 'foo.com,bar.com');
81
-
82
-        $this->runMiddleware();
83
-
84
-        $this->assertSame(
85
-            'foo.com,bar.com,example.com',
86
-            Environment::getEnv('NO_PROXY'),
87
-            'Domain exclusions are combined with existing values and configuration settings'
88
-        );
89
-    }
90
-
91
-    public function testSecurityHeadersAddedByDefault()
92
-    {
93
-        $response = $this->get('Security/login');
94
-        $this->assertArrayHasKey('x-xss-protection', $response->getHeaders());
95
-        $this->assertSame('1; mode=block', $response->getHeader('x-xss-protection'));
96
-    }
97
-
98
-    public function testXSSProtectionHeaderNotAdded()
99
-    {
100
-        Config::modify()->set(InitialisationMiddleware::class, 'xss_protection_enabled', false);
101
-        $response = $this->get('Security/login');
102
-        $this->assertArrayNotHasKey('x-xss-protection', $response->getHeaders());
103
-    }
104
-
105
-    /**
106
-     * Runs the middleware with a stubbed delegate
107
-     */
108
-    protected function runMiddleware()
109
-    {
110
-        $this->middleware->process($this->request, function () {
111
-            // no op
112
-        });
113
-    }
13
+	/**
14
+	 * @var HTTPRequest
15
+	 */
16
+	protected $request;
17
+
18
+	/**
19
+	 * @var InitialisationMiddleware
20
+	 */
21
+	protected $middleware;
22
+
23
+	protected function setUp()
24
+	{
25
+		parent::setUp();
26
+
27
+		$this->request = new HTTPRequest('GET', '/');
28
+		$this->middleware = new InitialisationMiddleware();
29
+
30
+		Environment::setEnv('SS_OUTBOUND_PROXY', '');
31
+		Environment::setEnv('SS_OUTBOUND_PROXY_PORT', '');
32
+		Environment::setEnv('NO_PROXY', '');
33
+	}
34
+
35
+	public function testDoNotConfigureProxyIfNoEnvironmentVarsAreSet()
36
+	{
37
+		$this->runMiddleware();
38
+
39
+		$this->assertEmpty(
40
+			Environment::getEnv('http_proxy'),
41
+			'Proxy information is not set if no outbound proxy is configured'
42
+		);
43
+	}
44
+
45
+	public function testConfigureEgressProxyWhenVarsAreSet()
46
+	{
47
+		Environment::setEnv('SS_OUTBOUND_PROXY', 'http://example.com');
48
+		Environment::setEnv('SS_OUTBOUND_PROXY_PORT', '8024');
49
+
50
+		$this->runMiddleware();
51
+
52
+		$this->assertEquals(
53
+			'http://example.com:8024',
54
+			Environment::getEnv('http_proxy'),
55
+			'Proxy is configured with proxy and port'
56
+		);
57
+	}
58
+
59
+	public function testDoNotConfigureProxyDomainExclusionsWhenNoneAreDefined()
60
+	{
61
+		Config::modify()->remove(InitialisationMiddleware::class, 'egress_proxy_exclude_domains');
62
+
63
+		$this->runMiddleware();
64
+
65
+		$this->assertSame(
66
+			'',
67
+			Environment::getEnv('NO_PROXY'),
68
+			'No domain exclusions are set when none are defined'
69
+		);
70
+	}
71
+
72
+	public function testConfigureEgressProxyDomainExclusions()
73
+	{
74
+		Config::modify()->set(
75
+			InitialisationMiddleware::class,
76
+			'egress_proxy_exclude_domains',
77
+			'example.com'
78
+		);
79
+
80
+		Environment::setEnv('NO_PROXY', 'foo.com,bar.com');
81
+
82
+		$this->runMiddleware();
83
+
84
+		$this->assertSame(
85
+			'foo.com,bar.com,example.com',
86
+			Environment::getEnv('NO_PROXY'),
87
+			'Domain exclusions are combined with existing values and configuration settings'
88
+		);
89
+	}
90
+
91
+	public function testSecurityHeadersAddedByDefault()
92
+	{
93
+		$response = $this->get('Security/login');
94
+		$this->assertArrayHasKey('x-xss-protection', $response->getHeaders());
95
+		$this->assertSame('1; mode=block', $response->getHeader('x-xss-protection'));
96
+	}
97
+
98
+	public function testXSSProtectionHeaderNotAdded()
99
+	{
100
+		Config::modify()->set(InitialisationMiddleware::class, 'xss_protection_enabled', false);
101
+		$response = $this->get('Security/login');
102
+		$this->assertArrayNotHasKey('x-xss-protection', $response->getHeaders());
103
+	}
104
+
105
+	/**
106
+	 * Runs the middleware with a stubbed delegate
107
+	 */
108
+	protected function runMiddleware()
109
+	{
110
+		$this->middleware->process($this->request, function () {
111
+			// no op
112
+		});
113
+	}
114 114
 }
Please login to merge, or discard this patch.