Inspection of "Merge branch '2.3'" - silverstripe/cwp-agencyextensions - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 6c4e69...26239b )

by Robbie

created 2019-08-14 22:20 UTC

Status

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -26,7 +26,7 @@
 block discarded – undo
 
     public function getSourceValues()
     {
-        return array_merge([''], array_map(function ($color) {
+        return array_merge([''], array_map(function($color) {
             return $color['CSSClass'];
         }, $this->getSource()));
     }

Please login to merge, or discard this patch.

src/Extensions/CWPSiteConfigExtension.php 2 patches

Indentation +79 added lines, -79 removed lines patch added patch discarded remove patch

@@ -425,85 +425,85 @@
 block discarded – undo
                     ),
                     $fonts
                 ),
-                 ColorPickerField::create(
-                     'HeaderBackground',
-                     _t(
-                         __CLASS__ . '.HeaderBackground',
-                         'Header background'
-                     ),
-                     $this->getThemeOptionsExcluding([
-                         'default-accent',
-                     ])
-                 ),
-                 ColorPickerField::create(
-                     'NavigationBarBackground',
-                     _t(
-                         __CLASS__ . '.NavigationBarBackground',
-                         'Navigation bar background'
-                     ),
-                     $this->getThemeOptionsExcluding([
-                         'default-accent',
-                     ])
-                 ),
-                 ColorPickerField::create(
-                     'CarouselBackground',
-                     _t(
-                         __CLASS__ . '.CarouselBackground',
-                         'Carousel background'
-                     ),
-                     $this->getThemeOptionsExcluding([
-                         'default-accent',
-                     ])
-                 )->setDescription(
-                     _t(
-                         __CLASS__ . '.CarouselBackgroundDescription',
-                         'The background colour of the carousel when there is no image set.'
-                     )
-                 ),
-                 ColorPickerField::create(
-                     'FooterBackground',
-                     _t(
-                         __CLASS__ . '.FooterBackground',
-                         'Footer background'
-                     ),
-                     $this->getThemeOptionsExcluding([
-                         'light-grey',
-                         'white',
-                         'default-accent',
-                     ])
-                 ),
-                 ColorPickerField::create(
-                     'AccentColor',
-                     _t(
-                         __CLASS__ . '.AccentColor',
-                         'Accent colour'
-                     ),
-                     $this->getThemeOptionsExcluding([
-                         'light-grey',
-                         'white',
-                         'default-background',
-                     ])
-                 )->setDescription(
-                     _t(
-                         __CLASS__ . '.AccentColorDescription',
-                         'Affects colour of buttons, current navigation items, etc. '.
-                         'Please ensure sufficient contrast with background colours.'
-                     )
-                 ),
-                 ColorPickerField::create(
-                     'TextLinkColor',
-                     _t(
-                         __CLASS__ . '.TextLinkColor',
-                         'Text link colour'
-                     ),
-                     $this->getThemeOptionsExcluding([
-                         'black',
-                         'light-grey',
-                         'dark-grey',
-                         'white',
-                         'default-background',
-                     ])
-                 ),
+                    ColorPickerField::create(
+                        'HeaderBackground',
+                        _t(
+                            __CLASS__ . '.HeaderBackground',
+                            'Header background'
+                        ),
+                        $this->getThemeOptionsExcluding([
+                            'default-accent',
+                        ])
+                    ),
+                    ColorPickerField::create(
+                        'NavigationBarBackground',
+                        _t(
+                            __CLASS__ . '.NavigationBarBackground',
+                            'Navigation bar background'
+                        ),
+                        $this->getThemeOptionsExcluding([
+                            'default-accent',
+                        ])
+                    ),
+                    ColorPickerField::create(
+                        'CarouselBackground',
+                        _t(
+                            __CLASS__ . '.CarouselBackground',
+                            'Carousel background'
+                        ),
+                        $this->getThemeOptionsExcluding([
+                            'default-accent',
+                        ])
+                    )->setDescription(
+                        _t(
+                            __CLASS__ . '.CarouselBackgroundDescription',
+                            'The background colour of the carousel when there is no image set.'
+                        )
+                    ),
+                    ColorPickerField::create(
+                        'FooterBackground',
+                        _t(
+                            __CLASS__ . '.FooterBackground',
+                            'Footer background'
+                        ),
+                        $this->getThemeOptionsExcluding([
+                            'light-grey',
+                            'white',
+                            'default-accent',
+                        ])
+                    ),
+                    ColorPickerField::create(
+                        'AccentColor',
+                        _t(
+                            __CLASS__ . '.AccentColor',
+                            'Accent colour'
+                        ),
+                        $this->getThemeOptionsExcluding([
+                            'light-grey',
+                            'white',
+                            'default-background',
+                        ])
+                    )->setDescription(
+                        _t(
+                            __CLASS__ . '.AccentColorDescription',
+                            'Affects colour of buttons, current navigation items, etc. '.
+                            'Please ensure sufficient contrast with background colours.'
+                        )
+                    ),
+                    ColorPickerField::create(
+                        'TextLinkColor',
+                        _t(
+                            __CLASS__ . '.TextLinkColor',
+                            'Text link colour'
+                        ),
+                        $this->getThemeOptionsExcluding([
+                            'black',
+                            'light-grey',
+                            'dark-grey',
+                            'white',
+                            'default-background',
+                        ])
+                    ),
             ]
         );
 

Please login to merge, or discard this patch.

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -486,7 +486,7 @@
 block discarded – undo
                  )->setDescription(
                      _t(
                          __CLASS__ . '.AccentColorDescription',
-                         'Affects colour of buttons, current navigation items, etc. '.
+                         'Affects colour of buttons, current navigation items, etc. ' .
                          'Please ensure sufficient contrast with background colours.'
                      )
                  ),

Please login to merge, or discard this patch.

		@@ -26,7 +26,7 @@
		block discarded – undo
26	26
27	27	public function getSourceValues()
28	28	{
29		- return array_merge([''], array_map(function ($color) {
	29	+ return array_merge([''], array_map(function($color) {
30	30	return $color['CSSClass'];
31	31	}, $this->getSource()));
32	32	}

		@@ -486,7 +486,7 @@
		block discarded – undo
486	486	)->setDescription(
487	487	_t(
488	488	__CLASS__ . '.AccentColorDescription',
489		- 'Affects colour of buttons, current navigation items, etc. '.
	489	+ 'Affects colour of buttons, current navigation items, etc. ' .
490	490	'Please ensure sufficient contrast with background colours.'
491	491	)
492	492	),

		@@ -425,85 +425,85 @@
		block discarded – undo
425	425	),
426	426	$fonts
427	427	),
428		- ColorPickerField::create(
429		- 'HeaderBackground',
430		- _t(
431		- __CLASS__ . '.HeaderBackground',
432		- 'Header background'
433		- ),
434		- $this->getThemeOptionsExcluding([
435		- 'default-accent',
436		- ])
437		- ),
438		- ColorPickerField::create(
439		- 'NavigationBarBackground',
440		- _t(
441		- __CLASS__ . '.NavigationBarBackground',
442		- 'Navigation bar background'
443		- ),
444		- $this->getThemeOptionsExcluding([
445		- 'default-accent',
446		- ])
447		- ),
448		- ColorPickerField::create(
449		- 'CarouselBackground',
450		- _t(
451		- __CLASS__ . '.CarouselBackground',
452		- 'Carousel background'
453		- ),
454		- $this->getThemeOptionsExcluding([
455		- 'default-accent',
456		- ])
457		- )->setDescription(
458		- _t(
459		- __CLASS__ . '.CarouselBackgroundDescription',
460		- 'The background colour of the carousel when there is no image set.'
461		- )
462		- ),
463		- ColorPickerField::create(
464		- 'FooterBackground',
465		- _t(
466		- __CLASS__ . '.FooterBackground',
467		- 'Footer background'
468		- ),
469		- $this->getThemeOptionsExcluding([
470		- 'light-grey',
471		- 'white',
472		- 'default-accent',
473		- ])
474		- ),
475		- ColorPickerField::create(
476		- 'AccentColor',
477		- _t(
478		- __CLASS__ . '.AccentColor',
479		- 'Accent colour'
480		- ),
481		- $this->getThemeOptionsExcluding([
482		- 'light-grey',
483		- 'white',
484		- 'default-background',
485		- ])
486		- )->setDescription(
487		- _t(
488		- __CLASS__ . '.AccentColorDescription',
489		- 'Affects colour of buttons, current navigation items, etc. '.
490		- 'Please ensure sufficient contrast with background colours.'
491		- )
492		- ),
493		- ColorPickerField::create(
494		- 'TextLinkColor',
495		- _t(
496		- __CLASS__ . '.TextLinkColor',
497		- 'Text link colour'
498		- ),
499		- $this->getThemeOptionsExcluding([
500		- 'black',
501		- 'light-grey',
502		- 'dark-grey',
503		- 'white',
504		- 'default-background',
505		- ])
506		- ),
	428	+ ColorPickerField::create(
	429	+ 'HeaderBackground',
	430	+ _t(
	431	+ __CLASS__ . '.HeaderBackground',
	432	+ 'Header background'
	433	+ ),
	434	+ $this->getThemeOptionsExcluding([
	435	+ 'default-accent',
	436	+ ])
	437	+ ),
	438	+ ColorPickerField::create(
	439	+ 'NavigationBarBackground',
	440	+ _t(
	441	+ __CLASS__ . '.NavigationBarBackground',
	442	+ 'Navigation bar background'
	443	+ ),
	444	+ $this->getThemeOptionsExcluding([
	445	+ 'default-accent',
	446	+ ])
	447	+ ),
	448	+ ColorPickerField::create(
	449	+ 'CarouselBackground',
	450	+ _t(
	451	+ __CLASS__ . '.CarouselBackground',
	452	+ 'Carousel background'
	453	+ ),
	454	+ $this->getThemeOptionsExcluding([
	455	+ 'default-accent',
	456	+ ])
	457	+ )->setDescription(
	458	+ _t(
	459	+ __CLASS__ . '.CarouselBackgroundDescription',
	460	+ 'The background colour of the carousel when there is no image set.'
	461	+ )
	462	+ ),
	463	+ ColorPickerField::create(
	464	+ 'FooterBackground',
	465	+ _t(
	466	+ __CLASS__ . '.FooterBackground',
	467	+ 'Footer background'
	468	+ ),
	469	+ $this->getThemeOptionsExcluding([
	470	+ 'light-grey',
	471	+ 'white',
	472	+ 'default-accent',
	473	+ ])
	474	+ ),
	475	+ ColorPickerField::create(
	476	+ 'AccentColor',
	477	+ _t(
	478	+ __CLASS__ . '.AccentColor',
	479	+ 'Accent colour'
	480	+ ),
	481	+ $this->getThemeOptionsExcluding([
	482	+ 'light-grey',
	483	+ 'white',
	484	+ 'default-background',
	485	+ ])
	486	+ )->setDescription(
	487	+ _t(
	488	+ __CLASS__ . '.AccentColorDescription',
	489	+ 'Affects colour of buttons, current navigation items, etc. '.
	490	+ 'Please ensure sufficient contrast with background colours.'
	491	+ )
	492	+ ),
	493	+ ColorPickerField::create(
	494	+ 'TextLinkColor',
	495	+ _t(
	496	+ __CLASS__ . '.TextLinkColor',
	497	+ 'Text link colour'
	498	+ ),
	499	+ $this->getThemeOptionsExcluding([
	500	+ 'black',
	501	+ 'light-grey',
	502	+ 'dark-grey',
	503	+ 'white',
	504	+ 'default-background',
	505	+ ])
	506	+ ),
507	507	]
508	508	);
509	509

silverstripe / cwp-agencyextensions

Push — master ( 6c4e69...26239b )

Status

Category

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Indentation +79 added lines, -79 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch