silverstripe / addons.silverstripe.org

mysite/code/services/PackagistService.php

Unused Use Statements -1 removed lines

@@ -3,7 +3,6 @@
 use Composer\Factory;
 use Composer\IO\NullIO;
 use Composer\Package\Loader\ArrayLoader;
-use Composer\Repository\ComposerRepository;
 use Guzzle\Http\Client;
 
 /**

mysite/code/dataobjects/SilverStripeVersion.php

Doc Comments +1 added lines, -1 removed lines

@@ -20,7 +20,7 @@
 	);
 
 	/**
-	 * @return Composer\Package\LinkConstraint\LinkConstraintInterface
+	 * @return MultiConstraint
 	 */
 	public function getConstraint() {
 		$next = $this->Major . '.' . ($this->Minor + 1);

mysite/code/services/AddonUpdater.php

Unused Use Statements -2 removed lines

@@ -1,9 +1,7 @@
 <?php
 
-use Composer\Package\AliasPackage;
 use Composer\Package\CompletePackage;
 use Composer\Semver\Constraint\Constraint;
-use Guzzle\Http\Exception\ClientErrorResponseException;
 use SilverStripe\Elastica\ElasticaService;
 use Packagist\Api\Result\Package;
 use Composer\Package\Version\VersionParser;

mysite/code/services/AddonBuilder.php

Doc Comments +6 added lines

@@ -66,6 +66,9 @@ 
         $addon->write();
     }
 
+    /**
+     * @param string $path
+     */
     protected function download(PackageInterface $package, $path) {
         $this->packagist
             ->getComposer()
@@ -180,6 +183,9 @@ 
         return (strpos($addon->Repository, 'github.com') !== false);
     }
 
+    /**
+     * @param string $path
+     */
     private function buildScreenshots(Addon $addon, PackageInterface $package, $path) {
         $extra = $package->getExtra();
         $screenshots = array();

mysite/code/dataobjects/Addon.php

Doc Comments +2 added lines, -2 removed lines

@@ -114,7 +114,7 @@ 
     /**
      * Remove the effect of code of conduct Helpful Robot measure that we currently don't include in the Supported module definition
      *
-     * @return integer Adjusted Helpful Robot score
+     * @return double Adjusted Helpful Robot score
      */
     public function getAdjustedHelpfulRobotScore()
     {
@@ -202,7 +202,7 @@ 
      * Calculate the total amount of downloads per day
      * Based on the total amount of downloads divided by the age of the addon
      *
-     * @return float
+     * @return integer
      */
     public function getRelativePopularity()
     {