silverstripe-australia / silverstripe-queuedjobs

src/Controllers/QueuedJobsAdmin.php

Doc Comments +1 added lines, -1 removed lines

@@ -145,7 +145,7 @@
     /**
      * @param  array $data
      * @param  Form $form
-     * @return HTTPResponse
+     * @return \SilverStripe\Control\HTTPResponse
      */
     public function createjob($data, Form $form)
     {

src/DataObjects/QueuedJobDescriptor.php

Doc Comments +1 added lines, -1 removed lines

@@ -258,7 +258,7 @@
     }
 
     /**
-     * @return FieldList
+     * @return \SilverStripe\Forms\FieldList
      */
     public function getCMSFields()
     {

src/Forms/GridFieldQueuedJobExecute.php

Doc Comments +3 added lines, -3 removed lines

@@ -104,7 +104,7 @@ 
      * Which columns are handled by this component
      *
      * @param GridField $gridField
-     * @return array
+     * @return string[]
      */
     public function getColumnsHandled($gridField)
     {
@@ -115,7 +115,7 @@ 
      * Which GridField actions are this component handling
      *
      * @param GridField $gridField
-     * @return array
+     * @return string[]
      */
     public function getActions($gridField)
     {
@@ -126,7 +126,7 @@ 
      * @param GridField $gridField
      * @param DataObject $record
      * @param string $columnName
-     * @return string|void - the HTML for the column
+     * @return null|\SilverStripe\ORM\FieldType\DBHTMLText - the HTML for the column
      */
     public function getColumnContent($gridField, $record, $columnName)
     {

src/Jobs/CleanupJob.php

Doc Comments +1 added lines, -1 removed lines

@@ -58,7 +58,7 @@
 
     /**
      * Required because we aren't extending object
-     * @return Config_ForClass
+     * @return \SilverStripe\Core\Config\Config_ForClass
      */
     public function config()
     {

src/Services/QueuedJobService.php

Doc Comments +7 added lines, -4 removed lines

@@ -183,7 +183,7 @@ 
     /**
      * Start a job (or however the queue handler determines it should be started)
      *
-     * @param JobDescriptor $jobDescriptor
+     * @param QueuedJobDescriptor $jobDescriptor
      * @param date $startAfter
      */
     public function startJob($jobDescriptor, $startAfter = null)
@@ -200,7 +200,7 @@ 
      * Copies data from a job into a descriptor for persisting
      *
      * @param QueuedJob $job
-     * @param JobDescriptor $jobDescriptor
+     * @param DataObject $jobDescriptor
      */
     protected function copyJobToDescriptor($job, $jobDescriptor)
     {
@@ -355,7 +355,7 @@ 
      * Attempt to restart a stalled job
      *
      * @param QueuedJobDescriptor $stalledJob
-     * @return bool True if the job was successfully restarted
+     * @return boolean|null True if the job was successfully restarted
      */
     protected function restartStalledJob($stalledJob)
     {
@@ -812,6 +812,9 @@ 
         }
     }
 
+    /**
+     * @param double $size
+     */
     protected function humanReadable($size)
     {
         $filesizename = array(" Bytes", " KB", " MB", " GB", " TB", " PB", " EB", " ZB", " YB");
@@ -827,7 +830,7 @@ 
      * @param int $includeUpUntil
      *          The number of seconds to include jobs that have just finished, allowing a job list to be built that
      *          includes recently finished jobs
-     * @return QueuedJobDescriptor
+     * @return DataList
      */
     public function getJobList($type = null, $includeUpUntil = 0)
     {

src/Tasks/Engines/DoormanRunner.php

Doc Comments +2 added lines, -2 removed lines

@@ -31,7 +31,7 @@ 
     }
 
     /**
-     * @return array List of rules
+     * @return string List of rules
      */
     public function getDefaultRules()
     {
@@ -79,7 +79,7 @@ 
 
     /**
      * @param string $queue
-     * @return null|QueuedJobDescriptor
+     * @return \SilverStripe\ORM\DataObject|null
      */
     protected function getNextJobDescriptorWithoutMutex($queue)
     {

Unused Use Statements -1 removed lines

@@ -2,7 +2,6 @@
 
 namespace SilverStripe\QueuedJobs\Tasks\Engines;
 
-use AsyncPHP\Doorman\Rule;
 use SilverStripe\ORM\FieldType\DBDatetime;
 use SilverStripe\QueuedJobs\DataObjects\QueuedJobDescriptor;
 use SilverStripe\QueuedJobs\Jobs\DoormanQueuedJobTask;

src/Tasks/ProcessJobQueueChildTask.php

Unused Use Statements -2 removed lines

@@ -2,8 +2,6 @@
 
 namespace SilverStripe\QueuedJobs\Tasks;
 
-use AsyncPHP\Doorman\Handler;
-use AsyncPHP\Doorman\Task;
 use SilverStripe\Dev\BuildTask;
 
 class ProcessJobQueueChildTask extends BuildTask

src/Extensions/ScheduledExecutionExtension.php

Doc Comments +1 added lines, -1 removed lines

@@ -48,7 +48,7 @@
     );
 
     /**
-     * @param FieldSet $fields
+     * @param FieldList $fields
      */
     public function updateCMSFields(FieldList $fields)
     {

tests/ScheduledExecutionTest.php

Unused Use Statements -1 removed lines

@@ -1,7 +1,6 @@
 <?php
 
 use SilverStripe\Dev\SapphireTest;
-use SilverStripe\Dev\TestOnly;
 use SilverStripe\ORM\DataObject;
 
 /**