Issues in WorkflowInstanceTest.php (master) - Issues in master - silverstripe-australia/advancedworkflow - Measure and Improve Code Quality continuously with Scrutinizer

Issues (621)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

tests/WorkflowInstanceTest.php (16 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * Tests for the workflow engine.
 *
 * @author     [email protected]
 * @license    BSD License (http://silverstripe.org/bsd-license/)
 * @package    advancedworkflow
 * @subpackage tests
 */
class WorkflowInstanceTest extends SapphireTest {
namespace YourVendor;

class YourClass { }
	
	/**
	 *
	 * @var string
	 */
	public static $fixture_file = 'advancedworkflow/tests/useractioninstancehistory.yml';
	
	/**
	 * 
	 * @var Member
	 */
	protected $currentMember;
	
	/**
	 * 
	 */
	public function setUp() {
		parent::setUp();
		$this->currentMember = $this->objFromFixture('Member', 'ApproverMember01');
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}
	}

	/**
	 * Tests WorkflowInstance#getMostRecentActionForUser()
	 */
	public function testGetMostRecentActionForUser() {
	
		// Single, AssignUsersToWorkflowAction in "History"
		$history01 = $this->objFromFixture('WorkflowInstance', 'WorkflowInstance01');
		$mostRecentActionForUser01 = $history01->getMostRecentActionForUser($this->currentMember);
		$this->assertInstanceOf('WorkflowActionInstance', $mostRecentActionForUser01, 'Asserts the correct ClassName is retured #1');

		$this->assertEquals('Assign', $mostRecentActionForUser01->BaseAction()->Title, 'Asserts the correct BaseAction is retured #1');

		
		// No AssignUsersToWorkflowAction found with Member's related Group in "History"
		$history02 = $this->objFromFixture('WorkflowInstance', 'WorkflowInstance02');
		$mostRecentActionForUser02 = $history02->getMostRecentActionForUser($this->currentMember);
		$this->assertFalse($mostRecentActionForUser02, 'Asserts false is returned because no WorkflowActionInstance was found');

		
		// Multiple AssignUsersToWorkflowAction in "History", only one with Group relations
		$history03 = $this->objFromFixture('WorkflowInstance', 'WorkflowInstance03');
		$mostRecentActionForUser03 = $history03->getMostRecentActionForUser($this->currentMember);
		$this->assertInstanceOf('WorkflowActionInstance', $mostRecentActionForUser03, 'Asserts the correct ClassName is retured #2');

		$this->assertEquals('Assign', $mostRecentActionForUser03->BaseAction()->Title, 'Asserts the correct BaseAction is retured #2');

		
		// Multiple AssignUsersToWorkflowAction in "History", both with Group relations
		$history04 = $this->objFromFixture('WorkflowInstance', 'WorkflowInstance04');
		$mostRecentActionForUser04 = $history04->getMostRecentActionForUser($this->currentMember);
		$this->assertInstanceOf('WorkflowActionInstance', $mostRecentActionForUser04, 'Asserts the correct ClassName is retured #3');

		$this->assertEquals('Assigned Again', $mostRecentActionForUser04->BaseAction()->Title, 'Asserts the correct BaseAction is retured #3');

		
		// Multiple AssignUsersToWorkflowAction in "History", one with Group relations
		$history05 = $this->objFromFixture('WorkflowInstance', 'WorkflowInstance05');
		$mostRecentActionForUser05 = $history05->getMostRecentActionForUser($this->currentMember);
		$this->assertInstanceOf('WorkflowActionInstance', $mostRecentActionForUser05, 'Asserts the correct ClassName is retured #4');

		$this->assertEquals('Assigned Me', $mostRecentActionForUser05->BaseAction()->Title, 'Asserts the correct BaseAction is retured #4');

	}
	
	/**
	 * Tests WorkflowInstance#canView()
	 */
	public function testCanView() {
		// Single, AssignUsersToWorkflowAction in "History"
		$history01 = $this->objFromFixture('WorkflowInstance', 'WorkflowInstance01');
		$this->assertTrue($history01->canView($this->currentMember));

		
		// No AssignUsersToWorkflowAction found with Member's related Group in "History"
		$history02 = $this->objFromFixture('WorkflowInstance', 'WorkflowInstance02');
		$this->assertFalse($history02->canView($this->currentMember));

		
		// Multiple AssignUsersToWorkflowAction in "History", only one with Group relations
		$history03 = $this->objFromFixture('WorkflowInstance', 'WorkflowInstance03');
		$this->assertTrue($history03->canView($this->currentMember));	

		
		// Multiple AssignUsersToWorkflowAction in "History", both with Group relations
		$history04 = $this->objFromFixture('WorkflowInstance', 'WorkflowInstance04');
		$this->assertTrue($history04->canView($this->currentMember));	

		
		// Multiple AssignUsersToWorkflowAction in "History"
		$history05 = $this->objFromFixture('WorkflowInstance', 'WorkflowInstance05');
		$this->assertTrue($history05->canView($this->currentMember));	

	}

	public function testValidTransitions() {
		$instance = $this->objFromFixture('WorkflowInstance', 'WorkflowInstance06');
		$transition1 = $this->objFromFixture('WorkflowTransition', 'Transition05');
		$transition2 = $this->objFromFixture('WorkflowTransition', 'Transition06');
		$member1 = $this->objFromFixture('Member', 'Transition05Member');
		$member2 = $this->objFromFixture('Member', 'Transition06Member');

		// Given logged in as admin, check that there are two actions
		$this->logInWithPermission('ADMIN');
		$transitions = $instance->validTransitions()->column('ID');
		$this->assertContains($transition1->ID, $transitions);
		$this->assertContains($transition2->ID, $transitions);

		// Logged in as a member with permission on one transition, check that only this one is present
		$member1->logIn();
		$transitions = $instance->validTransitions()->column('ID');
		$this->assertContains($transition1->ID, $transitions);
		$this->assertNotContains($transition2->ID, $transitions);

		// Logged in as a member with permissions via group
		$member2->logIn();
		$transitions = $instance->validTransitions()->column('ID');
		$this->assertNotContains($transition1->ID, $transitions);
		$this->assertContains($transition2->ID, $transitions);
	}

}

1			<?php
2			/**
3			* Tests for the workflow engine.
4			*
5			* @author [email protected]
6			* @license BSD License (http://silverstripe.org/bsd-license/)
7			* @package advancedworkflow
8			* @subpackage tests
9			*/
10			class WorkflowInstanceTest extends SapphireTest {
			0 ignored issues – show Coding Style Compatibility introduced 2015-11-21 06:31 UTC by Report Bug Copy Issue Report Show Similar Issues like this PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
11
12			/**
13			*
14			* @var string
15			*/
16			public static $fixture_file = 'advancedworkflow/tests/useractioninstancehistory.yml';
17
18			/**
19			*
20			* @var Member
21			*/
22			protected $currentMember;
23
24			/**
25			*
26			*/
27			public function setUp() {
28			parent::setUp();
29			$this->currentMember = $this->objFromFixture('Member', 'ApproverMember01');
			0 ignored issues – show Documentation Bug introduced 2015-11-21 06:31 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$this->objFromFixture('M...r', 'ApproverMember01')` can also be of type `object<DataObject>`. However, the property `$currentMember` is declared as type `object<Member>`. Maybe add an additional type check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly. For example, imagine you have a variable `$accountId` that can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to the `id` property of an instance of the `Account` class. This class holds a proper account, so the id value must no longer be false. Either this assignment is in error or a type check should be added for that assignment. class Id { public $id; public function __construct($id) { $this->id = $id; } } class Account { /** @var Id $id */ public $id; } $account_id = false; if (starsAreRight()) { $account_id = new Id(42); } $account = new Account(); if ($account instanceof Id) { $account->id = $account_id; } Loading history...
30			}
31
32			/**
33			* Tests WorkflowInstance#getMostRecentActionForUser()
34			*/
35			public function testGetMostRecentActionForUser() {
36
37			// Single, AssignUsersToWorkflowAction in "History"
38			$history01 = $this->objFromFixture('WorkflowInstance', 'WorkflowInstance01');
39			$mostRecentActionForUser01 = $history01->getMostRecentActionForUser($this->currentMember);
40			$this->assertInstanceOf('WorkflowActionInstance', $mostRecentActionForUser01, 'Asserts the correct ClassName is retured #1');
			0 ignored issues – show Bug introduced 2015-11-21 06:31 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `assertInstanceOf()` does not seem to exist on `object<WorkflowInstanceTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
41			$this->assertEquals('Assign', $mostRecentActionForUser01->BaseAction()->Title, 'Asserts the correct BaseAction is retured #1');
			0 ignored issues – show Bug introduced 2015-11-21 06:31 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `assertEquals()` does not seem to exist on `object<WorkflowInstanceTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
42
43			// No AssignUsersToWorkflowAction found with Member's related Group in "History"
44			$history02 = $this->objFromFixture('WorkflowInstance', 'WorkflowInstance02');
45			$mostRecentActionForUser02 = $history02->getMostRecentActionForUser($this->currentMember);
46			$this->assertFalse($mostRecentActionForUser02, 'Asserts false is returned because no WorkflowActionInstance was found');
			0 ignored issues – show Bug introduced 2015-11-21 06:31 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `assertFalse()` does not seem to exist on `object<WorkflowInstanceTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
47
48			// Multiple AssignUsersToWorkflowAction in "History", only one with Group relations
49			$history03 = $this->objFromFixture('WorkflowInstance', 'WorkflowInstance03');
50			$mostRecentActionForUser03 = $history03->getMostRecentActionForUser($this->currentMember);
51			$this->assertInstanceOf('WorkflowActionInstance', $mostRecentActionForUser03, 'Asserts the correct ClassName is retured #2');
			0 ignored issues – show Bug introduced 2015-11-21 06:31 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `assertInstanceOf()` does not seem to exist on `object<WorkflowInstanceTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
52			$this->assertEquals('Assign', $mostRecentActionForUser03->BaseAction()->Title, 'Asserts the correct BaseAction is retured #2');
			0 ignored issues – show Bug introduced 2015-11-21 06:31 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `assertEquals()` does not seem to exist on `object<WorkflowInstanceTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
53
54			// Multiple AssignUsersToWorkflowAction in "History", both with Group relations
55			$history04 = $this->objFromFixture('WorkflowInstance', 'WorkflowInstance04');
56			$mostRecentActionForUser04 = $history04->getMostRecentActionForUser($this->currentMember);
57			$this->assertInstanceOf('WorkflowActionInstance', $mostRecentActionForUser04, 'Asserts the correct ClassName is retured #3');
			0 ignored issues – show Bug introduced 2015-11-21 06:31 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `assertInstanceOf()` does not seem to exist on `object<WorkflowInstanceTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
58			$this->assertEquals('Assigned Again', $mostRecentActionForUser04->BaseAction()->Title, 'Asserts the correct BaseAction is retured #3');
			0 ignored issues – show Bug introduced 2015-11-21 06:31 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `assertEquals()` does not seem to exist on `object<WorkflowInstanceTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
59
60			// Multiple AssignUsersToWorkflowAction in "History", one with Group relations
61			$history05 = $this->objFromFixture('WorkflowInstance', 'WorkflowInstance05');
62			$mostRecentActionForUser05 = $history05->getMostRecentActionForUser($this->currentMember);
63			$this->assertInstanceOf('WorkflowActionInstance', $mostRecentActionForUser05, 'Asserts the correct ClassName is retured #4');
			0 ignored issues – show Bug introduced 2015-11-21 06:31 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `assertInstanceOf()` does not seem to exist on `object<WorkflowInstanceTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
64			$this->assertEquals('Assigned Me', $mostRecentActionForUser05->BaseAction()->Title, 'Asserts the correct BaseAction is retured #4');
			0 ignored issues – show Bug introduced 2015-11-21 06:31 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `assertEquals()` does not seem to exist on `object<WorkflowInstanceTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
65			}
66
67			/**
68			* Tests WorkflowInstance#canView()
69			*/
70			public function testCanView() {
71			// Single, AssignUsersToWorkflowAction in "History"
72			$history01 = $this->objFromFixture('WorkflowInstance', 'WorkflowInstance01');
73			$this->assertTrue($history01->canView($this->currentMember));
			0 ignored issues – show Bug introduced 2015-11-21 06:31 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `assertTrue()` does not seem to exist on `object<WorkflowInstanceTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
74
75			// No AssignUsersToWorkflowAction found with Member's related Group in "History"
76			$history02 = $this->objFromFixture('WorkflowInstance', 'WorkflowInstance02');
77			$this->assertFalse($history02->canView($this->currentMember));
			0 ignored issues – show Bug introduced 2015-11-21 06:31 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `assertFalse()` does not seem to exist on `object<WorkflowInstanceTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
78
79			// Multiple AssignUsersToWorkflowAction in "History", only one with Group relations
80			$history03 = $this->objFromFixture('WorkflowInstance', 'WorkflowInstance03');
81			$this->assertTrue($history03->canView($this->currentMember));
			0 ignored issues – show Bug introduced 2015-11-21 06:31 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `assertTrue()` does not seem to exist on `object<WorkflowInstanceTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
82
83			// Multiple AssignUsersToWorkflowAction in "History", both with Group relations
84			$history04 = $this->objFromFixture('WorkflowInstance', 'WorkflowInstance04');
85			$this->assertTrue($history04->canView($this->currentMember));
			0 ignored issues – show Bug introduced 2015-11-21 06:31 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `assertTrue()` does not seem to exist on `object<WorkflowInstanceTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
86
87			// Multiple AssignUsersToWorkflowAction in "History"
88			$history05 = $this->objFromFixture('WorkflowInstance', 'WorkflowInstance05');
89			$this->assertTrue($history05->canView($this->currentMember));
			0 ignored issues – show Bug introduced 2015-11-21 06:31 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `assertTrue()` does not seem to exist on `object<WorkflowInstanceTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
90			}
91
92			public function testValidTransitions() {
93			$instance = $this->objFromFixture('WorkflowInstance', 'WorkflowInstance06');
94			$transition1 = $this->objFromFixture('WorkflowTransition', 'Transition05');
95			$transition2 = $this->objFromFixture('WorkflowTransition', 'Transition06');
96			$member1 = $this->objFromFixture('Member', 'Transition05Member');
97			$member2 = $this->objFromFixture('Member', 'Transition06Member');
98
99			// Given logged in as admin, check that there are two actions
100			$this->logInWithPermission('ADMIN');
101			$transitions = $instance->validTransitions()->column('ID');
102			$this->assertContains($transition1->ID, $transitions);
103			$this->assertContains($transition2->ID, $transitions);
104
105			// Logged in as a member with permission on one transition, check that only this one is present
106			$member1->logIn();
107			$transitions = $instance->validTransitions()->column('ID');
108			$this->assertContains($transition1->ID, $transitions);
109			$this->assertNotContains($transition2->ID, $transitions);
110
111			// Logged in as a member with permissions via group
112			$member2->logIn();
113			$transitions = $instance->validTransitions()->column('ID');
114			$this->assertNotContains($transition1->ID, $transitions);
115			$this->assertContains($transition2->ID, $transitions);
116			}
117
118			}

silverstripe-australia / advancedworkflow

Issues (621)

Security Analysis not enabled

tests/WorkflowInstanceTest.php (16 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like