WorkflowInstanceTest

Complexity

Total Complexity

4

Size/Duplication

Total Lines	109
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

4 Methods

Rating	Name	Duplication	Size	Complexity
A	setUp()	0	4	1
B	testGetMostRecentActionForUser()	0	31	1
A	testCanView()	0	21	1
B	testValidTransitions()	0	25	1

<?php
/**
 * Tests for the workflow engine.
 *
 * @author     marcus@silverstripe.com.au
 * @license    BSD License (http://silverstripe.org/bsd-license/)
 * @package    advancedworkflow
 * @subpackage tests
 */
class WorkflowInstanceTest extends SapphireTest {

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

	
	/**
	 *
	 * @var string
	 */
	public static $fixture_file = 'advancedworkflow/tests/useractioninstancehistory.yml';
	
	/**
	 * 
	 * @var Member
	 */
	protected $currentMember;
	
	/**
	 * 
	 */
	public function setUp() {
		parent::setUp();
		$this->currentMember = $this->objFromFixture('Member', 'ApproverMember01');

It seems like $this->objFromFixture('Member', 'ApproverMember01') can also be of type object<DataObject>. However, the property $currentMember is declared as type object<Member>. Maybe add an additional type check?

	}

	/**
	 * Tests WorkflowInstance#getMostRecentActionForUser()
	 */
	public function testGetMostRecentActionForUser() {
	
		// Single, AssignUsersToWorkflowAction in "History"
		$history01 = $this->objFromFixture('WorkflowInstance', 'WorkflowInstance01');
		$mostRecentActionForUser01 = $history01->getMostRecentActionForUser($this->currentMember);
		$this->assertInstanceOf('WorkflowActionInstance', $mostRecentActionForUser01, 'Asserts the correct ClassName is retured #1');

The method assertInstanceOf() does not seem to exist on object<WorkflowInstanceTest>.

		$this->assertEquals('Assign', $mostRecentActionForUser01->BaseAction()->Title, 'Asserts the correct BaseAction is retured #1');

The method assertEquals() does not seem to exist on object<WorkflowInstanceTest>.

		
		// No AssignUsersToWorkflowAction found with Member's related Group in "History"
		$history02 = $this->objFromFixture('WorkflowInstance', 'WorkflowInstance02');
		$mostRecentActionForUser02 = $history02->getMostRecentActionForUser($this->currentMember);
		$this->assertFalse($mostRecentActionForUser02, 'Asserts false is returned because no WorkflowActionInstance was found');

The method assertFalse() does not seem to exist on object<WorkflowInstanceTest>.

		
		// Multiple AssignUsersToWorkflowAction in "History", only one with Group relations
		$history03 = $this->objFromFixture('WorkflowInstance', 'WorkflowInstance03');
		$mostRecentActionForUser03 = $history03->getMostRecentActionForUser($this->currentMember);
		$this->assertInstanceOf('WorkflowActionInstance', $mostRecentActionForUser03, 'Asserts the correct ClassName is retured #2');

The method assertInstanceOf() does not seem to exist on object<WorkflowInstanceTest>.

		$this->assertEquals('Assign', $mostRecentActionForUser03->BaseAction()->Title, 'Asserts the correct BaseAction is retured #2');

The method assertEquals() does not seem to exist on object<WorkflowInstanceTest>.

		
		// Multiple AssignUsersToWorkflowAction in "History", both with Group relations
		$history04 = $this->objFromFixture('WorkflowInstance', 'WorkflowInstance04');
		$mostRecentActionForUser04 = $history04->getMostRecentActionForUser($this->currentMember);
		$this->assertInstanceOf('WorkflowActionInstance', $mostRecentActionForUser04, 'Asserts the correct ClassName is retured #3');

The method assertInstanceOf() does not seem to exist on object<WorkflowInstanceTest>.

		$this->assertEquals('Assigned Again', $mostRecentActionForUser04->BaseAction()->Title, 'Asserts the correct BaseAction is retured #3');

The method assertEquals() does not seem to exist on object<WorkflowInstanceTest>.

		
		// Multiple AssignUsersToWorkflowAction in "History", one with Group relations
		$history05 = $this->objFromFixture('WorkflowInstance', 'WorkflowInstance05');
		$mostRecentActionForUser05 = $history05->getMostRecentActionForUser($this->currentMember);
		$this->assertInstanceOf('WorkflowActionInstance', $mostRecentActionForUser05, 'Asserts the correct ClassName is retured #4');

The method assertInstanceOf() does not seem to exist on object<WorkflowInstanceTest>.

		$this->assertEquals('Assigned Me', $mostRecentActionForUser05->BaseAction()->Title, 'Asserts the correct BaseAction is retured #4');

The method assertEquals() does not seem to exist on object<WorkflowInstanceTest>.

	}
	
	/**
	 * Tests WorkflowInstance#canView()
	 */
	public function testCanView() {
		// Single, AssignUsersToWorkflowAction in "History"
		$history01 = $this->objFromFixture('WorkflowInstance', 'WorkflowInstance01');
		$this->assertTrue($history01->canView($this->currentMember));

The method assertTrue() does not seem to exist on object<WorkflowInstanceTest>.

		
		// No AssignUsersToWorkflowAction found with Member's related Group in "History"
		$history02 = $this->objFromFixture('WorkflowInstance', 'WorkflowInstance02');
		$this->assertFalse($history02->canView($this->currentMember));

The method assertFalse() does not seem to exist on object<WorkflowInstanceTest>.

		
		// Multiple AssignUsersToWorkflowAction in "History", only one with Group relations
		$history03 = $this->objFromFixture('WorkflowInstance', 'WorkflowInstance03');
		$this->assertTrue($history03->canView($this->currentMember));	

The method assertTrue() does not seem to exist on object<WorkflowInstanceTest>.

		
		// Multiple AssignUsersToWorkflowAction in "History", both with Group relations
		$history04 = $this->objFromFixture('WorkflowInstance', 'WorkflowInstance04');
		$this->assertTrue($history04->canView($this->currentMember));	

The method assertTrue() does not seem to exist on object<WorkflowInstanceTest>.

		
		// Multiple AssignUsersToWorkflowAction in "History"
		$history05 = $this->objFromFixture('WorkflowInstance', 'WorkflowInstance05');
		$this->assertTrue($history05->canView($this->currentMember));	

The method assertTrue() does not seem to exist on object<WorkflowInstanceTest>.

	}

	public function testValidTransitions() {
		$instance = $this->objFromFixture('WorkflowInstance', 'WorkflowInstance06');
		$transition1 = $this->objFromFixture('WorkflowTransition', 'Transition05');
		$transition2 = $this->objFromFixture('WorkflowTransition', 'Transition06');
		$member1 = $this->objFromFixture('Member', 'Transition05Member');
		$member2 = $this->objFromFixture('Member', 'Transition06Member');

		// Given logged in as admin, check that there are two actions
		$this->logInWithPermission('ADMIN');
		$transitions = $instance->validTransitions()->column('ID');
		$this->assertContains($transition1->ID, $transitions);
		$this->assertContains($transition2->ID, $transitions);

		// Logged in as a member with permission on one transition, check that only this one is present
		$member1->logIn();
		$transitions = $instance->validTransitions()->column('ID');
		$this->assertContains($transition1->ID, $transitions);
		$this->assertNotContains($transition2->ID, $transitions);

		// Logged in as a member with permissions via group
		$member2->logIn();
		$transitions = $instance->validTransitions()->column('ID');
		$this->assertNotContains($transition1->ID, $transitions);
		$this->assertContains($transition2->ID, $transitions);
	}

}