Completed
Pull Request — master (#230)
by Helpful
03:29
created
code/admin/AdvancedWorkflowAdmin.php 1 patch
Doc Comments   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -219,9 +219,8 @@
 block discarded – undo
219 219
     /**
220 220
      * Get WorkflowInstance Target objects to show for users in initial gridfield(s)
221 221
      *
222
-     * @param Member $member
223 222
      * @param string $fieldName The name of the gridfield that determines which dataset to return
224
-     * @return DataList
223
+     * @return ArrayList
225 224
      * @todo Add the ability to see embargo/expiry dates in report-gridfields at-a-glance if QueuedJobs module installed
226 225
      */
227 226
     public function userObjects(Member $user, $fieldName)
Please login to merge, or discard this patch.
code/admin/WorkflowDefinitionExporter.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -100,7 +100,7 @@
 block discarded – undo
100 100
      * Used for pushing data to the browser to prompt for download
101 101
      * 
102 102
      * @param string $str
103
-     * @return number $bytes
103
+     * @return integer $bytes
104 104
      */
105 105
     public function getExportSize($str)
106 106
     {
Please login to merge, or discard this patch.
code/controllers/FrontEndWorkflowController.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -82,7 +82,7 @@
 block discarded – undo
82 82
      * - required fields from the Context Object
83 83
      * - Actions from the connected WorkflowTransitions
84 84
      * 
85
-     * @return Form
85
+     * @return null|FrontendWorkflowForm
86 86
      */
87 87
     public function Form()
88 88
     {
Please login to merge, or discard this patch.
code/dataobjects/WorkflowAction.php 1 patch
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -53,7 +53,7 @@  discard block
 block discarded – undo
53 53
      * if null is returned from this method.
54 54
      *
55 55
      * @param  DataObject $target
56
-     * @return bool
56
+     * @return boolean|null
57 57
      */
58 58
     public function canEditTarget(DataObject $target)
59 59
     {
@@ -64,7 +64,7 @@  discard block
 block discarded – undo
64 64
      * Does this action restrict viewing of the document?
65 65
      *
66 66
      * @param  DataObject $target
67
-     * @return bool
67
+     * @return boolean|null
68 68
      */
69 69
     public function canViewTarget(DataObject $target)
70 70
     {
@@ -75,7 +75,7 @@  discard block
 block discarded – undo
75 75
      * Does this action restrict the publishing of a document?
76 76
      *
77 77
      * @param  DataObject $target
78
-     * @return bool
78
+     * @return boolean|null
79 79
      */
80 80
     public function canPublishTarget(DataObject $target)
81 81
     {
Please login to merge, or discard this patch.
code/dataobjects/WorkflowActionInstance.php 1 patch
Doc Comments   +7 added lines patch added patch discarded remove patch
@@ -44,6 +44,7 @@  discard block
 block discarded – undo
44 44
 
45 45
     /**
46 46
      * Gets fields for when this is part of an active workflow
47
+     * @param FieldList $fields
47 48
      */
48 49
     public function updateWorkflowFields($fields)
49 50
     {
@@ -52,6 +53,9 @@  discard block
 block discarded – undo
52 53
         }
53 54
     }
54 55
 
56
+    /**
57
+     * @param FieldList $fields
58
+     */
55 59
     public function updateFrontendWorkflowFields($fields)
56 60
     {
57 61
         if ($this->BaseAction()->AllowCommenting) {
@@ -86,6 +90,9 @@  discard block
 block discarded – undo
86 90
         return $obj;
87 91
     }
88 92
 
93
+    /**
94
+     * @param FieldList $actions
95
+     */
89 96
     public function updateFrontEndWorkflowActions($actions)
90 97
     {
91 98
         $ba = $this->BaseAction();
Please login to merge, or discard this patch.
code/dataobjects/WorkflowDefinition.php 1 patch
Doc Comments   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -403,7 +403,7 @@  discard block
 block discarded – undo
403 403
     /**
404 404
      *
405 405
      * @param Member $member
406
-     * @return boolean
406
+     * @return boolean|null
407 407
      */
408 408
     public function canView($member=null)
409 409
     {
@@ -451,6 +451,7 @@  discard block
 block discarded – undo
451 451
      * Checks whether the passed user is able to view this ModelAdmin
452 452
      *
453 453
      * @param $memberID
454
+     * @param Member|null $member
454 455
      */
455 456
     protected function userHasAccess($member)
456 457
     {
Please login to merge, or discard this patch.
code/dataobjects/WorkflowInstance.php 1 patch
Doc Comments   +4 added lines, -3 removed lines patch added patch discarded remove patch
@@ -446,6 +446,7 @@  discard block
 block discarded – undo
446 446
      * workflow
447 447
      *
448 448
      * @param $memberID
449
+     * @param Member|null $member
449 450
      */
450 451
     protected function userHasAccess($member)
451 452
     {
@@ -500,7 +501,7 @@  discard block
 block discarded – undo
500 501
     /**
501 502
      * Does this action restrict the publishing of a document?
502 503
      *
503
-     * @return boolean
504
+     * @return boolean|null
504 505
      */
505 506
     public function canPublishTarget()
506 507
     {
@@ -513,7 +514,7 @@  discard block
 block discarded – undo
513 514
      * Get the current set of transitions that are valid for the current workflow state,
514 515
      * and are available to the current user.
515 516
      *
516
-     * @return array
517
+     * @return ArrayList
517 518
      */
518 519
     public function validTransitions()
519 520
     {
@@ -679,7 +680,7 @@  discard block
 block discarded – undo
679 680
     /**
680 681
      * Tells us if $member has had permissions over some part of the current WorkflowInstance.
681 682
      *
682
-     * @param $member
683
+     * @param Member $member
683 684
      * @return \WorkflowAction | boolean
684 685
      */
685 686
     public function getMostRecentActionForUser($member = null)
Please login to merge, or discard this patch.
code/extensions/WorkflowApplicable.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -299,6 +299,7 @@
 block discarded – undo
299 299
     /**
300 300
      * Gets the history of a workflow instance
301 301
      *
302
+     * @param integer $limit
302 303
      * @return DataObjectSet
303 304
      */
304 305
     public function getWorkflowHistory($limit = null)
Please login to merge, or discard this patch.
code/formfields/WorkflowField.php 1 patch
Doc Comments   +4 added lines patch added patch discarded remove patch
@@ -15,6 +15,10 @@
 block discarded – undo
15 15
 
16 16
     protected $definition;
17 17
 
18
+    /**
19
+     * @param string $name
20
+     * @param string $title
21
+     */
18 22
     public function __construct($name, $title, WorkflowDefinition $definition)
19 23
     {
20 24
         $this->definition = $definition;
Please login to merge, or discard this patch.