b2blaze.models.bucket

Complexity

Total Complexity

7

Size/Duplication

Total Lines	75
Duplicated Lines	0 %

Test Coverage

Coverage

85.29%

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	B2Bucket.files()	0	4	1
A	B2Bucket.edit()	0	3	1
A	B2Bucket.delete()	0	27	4
A	B2Bucket.__init__()	0	26	1

"""
Copyright George Sibble 2018
"""
from .file_list import B2FileList
from ..b2_exceptions import B2Exception
from ..api import API

class B2Bucket(object):

Empty class docstring

Too many instance attributes (10/7)

    """

    """
    def __init__(self, connector, parent_list, bucketId, bucketName, bucketType, bucketInfo, lifecycleRules, revision,

This line is too long as per the coding-style (118/100).

Too many arguments (10/5)

The argument args seems to be unused.

The argument kwargs seems to be unused.

                 corsRules, *args, **kwargs):
        """

        :param connector:
        :param parent_list:
        :param bucketId:
        :param bucketName:
        :param bucketType:
        :param bucketInfo:
        :param lifecycleRules:
        :param revision:
        :param corsRules:
        :param args:
        :param kwargs:
        """
        self.bucket_id = bucketId
        self.bucket_name = bucketName
        self.bucket_type = bucketType
        self.bucket_info = bucketInfo
        self.lifecycle_rules = lifecycleRules
        self.revision = revision
        self.cors_rules = corsRules
        self.connector = connector
        self.parent_list = parent_list
        self.deleted = False

    def delete(self, delete_files=False, confirm_non_empty=False):
        """ Delete a bucket.

        Params:
            delete_files:           (bool)  Delete all files first.
            confirm_non_empty:      (bool)  Confirm deleting on bucket not empty.
        """
        path = API.delete_bucket
        files = self.files.all(include_hidden=True)

The variable files seems to be unused.

        if delete_files:
            if not confirm_non_empty:
                raise B2Exception('Bucket is not empty! Must confirm deletion of all files with confirm_non_empty=True')

This line is too long as per the coding-style (120/100).

            else:
                print("Deleting all files from bucket. Beware API limits!")

There is an unnecessary parenthesis after print.

                self.files.delete_all(confirm=True)
            

Trailing whitespace

        params = {
            'bucketId': self.bucket_id
        }
        response = self.connector.make_request(path=path, method='post', params=params, account_id_required=True)

This line is too long as per the coding-style (113/100).

        if response.status_code == 200:
            self.deleted = True
            del self.parent_list._buckets_by_name[self.bucket_name]

It seems like _buckets_by_name was declared protected and should not be accessed from this context.

            del self.parent_list._buckets_by_id[self.bucket_id]

It seems like _buckets_by_id was declared protected and should not be accessed from this context.

        else:
            raise B2Exception.parse(response)

    def edit(self):

This method should have a docstring.

        #TODO:  Edit details

TODO and FIXME comments should generally be avoided.

        pass

    @property
    def files(self):
        """ List of files in the bucket. B2FileList instance. """
        return B2FileList(connector=self.connector, bucket=self)

Final newline missing