b2blaze.models.bucket.B2Bucket.__init__() - Code Metrics - sibblegp/b2blaze - Measure and Improve Code Quality continuously with Scrutinizer

b2blaze.models.bucket.B2Bucket.init() A
last analyzed 2018-10-30 20:38 UTC

↳ Parent: b2blaze.models.bucket

Complexity

Conditions

Size

Total Lines	26
Code Lines	12

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	11
CRAP Score	1

Importance

Changes

Metric	Value
cc	1
eloc	12
nop	12
dl	0
loc	26
ccs	11
cts	11
cp	1
crap	1
rs	9.8
c	0
b	0
f	0

How to fix Many Parameters

"""
Copyright George Sibble 2018
"""
from .file_list import B2FileList
from ..b2_exceptions import B2Exception
from ..api import API

class B2Bucket(object):

    """

    """
    def __init__(self, connector, parent_list, bucketId, bucketName, bucketType, bucketInfo, lifecycleRules, revision,

                 corsRules, *args, **kwargs):
        """

        :param connector:
        :param parent_list:
        :param bucketId:
        :param bucketName:
        :param bucketType:
        :param bucketInfo:
        :param lifecycleRules:
        :param revision:
        :param corsRules:
        :param args:
        :param kwargs:
        """
        self.bucket_id = bucketId
        self.bucket_name = bucketName
        self.bucket_type = bucketType
        self.bucket_info = bucketInfo
        self.lifecycle_rules = lifecycleRules
        self.revision = revision
        self.cors_rules = corsRules
        self.connector = connector
        self.parent_list = parent_list
        self.deleted = False

    def delete(self, delete_files=False, confirm_non_empty=False):
        """ Delete a bucket.

        Params:
            delete_files:           (bool)  Delete all files first.
            confirm_non_empty:      (bool)  Confirm deleting on bucket not empty.
        """
        path = API.delete_bucket
        files = self.files.all(include_hidden=True)

        if delete_files:
            if not confirm_non_empty:
                raise B2Exception('Bucket is not empty! Must confirm deletion of all files with confirm_non_empty=True')

            else:
                print("Deleting all files from bucket. Beware API limits!")

                self.files.delete_all(confirm=True)
            


        params = {
            'bucketId': self.bucket_id
        }
        response = self.connector.make_request(path=path, method='post', params=params, account_id_required=True)

        if response.status_code == 200:
            self.deleted = True
            del self.parent_list._buckets_by_name[self.bucket_name]
class MyParent:
    def __init__(self):
        self._x = 1;
        self.y = 2;

class MyChild(MyParent):
    def some_method(self):
        return self._x    # Ok, since accessed from a child class

class AnotherClass:
    def some_method(self, instance_of_my_child):
        return instance_of_my_child._x   # Would be flagged as AnotherClass is not
                                         # a child class of MyParent
            del self.parent_list._buckets_by_id[self.bucket_id]
class MyParent:
    def __init__(self):
        self._x = 1;
        self.y = 2;

class MyChild(MyParent):
    def some_method(self):
        return self._x    # Ok, since accessed from a child class

class AnotherClass:
    def some_method(self, instance_of_my_child):
        return instance_of_my_child._x   # Would be flagged as AnotherClass is not
                                         # a child class of MyParent
        else:
            raise B2Exception.parse(response)

    def edit(self):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        #TODO:  Edit details

        pass

    @property
    def files(self):
        """ List of files in the bucket. B2FileList instance. """
        return B2FileList(connector=self.connector, bucket=self)


1		"""
2		Copyright George Sibble 2018
3		"""
4	1	from .file_list import B2FileList
5	1	from ..b2_exceptions import B2Exception
6	1	from ..api import API
7
8	1	class B2Bucket(object):
		0 ignored issues – show Documentation introduced 2018-10-30 20:37 UTC by Report Bug Copy Issue Report Empty class docstring Loading history... best-practice introduced 2018-10-30 20:37 UTC by Report Bug Copy Issue Report Too many instance attributes (10/7) Loading history...
9		"""
10
11		"""
12	1	def __init__(self, connector, parent_list, bucketId, bucketName, bucketType, bucketInfo, lifecycleRules, revision,
		0 ignored issues – show Coding Style introduced 2018-06-27 20:20 UTC by Report Bug Copy Issue Report This line is too long as per the coding-style (118/100). This check looks for lines that are too long. You can specify the maximum line length. Loading history... best-practice introduced 2018-06-27 20:20 UTC by Report Bug Copy Issue Report Too many arguments (10/5) Loading history... Unused Code introduced 2018-06-27 20:20 UTC by Report Bug Copy Issue Report The argument `args` seems to be unused. Loading history... Unused Code introduced 2018-06-27 20:20 UTC by Report Bug Copy Issue Report The argument `kwargs` seems to be unused. Loading history...
13		corsRules, args, *kwargs):
14		"""
15
16		:param connector:
17		:param parent_list:
18		:param bucketId:
19		:param bucketName:
20		:param bucketType:
21		:param bucketInfo:
22		:param lifecycleRules:
23		:param revision:
24		:param corsRules:
25		:param args:
26		:param kwargs:
27		"""
28	1	self.bucket_id = bucketId
29	1	self.bucket_name = bucketName
30	1	self.bucket_type = bucketType
31	1	self.bucket_info = bucketInfo
32	1	self.lifecycle_rules = lifecycleRules
33	1	self.revision = revision
34	1	self.cors_rules = corsRules
35	1	self.connector = connector
36	1	self.parent_list = parent_list
37	1	self.deleted = False
38
39	1	def delete(self, delete_files=False, confirm_non_empty=False):
40		""" Delete a bucket.
41
42		Params:
43		delete_files: (bool) Delete all files first.
44		confirm_non_empty: (bool) Confirm deleting on bucket not empty.
45		"""
46	1	path = API.delete_bucket
47	1	files = self.files.all(include_hidden=True)
		0 ignored issues – show Unused Code introduced 2018-10-30 20:37 UTC by Report Bug Copy Issue Report The variable `files` seems to be unused. Loading history...
48	1	if delete_files:
49		if not confirm_non_empty:
50		raise B2Exception('Bucket is not empty! Must confirm deletion of all files with confirm_non_empty=True')
		0 ignored issues – show Coding Style introduced 2018-10-30 20:37 UTC by Report Bug Copy Issue Report This line is too long as per the coding-style (120/100). This check looks for lines that are too long. You can specify the maximum line length. Loading history...
51		else:
52		print("Deleting all files from bucket. Beware API limits!")
		0 ignored issues – show Unused Code Coding Style introduced 2018-10-30 20:37 UTC by Report Bug Copy Issue Report There is an unnecessary parenthesis after `print`. Loading history...
53		self.files.delete_all(confirm=True)
54
		0 ignored issues – show Coding Style introduced 2018-10-30 20:37 UTC by Report Bug Copy Issue Report Trailing whitespace Loading history...
55
56	1	params = {
57		'bucketId': self.bucket_id
58		}
59	1	response = self.connector.make_request(path=path, method='post', params=params, account_id_required=True)
		0 ignored issues – show Coding Style introduced 2018-06-27 20:20 UTC by Report Bug Copy Issue Report This line is too long as per the coding-style (113/100). This check looks for lines that are too long. You can specify the maximum line length. Loading history...
60	1	if response.status_code == 200:
61	1	self.deleted = True
62	1	del self.parent_list._buckets_by_name[self.bucket_name]
		0 ignored issues – show Coding Style Best Practice introduced 2018-06-27 20:20 UTC by Report Bug Copy Issue Report It seems like `_buckets_by_name` was declared protected and should not be accessed from this context. Prefixing a member variable `_` is usually regarded as the equivalent of declaring it with protected visibility that exists in other languages. Consequentially, such a member should only be accessed from the same class or a child class: class MyParent: def __init__(self): self._x = 1; self.y = 2; class MyChild(MyParent): def some_method(self): return self._x # Ok, since accessed from a child class class AnotherClass: def some_method(self, instance_of_my_child): return instance_of_my_child._x # Would be flagged as AnotherClass is not # a child class of MyParent Loading history...
63	1	del self.parent_list._buckets_by_id[self.bucket_id]
		0 ignored issues – show Coding Style Best Practice introduced 2018-06-27 20:20 UTC by Report Bug Copy Issue Report It seems like `_buckets_by_id` was declared protected and should not be accessed from this context. Prefixing a member variable `_` is usually regarded as the equivalent of declaring it with protected visibility that exists in other languages. Consequentially, such a member should only be accessed from the same class or a child class: class MyParent: def __init__(self): self._x = 1; self.y = 2; class MyChild(MyParent): def some_method(self): return self._x # Ok, since accessed from a child class class AnotherClass: def some_method(self, instance_of_my_child): return instance_of_my_child._x # Would be flagged as AnotherClass is not # a child class of MyParent Loading history...
64		else:
65	1	raise B2Exception.parse(response)
66
67	1	def edit(self):
		0 ignored issues – show Coding Style introduced 2018-10-30 20:37 UTC by Report Bug Copy Issue Report This method should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
68		#TODO: Edit details
		0 ignored issues – show Coding Style introduced 2018-06-27 20:20 UTC by Report Bug Copy Issue Report `TODO` and `FIXME` comments should generally be avoided. Loading history...
69		pass
70
71	1	@property
72		def files(self):
73		""" List of files in the bucket. B2FileList instance. """
74		return B2FileList(connector=self.connector, bucket=self)
		0 ignored issues – show Coding Style introduced 2018-06-27 20:20 UTC by Report Bug Copy Issue Report Final newline missing Loading history...

sibblegp / b2blaze

GitHub Access Token became invalid

b2blaze.models.bucket.B2Bucket.__init__() A last analyzed 2018-10-30 20:38 UTC

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Many Parameters

Many Parameters

Duplication Side-by-Side

Filter issues like

b2blaze.models.bucket.B2Bucket.init() A
last analyzed 2018-10-30 20:38 UTC