shweshi\OpenGraph\OpenGraph::fetch()

Complexity

Conditions	5
Paths	5

Size

Total Lines	24
Code Lines	12

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public function fetch($url)
    {
        $html = $this->curl_get_contents($url);

        /**
         * parsing starts here:.
         */
        $doc = new DOMDocument();
        @$doc->loadHTML($html);

It seems like you do not handle an error condition for loadHTML(). This can introduce security issues, and is generally not recommended.

        $tags = $doc->getElementsByTagName('meta');
        $metadata = [];

        foreach ($tags as $tag) {
            if ($tag->hasAttribute('property') && strpos($tag->getAttribute('property'), 'og:') === 0) {
                $key = strtr(substr($tag->getAttribute('property'), 3), '-', '_');
                $value = $tag->getAttribute('content');
            }
            if (!empty($key)) {
                $metadata[$key] = $value;

The variable $value does not seem to be defined for all execution paths leading up to this point.

            }
        }

        return $metadata;
    }