shweshi\OpenGraph\OpenGraph

Complexity

Total Complexity

6

Size/Duplication

Total Lines	41
Duplicated Lines	0 %

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	fetch()	0	24	5
A	curl_get_contents()	0	13	1

<?php

namespace shweshi\OpenGraph;

use DOMDocument;

class OpenGraph
{
    public function fetch($url)
    {
        $html = $this->curl_get_contents($url);

        /**
         * parsing starts here:.
         */
        $doc = new DOMDocument();
        @$doc->loadHTML($html);

It seems like you do not handle an error condition for loadHTML(). This can introduce security issues, and is generally not recommended.

        $tags = $doc->getElementsByTagName('meta');
        $metadata = [];

        foreach ($tags as $tag) {
            if ($tag->hasAttribute('property') && strpos($tag->getAttribute('property'), 'og:') === 0) {
                $key = strtr(substr($tag->getAttribute('property'), 3), '-', '_');
                $value = $tag->getAttribute('content');
            }
            if (!empty($key)) {
                $metadata[$key] = $value;

The variable $value does not seem to be defined for all execution paths leading up to this point.

            }
        }

        return $metadata;
    }

    protected function curl_get_contents($url)
    {
        $curl = curl_init($url);
        curl_setopt($curl, CURLOPT_FAILONERROR, 1);
        curl_setopt($curl, CURLOPT_FOLLOWLOCATION, 1);
        curl_setopt($curl, CURLOPT_RETURNTRANSFER, 1);
        curl_setopt($curl, CURLOPT_SSL_VERIFYHOST, 0);
        curl_setopt($curl, CURLOPT_SSL_VERIFYPEER, 0);
        curl_setopt($curl, CURLOPT_TIMEOUT, 30);
        $response = curl_exec($curl);
        curl_close($curl);

        return $response;
    }
}