Completed
Pull Request — master (#82)
by Jan Philipp
01:38
created
src/ScriptRuntime/DeferredProcessCommand.php 1 patch
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -33,7 +33,6 @@
 block discarded – undo
33 33
      * @param int $lineNumber
34 34
      * @param bool $ignoreError
35 35
      * @param bool $tty
36
-     * @param bool $deferred
37 36
      */
38 37
     public function __construct(
39 38
         string $shellCommand,
Please login to merge, or discard this patch.
src/ScriptRuntime/ScriptLoader/PshScriptParser.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -65,7 +65,7 @@  discard block
 block discarded – undo
65 65
     private function createTokenHandler(): array
66 66
     {
67 67
         return [
68
-            self::TOKEN_INCLUDE => function (string $currentLine, int $lineNumber, Script $script): string {
68
+            self::TOKEN_INCLUDE => function(string $currentLine, int $lineNumber, Script $script): string {
69 69
                 $path = $this->findInclude($script, $this->removeFromStart(self::TOKEN_INCLUDE, $currentLine));
70 70
                 $includeScript = new Script(pathinfo($path, PATHINFO_DIRNAME), pathinfo($path, PATHINFO_BASENAME));
71 71
 
@@ -75,7 +75,7 @@  discard block
 block discarded – undo
75 75
                 return '';
76 76
             },
77 77
 
78
-            self::TOKEN_TEMPLATE => function (string $currentLine, int $lineNumber, Script $script): string {
78
+            self::TOKEN_TEMPLATE => function(string $currentLine, int $lineNumber, Script $script): string {
79 79
                 $definition = $this->removeFromStart(self::TOKEN_TEMPLATE, $currentLine);
80 80
                 list($rawSource, $rawDestination) = explode(':', $definition);
81 81
 
@@ -88,7 +88,7 @@  discard block
 block discarded – undo
88 88
                 return '';
89 89
             },
90 90
 
91
-            self::TOKEN_WAIT => function (string $currentLine, int $lineNumber): string {
91
+            self::TOKEN_WAIT => function(string $currentLine, int $lineNumber): string {
92 92
                 $this->commandBuilder
93 93
                     ->addWaitCommand($lineNumber);
94 94
 
@@ -96,25 +96,25 @@  discard block
 block discarded – undo
96 96
                 return '';
97 97
             },
98 98
 
99
-            self::TOKEN_MODIFIER_IGNORE_ERROR => function (string $currentLine): string {
99
+            self::TOKEN_MODIFIER_IGNORE_ERROR => function(string $currentLine): string {
100 100
                 $this->commandBuilder->setIgnoreError();
101 101
 
102 102
                 return $this->removeFromStart(self::TOKEN_MODIFIER_IGNORE_ERROR, $currentLine);
103 103
             },
104 104
 
105
-            self::TOKEN_MODIFIER_TTY => function (string $currentLine): string {
105
+            self::TOKEN_MODIFIER_TTY => function(string $currentLine): string {
106 106
                 $this->commandBuilder->setTty();
107 107
 
108 108
                 return  $this->removeFromStart(self::TOKEN_MODIFIER_TTY, $currentLine);
109 109
             },
110 110
 
111
-            self::TOKEN_MODIFIER_DEFERRED => function (string $currentLine): string {
111
+            self::TOKEN_MODIFIER_DEFERRED => function(string $currentLine): string {
112 112
                 $this->commandBuilder->setDeferredExecution();
113 113
 
114 114
                 return $this->removeFromStart(self::TOKEN_MODIFIER_DEFERRED, $currentLine);
115 115
             },
116 116
 
117
-            self::TOKEN_WILDCARD => function (string $currentLine, int $lineNumber): string {
117
+            self::TOKEN_WILDCARD => function(string $currentLine, int $lineNumber): string {
118 118
                 $this->commandBuilder
119 119
                     ->addProcessCommand($currentLine, $lineNumber);
120 120
 
@@ -207,7 +207,7 @@  discard block
 block discarded – undo
207 207
 
208 208
             if ($this->startsWith(self::CONCATENATE_PREFIX, $line)) {
209 209
                 $lastValue = array_pop($lines);
210
-                $lines[] = $lastValue  . ' ' . trim($line);
210
+                $lines[] = $lastValue . ' ' . trim($line);
211 211
 
212 212
                 continue;
213 213
             }
Please login to merge, or discard this patch.
src/ScriptRuntime/Execution/ProcessExecutor.php 1 patch
Doc Comments   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -259,7 +259,6 @@  discard block
 block discarded – undo
259 259
 
260 260
     /**
261 261
      * @param Process $process
262
-     * @param bool $ignoreError
263 262
      * @return bool
264 263
      */
265 264
     private function isProcessResultValid(Process $process, ProcessCommand $command): bool
@@ -357,7 +356,7 @@  discard block
 block discarded – undo
357 356
 
358 357
     /**
359 358
      * @param DeferredProcess $deferredProcess
360
-     * @param $index
359
+     * @param integer $index
361 360
      */
362 361
     private function logDeferredOutputStart(DeferredProcess $deferredProcess, $index)
363 362
     {
Please login to merge, or discard this patch.