Completed
Branch ntr/fix-scrutinizer-issues (3572ab)
by Christian
13:32 queued 06:31
created
src/Storefront/Controller/AccountController.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -13,7 +13,6 @@
 block discarded – undo
13 13
 use Shopware\Core\Framework\Exception\InvalidUuidException;
14 14
 use Shopware\Core\Framework\Struct\Uuid;
15 15
 use Shopware\Storefront\Exception\AddressNotFoundException;
16
-use Shopware\Storefront\Exception\CustomerNotFoundException;
17 16
 use Shopware\Storefront\Page\Account\AccountService;
18 17
 use Shopware\Storefront\Page\Account\AddressSaveRequest;
19 18
 use Shopware\Storefront\Page\Account\CustomerAddressPageLoader;
Please login to merge, or discard this patch.
src/Core/Framework/ORM/EntityRepository.php 1 patch
Unused Use Statements   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -13,8 +13,8 @@
 block discarded – undo
13 13
 use Shopware\Core\Framework\ORM\Search\AggregatorResult;
14 14
 use Shopware\Core\Framework\ORM\Search\Criteria;
15 15
 use Shopware\Core\Framework\ORM\Search\EntityAggregatorInterface;
16
-use Shopware\Core\Framework\ORM\Search\EntitySearcherInterface;
17 16
 use Shopware\Core\Framework\ORM\Search\EntitySearchResult;
17
+use Shopware\Core\Framework\ORM\Search\EntitySearcherInterface;
18 18
 use Shopware\Core\Framework\ORM\Search\IdSearchResult;
19 19
 use Shopware\Core\Framework\ORM\Write\WriteContext;
20 20
 use Shopware\Core\Framework\Struct\ArrayStruct;
Please login to merge, or discard this patch.
src/Core/Framework/ORM/Field/SubresourceField.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -42,6 +42,9 @@
 block discarded – undo
42 42
      */
43 43
     protected $possibleKey;
44 44
 
45
+    /**
46
+     * @param string $possibleKey
47
+     */
45 48
     public function __construct(string $propertyName, string $referenceClass, ?string $possibleKey = null)
46 49
     {
47 50
         $this->referenceClass = $referenceClass;
Please login to merge, or discard this patch.
src/Core/Framework/ORM/Write/EntityWriter.php 1 patch
Unused Use Statements   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -27,6 +27,7 @@  discard block
 block discarded – undo
27 27
 use Shopware\Core\Framework\Api\Exception\IncompletePrimaryKeyException;
28 28
 use Shopware\Core\Framework\ORM\Dbal\EntityForeignKeyResolver;
29 29
 use Shopware\Core\Framework\ORM\EntityDefinition;
30
+use Shopware\Core\Framework\ORM\FieldCollection;
30 31
 use Shopware\Core\Framework\ORM\Field\Field;
31 32
 use Shopware\Core\Framework\ORM\Field\FkField;
32 33
 use Shopware\Core\Framework\ORM\Field\IdField;
@@ -34,7 +35,6 @@  discard block
 block discarded – undo
34 35
 use Shopware\Core\Framework\ORM\Field\ReferenceVersionField;
35 36
 use Shopware\Core\Framework\ORM\Field\TenantIdField;
36 37
 use Shopware\Core\Framework\ORM\Field\VersionField;
37
-use Shopware\Core\Framework\ORM\FieldCollection;
38 38
 use Shopware\Core\Framework\ORM\MappingEntityDefinition;
39 39
 use Shopware\Core\Framework\ORM\Write\Command\DeleteCommand;
40 40
 use Shopware\Core\Framework\ORM\Write\Command\InsertCommand;
Please login to merge, or discard this patch.
src/Core/Framework/ORM/Write/WriteCommandExtractor.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -200,7 +200,7 @@  discard block
 block discarded – undo
200 200
     }
201 201
 
202 202
     /**
203
-     * @param EntityDefinition|string $definition
203
+     * @param EntityDefinition $definition
204 204
      *
205 205
      * @return Field[]
206 206
      */
@@ -232,7 +232,7 @@  discard block
 block discarded – undo
232 232
 
233 233
     /**
234 234
      * @param array                   $rawData
235
-     * @param string|EntityDefinition $definition
235
+     * @param EntityDefinition $definition
236 236
      * @param FieldExceptionStack     $exceptionStack
237 237
      * @param FieldExtenderCollection $extender
238 238
      * @param Field[]                 $fields
Please login to merge, or discard this patch.
src/Storefront/Page/Account/RegistrationRequest.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -175,6 +175,9 @@
 block discarded – undo
175 175
         return $this->guest;
176 176
     }
177 177
 
178
+    /**
179
+     * @param boolean $guest
180
+     */
178 181
     public function setGuest(?bool $guest): void
179 182
     {
180 183
         $this->guest = $guest;
Please login to merge, or discard this patch.
src/Core/Checkout/Cart/Storefront/StorefrontCartController.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -246,6 +246,9 @@
 block discarded – undo
246 246
         }
247 247
     }
248 248
 
249
+    /**
250
+     * @param \Shopware\Core\Checkout\Cart\Cart\Cart $data
251
+     */
249 252
     private function serialize($data): array
250 253
     {
251 254
         $decoded = $this->serializer->normalize($data);
Please login to merge, or discard this patch.
src/Core/Framework/Api/Serializer/JsonApiEncoder.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -39,7 +39,7 @@
 block discarded – undo
39 39
     }
40 40
 
41 41
     /**
42
-     * @param EntityCollection|Entity|null $data
42
+     * @param EntityCollection $data
43 43
      */
44 44
     protected function encodeData(string $definition, $data, SerializedCollection $entities, string $baseUrl): void
45 45
     {
Please login to merge, or discard this patch.
src/Core/Framework/ORM/Dbal/EntityForeignKeyResolver.php 1 patch
Unused Use Statements   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -7,12 +7,12 @@
 block discarded – undo
7 7
 use Shopware\Core\Framework\Context;
8 8
 use Shopware\Core\Framework\Doctrine\FetchModeHelper;
9 9
 use Shopware\Core\Framework\ORM\EntityDefinition;
10
+use Shopware\Core\Framework\ORM\FieldCollection;
10 11
 use Shopware\Core\Framework\ORM\Field\AssociationInterface;
11 12
 use Shopware\Core\Framework\ORM\Field\ManyToManyAssociationField;
12 13
 use Shopware\Core\Framework\ORM\Field\ManyToOneAssociationField;
13 14
 use Shopware\Core\Framework\ORM\Field\OneToManyAssociationField;
14 15
 use Shopware\Core\Framework\ORM\Field\StructField;
15
-use Shopware\Core\Framework\ORM\FieldCollection;
16 16
 use Shopware\Core\Framework\ORM\Write\Flag\CascadeDelete;
17 17
 use Shopware\Core\Framework\ORM\Write\Flag\RestrictDelete;
18 18
 use Shopware\Core\Framework\Struct\Uuid;
Please login to merge, or discard this patch.