Completed
Branch ntr/fix-scrutinizer-issues (3572ab)
by Christian
13:32 queued 06:31
created
src/Core/Content/Catalog/ORM/CatalogField.php 1 patch
Unused Use Statements   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -32,9 +32,9 @@
 block discarded – undo
32 32
 use Shopware\Core\Framework\ORM\Write\FieldException\InvalidFieldException;
33 33
 use Shopware\Core\Framework\ORM\Write\Flag\Required;
34 34
 use Shopware\Core\Framework\Struct\Uuid;
35
-use Symfony\Component\Validator\Constraints\Choice;
36 35
 use Symfony\Component\Validator\ConstraintViolation;
37 36
 use Symfony\Component\Validator\ConstraintViolationList;
37
+use Symfony\Component\Validator\Constraints\Choice;
38 38
 
39 39
 class CatalogField extends FkField
40 40
 {
Please login to merge, or discard this patch.
src/Core/Framework/ORM/Dbal/EntityWriteGateway.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -143,7 +143,7 @@
 block discarded – undo
143 143
     }
144 144
 
145 145
     /**
146
-     * @param string|EntityDefinition $definition
146
+     * @param string $definition
147 147
      * @param array                   $primaryKey
148 148
      * @param WriteCommandQueue       $commandQueue
149 149
      *
Please login to merge, or discard this patch.
src/Storefront/Controller/StorefrontController.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -36,6 +36,7 @@
 block discarded – undo
36 36
 {
37 37
     /**
38 38
      * {@inheritdoc}
39
+     * @param string $view
39 40
      */
40 41
     protected function renderStorefront($view, array $parameters = [], Response $response = null): Response
41 42
     {
Please login to merge, or discard this patch.
src/Core/Framework/ORM/Dbal/EntityReader.php 2 patches
Doc Comments   +6 added lines patch added patch discarded remove patch
@@ -170,6 +170,9 @@  discard block
 block discarded – undo
170 170
         return $collection;
171 171
     }
172 172
 
173
+    /**
174
+     * @param ReadCriteria $criteria
175
+     */
173 176
     private function joinBasic(?Criteria $criteria, string $definition, Context $context, string $root, QueryBuilder $query, FieldCollection $fields, bool $raw = false): void
174 177
     {
175 178
         /** @var EntityDefinition $definition */
@@ -484,6 +487,9 @@  discard block
 block discarded – undo
484 487
         return false;
485 488
     }
486 489
 
490
+    /**
491
+     * @param EntityCollection $details
492
+     */
487 493
     private function removeInheritance(string $definition, $details): void
488 494
     {
489 495
         /** @var string|EntityDefinition $definition */
Please login to merge, or discard this patch.
Unused Use Statements   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -7,6 +7,7 @@  discard block
 block discarded – undo
7 7
 use Shopware\Core\Framework\ORM\Entity;
8 8
 use Shopware\Core\Framework\ORM\EntityCollection;
9 9
 use Shopware\Core\Framework\ORM\EntityDefinition;
10
+use Shopware\Core\Framework\ORM\FieldCollection;
10 11
 use Shopware\Core\Framework\ORM\Field\AssociationInterface;
11 12
 use Shopware\Core\Framework\ORM\Field\ChildrenAssociationField;
12 13
 use Shopware\Core\Framework\ORM\Field\Field;
@@ -15,7 +16,6 @@  discard block
 block discarded – undo
15 16
 use Shopware\Core\Framework\ORM\Field\OneToManyAssociationField;
16 17
 use Shopware\Core\Framework\ORM\Field\SearchKeywordAssociationField;
17 18
 use Shopware\Core\Framework\ORM\Field\TranslatedField;
18
-use Shopware\Core\Framework\ORM\FieldCollection;
19 19
 use Shopware\Core\Framework\ORM\Read\EntityReaderInterface;
20 20
 use Shopware\Core\Framework\ORM\Read\ReadCriteria;
21 21
 use Shopware\Core\Framework\ORM\Search\Criteria;
Please login to merge, or discard this patch.
src/Core/Framework/ORM/Dbal/Indexing/InheritanceIndexer.php 1 patch
Unused Use Statements   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -13,13 +13,13 @@
 block discarded – undo
13 13
 use Shopware\Core\Framework\ORM\EntityDefinition;
14 14
 use Shopware\Core\Framework\ORM\Event\EntityWrittenContainerEvent;
15 15
 use Shopware\Core\Framework\ORM\Event\EntityWrittenEvent;
16
+use Shopware\Core\Framework\ORM\FieldCollection;
16 17
 use Shopware\Core\Framework\ORM\Field\AssociationInterface;
17 18
 use Shopware\Core\Framework\ORM\Field\Field;
18 19
 use Shopware\Core\Framework\ORM\Field\ManyToManyAssociationField;
19 20
 use Shopware\Core\Framework\ORM\Field\ManyToOneAssociationField;
20 21
 use Shopware\Core\Framework\ORM\Field\OneToManyAssociationField;
21 22
 use Shopware\Core\Framework\ORM\Field\TranslationsAssociationField;
22
-use Shopware\Core\Framework\ORM\FieldCollection;
23 23
 use Shopware\Core\Framework\ORM\Write\Flag\Inherited;
24 24
 use Shopware\Core\Framework\Struct\Uuid;
25 25
 use Symfony\Component\EventDispatcher\EventDispatcherInterface;
Please login to merge, or discard this patch.
src/Core/Framework/ORM/Search/Term/EntityScoreQueryBuilder.php 1 patch
Unused Use Statements   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -3,12 +3,12 @@
 block discarded – undo
3 3
 namespace Shopware\Core\Framework\ORM\Search\Term;
4 4
 
5 5
 use Shopware\Core\Framework\ORM\EntityDefinition;
6
+use Shopware\Core\Framework\ORM\FieldCollection;
6 7
 use Shopware\Core\Framework\ORM\Field\AssociationInterface;
7 8
 use Shopware\Core\Framework\ORM\Field\Field;
8 9
 use Shopware\Core\Framework\ORM\Field\ManyToManyAssociationField;
9 10
 use Shopware\Core\Framework\ORM\Field\StringField;
10 11
 use Shopware\Core\Framework\ORM\Field\TranslatedField;
11
-use Shopware\Core\Framework\ORM\FieldCollection;
12 12
 use Shopware\Core\Framework\ORM\Search\Query\MatchQuery;
13 13
 use Shopware\Core\Framework\ORM\Search\Query\ScoreQuery;
14 14
 use Shopware\Core\Framework\ORM\Search\Query\TermQuery;
Please login to merge, or discard this patch.
src/Core/Framework/Api/Controller/ApiController.php 1 patch
Unused Use Statements   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -12,6 +12,7 @@  discard block
 block discarded – undo
12 12
 use Shopware\Core\Framework\ORM\EntityDefinition;
13 13
 use Shopware\Core\Framework\ORM\Event\EntityWrittenContainerEvent;
14 14
 use Shopware\Core\Framework\ORM\Exception\DefinitionNotFoundException;
15
+use Shopware\Core\Framework\ORM\FieldCollection;
15 16
 use Shopware\Core\Framework\ORM\Field\AssociationInterface;
16 17
 use Shopware\Core\Framework\ORM\Field\Field;
17 18
 use Shopware\Core\Framework\ORM\Field\ManyToManyAssociationField;
@@ -20,7 +21,6 @@  discard block
 block discarded – undo
20 21
 use Shopware\Core\Framework\ORM\Field\ReferenceVersionField;
21 22
 use Shopware\Core\Framework\ORM\Field\TenantIdField;
22 23
 use Shopware\Core\Framework\ORM\Field\VersionField;
23
-use Shopware\Core\Framework\ORM\FieldCollection;
24 24
 use Shopware\Core\Framework\ORM\Read\ReadCriteria;
25 25
 use Shopware\Core\Framework\ORM\RepositoryInterface;
26 26
 use Shopware\Core\Framework\ORM\Search\Criteria;
@@ -37,7 +37,6 @@  discard block
 block discarded – undo
37 37
 use Symfony\Component\HttpKernel\Exception\MethodNotAllowedHttpException;
38 38
 use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
39 39
 use Symfony\Component\HttpKernel\Exception\UnsupportedMediaTypeHttpException;
40
-use Symfony\Component\Serializer\Exception\InvalidArgumentException;
41 40
 use Symfony\Component\Serializer\Exception\UnexpectedValueException;
42 41
 use Symfony\Component\Serializer\Serializer;
43 42
 
Please login to merge, or discard this patch.
src/Core/Framework/ORM/Field/ReferenceVersionField.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -39,6 +39,9 @@
 block discarded – undo
39 39
      */
40 40
     protected $versionReference;
41 41
 
42
+    /**
43
+     * @param string $storageName
44
+     */
42 45
     public function __construct(string $definition, ?string $storageName = null)
43 46
     {
44 47
         /** @var string|EntityDefinition $definition */
Please login to merge, or discard this patch.
src/Core/Framework/ORM/Write/Command/WriteCommandQueue.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -52,6 +52,7 @@
 block discarded – undo
52 52
     /**
53 53
      * @param string $definition
54 54
      * @param string ...$identifierOrder
55
+     * @param string[] $identifierOrder
55 56
      */
56 57
     public function setOrder(string $definition, string ...$identifierOrder): void
57 58
     {
Please login to merge, or discard this patch.