shmax / graphql-php-validation-toolkit

tests/Utils.php

Spacing +2 added lines, -2 removed lines

@@ -13,7 +13,7 @@ 
 
 class Utils
 {
-    public static function nowdoc(string $str) : string
+    public static function nowdoc (string $str) : string
     {
         $lines = preg_split('/\\n/', $str);
 
@@ -26,7 +26,7 @@ 
         }
 
         // Toss out the first and last lines.
-        $lines = array_slice($lines, 1, count($lines) - 2);
+        $lines = array_slice($lines, 1, count($lines)-2);
 
         // take the tabs from the first line, and subtract them from all lines
         $matches = [];

src/Type/Definition/ValidatedFieldDefinition.php

Doc Comments +1 added lines, -1 removed lines

@@ -183,7 +183,7 @@
     }
 
     /**
-     * @return mixed|string|string[]|null
+     * @return string
      *
      * @throws ReflectionException
      */

Spacing +14 added lines, -14 removed lines

@@ -24,7 +24,7 @@ 
     /**
      * @param mixed[] $config
      */
-    public function __construct(array $config)
+    public function __construct (array $config)
     {
         $args = $config['args'];
         $name = $config['name'] ?? lcfirst($this->tryInferName());
@@ -37,14 +37,14 @@ 
                 'result' => [
                     'type' => $config['type'],
                     'description' => 'The payload, if any',
-                    'resolve' => static function ($value) {
+                    'resolve' => static function($value) {
                         return $value['result'] ?? null;
                     },
                 ],
                 'valid' => [
                     'type' => Type::nonNull(Type::boolean()),
                     'description' => 'Whether all validation passed. True for yes, false for no.',
-                    'resolve' => static function ($value) {
+                    'resolve' => static function($value) {
                         return $value['valid'];
                     },
                 ],
@@ -61,17 +61,17 @@ 
             'type' => $type,
             'args' => $args,
             'name' => $name,
-            'resolve' => function ($value, $args1, $context, $info) use ($config, $args) {
+            'resolve' => function($value, $args1, $context, $info) use ($config, $args) {
                 // validate inputs
-                $config['type']  = new InputObjectType([
+                $config['type'] = new InputObjectType([
                     'name'=>'',
                     'fields' => $args,
                 ]);
                 $errors          = $this->_validate($config, $args1);
                 $result          = $errors;
-                $result['valid'] = ! $errors;
+                $result['valid'] = !$errors;
 
-                if (! isset($result['error']) && ! isset($result['suberrors'])) {
+                if (!isset($result['error']) && !isset($result['suberrors'])) {
                     $result['result'] = $config['resolve']($value, $args1, $context, $info);
                 }
 
@@ -83,12 +83,12 @@ 
     /**
      * @param   mixed[] $arr
      */
-    protected function _isAssoc(array $arr) : bool
+    protected function _isAssoc (array $arr) : bool
     {
         if ($arr === []) {
             return false;
         }
-        return array_keys($arr) !== range(0, count($arr) - 1);
+        return array_keys($arr) !== range(0, count($arr)-1);
     }
 
     /**
@@ -97,16 +97,16 @@ 
      *
      * @throws  ValidateItemsError
      */
-    protected function _validateItems(array $value, array $path, callable $validate) : void
+    protected function _validateItems (array $value, array $path, callable $validate) : void
     {
         foreach ($value as $idx => $subValue) {
-            if (is_array($subValue) && ! $this->_isAssoc($subValue)) {
+            if (is_array($subValue) && !$this->_isAssoc($subValue)) {
                 $path[count($path)-1] = $idx;
                 $newPath              = $path;
                 $newPath[]            = 0;
                 $this->_validateItems($subValue, $newPath, $validate);
             } else {
-                $path[count($path) - 1] = $idx;
+                $path[count($path)-1] = $idx;
                 $err                    = $validate($subValue);
 
                 if ($err) {
@@ -121,7 +121,7 @@ 
      * @param mixed $value
      * @return mixed[]
      */
-    protected function _validate(array $arg, $value) : array
+    protected function _validate (array $arg, $value) : array
     {
         $res = [];
 
@@ -189,7 +189,7 @@ 
      *
      * @throws ReflectionException
      */
-    protected function tryInferName()
+    protected function tryInferName ()
     {
         // If class is extended - infer name from className
         // QueryType -> Type

tests/Type/ValidatedFieldDefinition/InputObjectValidationTest.php

Unused Use Statements -1 removed lines

@@ -9,7 +9,6 @@
 use GraphQL\Type\Definition\InputObjectType;
 use GraphQL\Type\Definition\ObjectType;
 use GraphQL\Type\Definition\Type;
-use GraphQL\Type\Definition\UserErrorsType;
 use GraphQL\Type\Definition\ValidatedFieldDefinition;
 use GraphQL\Type\Schema;
 use PHPUnit\Framework\TestCase;

Spacing +12 added lines, -12 removed lines

@@ -41,7 +41,7 @@ 
     /** @var Schema */
     protected $schema;
 
-    protected function setUp(): void
+    protected function setUp (): void
     {
         $this->personType = new ObjectType([
             'name' => 'Person',
@@ -61,7 +61,7 @@ 
                 'title' => [
                     'type' => Type::string(),
                     'description' => 'Enter a book title, no more than 10 characters in length',
-                    'validate' => static function (string $title) {
+                    'validate' => static function(string $title) {
                         if (strlen($title) > 10) {
                             return [1, 'book title must be less than 10 chaacters'];
                         }
@@ -75,8 +75,8 @@ 
                         'unknownAuthor',
                         'authorDeceased',
                     ],
-                    'validate' => function (string $authorId) {
-                        if (! isset($this->data['people'][$authorId])) {
+                    'validate' => function(string $authorId) {
+                        if (!isset($this->data['people'][$authorId])) {
                             return ['unknownAuthor', 'We have no record of that author'];
                         }
                         return 0;
@@ -91,7 +91,7 @@ 
             'query' => $this->query,
             'mutation' => new ObjectType([
                 'name' => 'Mutation',
-                'fields' => function () {
+                'fields' => function() {
                     return [
                         'updateBook' => new ValidatedFieldDefinition([
                             'name' => 'updateBook',
@@ -100,7 +100,7 @@ 
                                 'bookAttributes' => [
                                     'type' => $this->bookAttributesInputType,
                                     'errorCodes' => ['titleOrIdRequired'],
-                                    'validate' => static function (?array $bookAttributes) {
+                                    'validate' => static function(?array $bookAttributes) {
                                         if (empty($bookAttributes)) {
                                             return 0;
                                         }
@@ -112,12 +112,12 @@ 
                                     },
                                 ],
                             ],
-                            'resolve' => static function ($value) : bool {
+                            'resolve' => static function($value) : bool {
                                 // ...
                                 // do update
                                 // ...
 
-                                return ! $value;
+                                return !$value;
                             },
                         ]),
                     ];
@@ -126,7 +126,7 @@ 
         ]);
     }
 
-    public function testValidationInputObjectFieldFail(): void
+    public function testValidationInputObjectFieldFail (): void
     {
         $res = GraphQL::executeQuery(
             $this->schema,
@@ -196,7 +196,7 @@ 
         static::assertFalse($res->data['updateBook']['valid']);
     }
 
-    public function testValidationInputObjectSelfFail(): void
+    public function testValidationInputObjectSelfFail (): void
     {
         $res = GraphQL::executeQuery(
             $this->schema,
@@ -258,7 +258,7 @@ 
         static::assertFalse($res->data['updateBook']['valid']);
     }
 
-    public function testValidationSuccess(): void
+    public function testValidationSuccess (): void
     {
         $res = GraphQL::executeQuery(
             $this->schema,
@@ -311,7 +311,7 @@ 
         static::assertTrue($res->data['updateBook']['valid']);
     }
 
-    public function testValidationEmptyInput(): void
+    public function testValidationEmptyInput (): void
     {
         $res = GraphQL::executeQuery(
             $this->schema,

tests/Type/ErrorCodeTypeGenerationTest.php

Spacing +8 added lines, -8 removed lines

@@ -15,18 +15,18 @@ 
 
 final class ErrorCodeTypeGenerationTest extends TestCase
 {
-    public function testMultipleErrorCodesOnSelf(): void
+    public function testMultipleErrorCodesOnSelf (): void
     {
         $types = [];
         new UserErrorsType([
-            'validate' => static function ($val) {
+            'validate' => static function($val) {
                 return $val ? 0 : 1;
             },
             'errorCodes' => [
                 'unknownUser',
                 'userIsMinor',
             ],
-            'typeSetter' => static function ($type) use (&$types): void {
+            'typeSetter' => static function($type) use (&$types): void {
                 $types[$type->name] = $type;
             },
             'type' => new IDType(['name' => 'User']),
@@ -46,7 +46,7 @@ 
         );
     }
 
-    public function testFieldsWithNoErrorCodes(): void
+    public function testFieldsWithNoErrorCodes (): void
     {
         $types = [];
         $type  = new UserErrorsType([
@@ -59,7 +59,7 @@ 
                     ],
                 ],
             ]),
-            'typeSetter' => static function ($type) use (&$types): void {
+            'typeSetter' => static function($type) use (&$types): void {
                 $types[$type->name] = $type;
             },
         ], ['updateBook']);
@@ -73,7 +73,7 @@ 
         '));
     }
 
-    public function testFieldsWithErrorCodes(): void
+    public function testFieldsWithErrorCodes (): void
     {
         $types = [];
         new UserErrorsType([
@@ -81,7 +81,7 @@ 
                 'name' => 'bookInput',
                 'fields' => [
                     'authorId' => [
-                        'validate' => static function ($authorId) {
+                        'validate' => static function($authorId) {
                             return $authorId ? 0 : 1;
                         },
                         'errorCodes' => ['unknownAuthor'],
@@ -90,7 +90,7 @@ 
                     ],
                 ],
             ]),
-            'typeSetter' => static function ($type) use (&$types): void {
+            'typeSetter' => static function($type) use (&$types): void {
                 $types[$type->name] = $type;
             },
         ], ['updateBook']);

tests/Type/UserErrorsType/ListOfTest.php

Spacing +12 added lines, -12 removed lines

@@ -15,7 +15,7 @@ 
 
 final class ListOfTest extends TestCase
 {
-    public function testScalarTypeWithNoValidation(): void
+    public function testScalarTypeWithNoValidation (): void
     {
         $type = new UserErrorsType([
             'type' => Type::listOf(Type::id()),
@@ -34,12 +34,12 @@ 
         '), SchemaPrinter::doPrint(new Schema(['query' => $type])));
     }
 
-    public function testListOfScalarWithValidationOnSelf(): void
+    public function testListOfScalarWithValidationOnSelf (): void
     {
         $type = new UserErrorsType([
             'type' => Type::listOf(Type::id()),
             'errorCodes'=> ['atLeastOneRequired'],
-            'validate' => static function ($value) {
+            'validate' => static function($value) {
                 return $value ? 0 : 1;
             },
         ], ['users']);
@@ -66,15 +66,15 @@ 
         '), SchemaPrinter::doPrint(new Schema(['query' => $type])));
     }
 
-    public function testListOfListOfListOfScalarWithValidationOnSelfAndWrappedType(): void
+    public function testListOfListOfListOfScalarWithValidationOnSelfAndWrappedType (): void
     {
         $type = new UserErrorsType([
             'type' => Type::listOf(Type::listOf(Type::listOf(Type::id()))),
             'errorCodes'=> ['atLeastOneRequired'],
-            'validate' => static function ($value) {
+            'validate' => static function($value) {
                 return $value ? 0 : 1;
             },
-            'validateItem' => static function ($value) {
+            'validateItem' => static function($value) {
                 return $value ? 0 : 1;
             },
         ], ['users']);
@@ -116,10 +116,10 @@ 
         '), SchemaPrinter::doPrint(new Schema(['query' => $type])));
     }
 
-    public function testListOfInputObjectWithValidationOnSelf(): void
+    public function testListOfInputObjectWithValidationOnSelf (): void
     {
         $type = new UserErrorsType([
-            'validate' => static function (array $authors) {
+            'validate' => static function(array $authors) {
                 if (count($authors) < 1) {
                     return ['atLeastOneAuthorRequired', 'You must submit at least one author'];
                 }
@@ -160,12 +160,12 @@ 
         '), SchemaPrinter::doPrint(new Schema(['query' => $type])));
     }
 
-    public function testListOfInputObjectWithValidationOnWrappedSelf(): void
+    public function testListOfInputObjectWithValidationOnWrappedSelf (): void
     {
         $type = new UserErrorsType([
             'suberrorCodes' => ['firstNameOrLastNameRequired'],
-            'validateItem' => static function (array $author) {
-                if (! isset($author['firstName']) && ! isset($author['lastName'])) {
+            'validateItem' => static function(array $author) {
+                if (!isset($author['firstName']) && !isset($author['lastName'])) {
                     return ['atLeastOneAuthorRequired', 'You must submit a first name or a last name'];
                 }
             },
@@ -174,7 +174,7 @@ 
                 'fields' => [
                     'firstName' => [
                         'type' => Type::string(),
-                        'validate' => static function (string $name) {
+                        'validate' => static function(string $name) {
                             return $name ? 0 : 1;
                         },
                     ],

tests/Type/UserErrorsType/ScalarTest.php

Spacing +3 added lines, -3 removed lines

@@ -14,7 +14,7 @@ 
 
 final class ScalarTest extends TestCase
 {
-    public function testNoValidation(): void
+    public function testNoValidation (): void
     {
         $type = new UserErrorsType([
             'type' => Type::id(),
@@ -33,11 +33,11 @@ 
         '), SchemaPrinter::doPrint(new Schema(['query' => $type])));
     }
 
-    public function testWithValidation(): void
+    public function testWithValidation (): void
     {
         $type = new UserErrorsType([
             'errorCodes' => ['invalidColor'],
-            'validate' => static function ($value) {
+            'validate' => static function($value) {
                 return $value ? 0 : 1;
             },
             'type' => new IDType(['name' => 'Color']),

tests/Type/UserErrorsType/BasicTest.php

Spacing +5 added lines, -5 removed lines

@@ -13,7 +13,7 @@ 
 
 final class BasicTest extends TestCase
 {
-    public function testNoValidationOnSelf(): void
+    public function testNoValidationOnSelf (): void
     {
         $type = new UserErrorsType([
             'type' => Type::id(),
@@ -32,20 +32,20 @@ 
         '), SchemaPrinter::doPrint(new Schema(['query' => $type])));
     }
 
-    public function testNoType(): void
+    public function testNoType (): void
     {
         $this->expectExceptionMessage('You must specify a type for your field');
         UserErrorsType::create([
-            'validate' => static function ($value) {
+            'validate' => static function($value) {
                 return $value ? 0 : 1;
             },
         ], ['upsertSku']);
     }
 
-    public function testValidationWithNoErrorCodes(): void
+    public function testValidationWithNoErrorCodes (): void
     {
         $type = UserErrorsType::create([
-            'validate' => static function ($value) {
+            'validate' => static function($value) {
                 return $value ? 0 : 1;
             },
             'type' => Type::id(),

tests/Type/UserErrorsType/InputObjectTest.php

Spacing +4 added lines, -4 removed lines

@@ -15,7 +15,7 @@ 
 
 final class InputObjectTest extends TestCase
 {
-    public function testFieldsWithNoErrorCodes(): void
+    public function testFieldsWithNoErrorCodes (): void
     {
         $type = new UserErrorsType([
             'type' => new InputObjectType([
@@ -45,7 +45,7 @@ 
         );
     }
 
-    public function testFieldsWithErrorCodesButNoValidate(): void
+    public function testFieldsWithErrorCodesButNoValidate (): void
     {
         $this->expectExceptionMessage('If you specify errorCodes, you must also provide a validate callback');
 
@@ -63,7 +63,7 @@ 
         ], ['updateBook']);
     }
 
-    public function testFieldsWithValidate(): void
+    public function testFieldsWithValidate (): void
     {
         $type = new UserErrorsType([
             'type' => new InputObjectType([
@@ -71,7 +71,7 @@ 
                 'fields' => [
                     'authorId' => [
                         'errorCodes' => ['unknownAuthor'],
-                        'validate' => static function (int $authorId) {
+                        'validate' => static function(int $authorId) {
                             return $authorId ? 0 : 1;
                         },
                         'type' => Type::id(),

tests/Type/ValidatedFieldDefinition/NonNullScalarValidationTest.php

Spacing +8 added lines, -8 removed lines

@@ -36,7 +36,7 @@ 
     /** @var Schema */
     protected $schema;
 
-    protected function setUp(): void
+    protected function setUp (): void
     {
         $this->personType = new ObjectType([
             'name' => 'Person',
@@ -55,13 +55,13 @@ 
             'fields' => [
                 'title' => [
                     'type' => Type::string(),
-                    'resolve' => static function ($book) {
+                    'resolve' => static function($book) {
                         return $book['title'];
                     },
                 ],
                 'author' => [
                     'type' => $this->personType,
-                    'resolve' => static function ($book) {
+                    'resolve' => static function($book) {
                         return $book['author'];
                     },
                 ],
@@ -71,7 +71,7 @@ 
         $this->schema = new Schema([
             'mutation' => new ObjectType([
                 'name' => 'Mutation',
-                'fields' => function () {
+                'fields' => function() {
                     return [
                         'updateBook' => new ValidatedFieldDefinition([
                             'name' => 'updateBook',
@@ -80,7 +80,7 @@ 
                                 'bookId' => [
                                     'type' => Type::nonNull(Type::id()),
                                     'errorCodes' => ['bookNotFound'],
-                                    'validate' => function ($bookId) {
+                                    'validate' => function($bookId) {
                                         if (isset($this->data['books'][$bookId])) {
                                             return 0;
                                         }
@@ -89,7 +89,7 @@ 
                                     },
                                 ],
                             ],
-                            'resolve' => function ($value, $args) : array {
+                            'resolve' => function($value, $args) : array {
                                 return $this->data['books'][$args['bookId']];
                             },
                         ]),
@@ -99,7 +99,7 @@ 
         ]);
     }
 
-    public function testNonNullScalarValidationSuccess(): void
+    public function testNonNullScalarValidationSuccess (): void
     {
         $res = GraphQL::executeQuery(
             $this->schema,
@@ -129,7 +129,7 @@ 
         static::assertTrue($res->data['updateBook']['valid']);
     }
 
-    public function testNonNullScalarValidationFail() : void
+    public function testNonNullScalarValidationFail () : void
     {
         $res = GraphQL::executeQuery(
             $this->schema,