View GitHub Repository shlink

Schedule Inspection
Subscribe
Completed
Pull Request — master (#647)
by Alejandro
04:12
created

1,987 +80 Covered Lines

2,059 +89 Total Lines

96.5 % -0.3% Code Coverage

PHP Classes Changes

 
 ⇢
60%
ShortUrlsOrdering added
 
 ⇢
96.3%
ShortUrlsParams added
 
 ⇢
100%
ShortUrlIdentifier added
 
 ⇢
100%
DropDefaultDomainFromQueryMiddleware added
 
 ⇢
100%
ShortUrlsParamsInputFilter added
100%
 ↘
66.67%
 Domain got worse
94.74%
 ↗
100%
 VisitsTracker improved
97.92%
 ↗
100%
 ShortUrlMeta improved
84.62%
 ↘
83.33%
 ResolveUrlCommand got worse
95.65%
 ↘
94.74%
 VisitsParams got worse
86.67%
 ↗
87.1%
 GetVisitsCommand improved
95.45%
 ↘
95.24%
 QrCodeAction got worse
98.67%
 ↗
98.8%
 ShortUrlRepository improved
96.34%
 ↗
96.43%
 ShortUrl improved
98.68%
 ↗
98.75%
 ListShortUrlsCommand improved
100%
 ↛
 
 FindShortCodeTrait removed

CRAP Changes

 
 ⇢
7.392
ShortUrlsOrdering::validateAndInit() added
 
 ⇢
3
ShortUrlResolver::resolveEnabledShortUrl() added
 
 ⇢
3
DropDefaultDomainFromQueryMiddleware::process() added
 
 ⇢
3
ShortUrlMeta::validateAndInit() added
 
 ⇢
3
ShortUrlNotFoundException::fromNotFound() added
 
 ⇢
2.003
ShortUrlsParams::validateAndInit() added
 
 ⇢
2
ShortUrlResolver::resolveShortUrl() added
 
 ⇢
2
ShortUrlsParams::__construct() added
 
 ⇢
2
ShortUrlsOrdering::orderField() added
 
 ⇢
2
ShortUrlsOrdering::orderDirection() added
⋮ view more  
4.0027
 ↗
4.0039
 ListShortUrlsCommand::renderPage() got worse
8.006
 ↘
8.0046
 ShortUrlRepository::createListQueryBuilder() improved
2.0054
 ↘
2
 VisitsTracker::info() improved
4.074
 ↛
 
 ShortUrlMeta::parseDateField() removed
3
 ↛
 
 ListShortUrlsAction::determineDateRangeFromQuery() removed
3
 ↛
 
 ShortUrlMeta::validate() removed
3
 ↛
 
 ShortUrlNotFoundException::fromNotFoundShortCode() removed
3
 ↛
 
 VisitsParams::getDateQueryParam() removed
2
 ↛
 
 ShortUrlResolver::shortCodeToShortUrl() removed
2
 ↛
 
 ShortUrlResolver::shortCodeToEnabledShortUrl() removed
2
 ↛
 
 ShortUrlRepository::findOneByShortCode() removed
2
 ↛
 
 FindShortCodeTrait::findByShortCode() removed
1
 ↛
 
 ListShortUrlsAction::queryToListParams() removed