Completed
Pull Request — master (#243)
by Alejandro
01:35
created
module/Core/src/Action/PreviewAction.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -52,7 +52,7 @@
 block discarded – undo
52 52
      * @param Request $request
53 53
      * @param RequestHandlerInterface $handler
54 54
      *
55
-     * @return Response
55
+     * @return string|null
56 56
      */
57 57
     public function process(Request $request, RequestHandlerInterface $handler): Response
58 58
     {
Please login to merge, or discard this patch.
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -13,8 +13,6 @@
 block discarded – undo
13 13
 use Shlinkio\Shlink\Common\Service\PreviewGeneratorInterface;
14 14
 use Shlinkio\Shlink\Common\Util\ResponseUtilsTrait;
15 15
 use Shlinkio\Shlink\Core\Action\Util\ErrorResponseBuilderTrait;
16
-use Shlinkio\Shlink\Core\Exception\EntityDoesNotExistException;
17
-use Shlinkio\Shlink\Core\Exception\InvalidShortCodeException;
18 16
 use Shlinkio\Shlink\Core\Service\UrlShortenerInterface;
19 17
 
20 18
 class PreviewAction implements MiddlewareInterface
Please login to merge, or discard this patch.
module/Core/src/Action/QrCodeAction.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -13,7 +13,6 @@
 block discarded – undo
13 13
 use Shlinkio\Shlink\Common\Response\QrCodeResponse;
14 14
 use Shlinkio\Shlink\Core\Action\Util\ErrorResponseBuilderTrait;
15 15
 use Shlinkio\Shlink\Core\Exception\EntityDoesNotExistException;
16
-use Shlinkio\Shlink\Core\Exception\InvalidShortCodeException;
17 16
 use Shlinkio\Shlink\Core\Service\UrlShortenerInterface;
18 17
 use Zend\Expressive\Router\Exception\RuntimeException;
19 18
 use Zend\Expressive\Router\RouterInterface;
Please login to merge, or discard this patch.
module/Rest/src/Action/ShortUrl/ListShortUrlsAction.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -57,7 +57,7 @@
 block discarded – undo
57 57
 
58 58
     /**
59 59
      * @param array $query
60
-     * @return array
60
+     * @return integer
61 61
      */
62 62
     private function queryToListParams(array $query): array
63 63
     {
Please login to merge, or discard this patch.
module/Rest/src/Middleware/AuthenticationMiddleware.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -5,7 +5,6 @@
 block discarded – undo
5 5
 
6 6
 use Fig\Http\Message\RequestMethodInterface;
7 7
 use Fig\Http\Message\StatusCodeInterface;
8
-use Psr\Container\ContainerExceptionInterface;
9 8
 use Psr\Http\Message\ResponseInterface as Response;
10 9
 use Psr\Http\Message\ServerRequestInterface as Request;
11 10
 use Psr\Http\Server\MiddlewareInterface;
Please login to merge, or discard this patch.
module/Core/src/Service/UrlShortener.php 1 patch
Doc Comments   +4 added lines patch added patch discarded remove patch
@@ -47,6 +47,9 @@  discard block
 block discarded – undo
47 47
      */
48 48
     private $urlValidationEnabled;
49 49
 
50
+    /**
51
+     * @param boolean $urlValidationEnabled
52
+     */
50 53
     public function __construct(
51 54
         ClientInterface $httpClient,
52 55
         EntityManagerInterface $em,
@@ -65,6 +68,7 @@  discard block
 block discarded – undo
65 68
      * @throws NonUniqueSlugException
66 69
      * @throws InvalidUrlException
67 70
      * @throws RuntimeException
71
+     * @param string $customSlug
68 72
      */
69 73
     public function urlToShortCode(
70 74
         UriInterface $url,
Please login to merge, or discard this patch.
module/Core/src/Model/ShortUrlMeta.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -49,7 +49,7 @@
 block discarded – undo
49 49
      * @param string|Chronos|null $validUntil
50 50
      * @param string|null $customSlug
51 51
      * @param int|null $maxVisits
52
-     * @return ShortUrlMeta
52
+     * @return ShortUrlMeta|null
53 53
      * @throws ValidationException
54 54
      */
55 55
     public static function createFromParams(
Please login to merge, or discard this patch.
module/Core/src/Action/AbstractTrackingAction.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -11,7 +11,6 @@
 block discarded – undo
11 11
 use Psr\Log\NullLogger;
12 12
 use Shlinkio\Shlink\Core\Action\Util\ErrorResponseBuilderTrait;
13 13
 use Shlinkio\Shlink\Core\Exception\EntityDoesNotExistException;
14
-use Shlinkio\Shlink\Core\Exception\InvalidShortCodeException;
15 14
 use Shlinkio\Shlink\Core\Model\Visitor;
16 15
 use Shlinkio\Shlink\Core\Options\AppOptions;
17 16
 use Shlinkio\Shlink\Core\Service\UrlShortenerInterface;
Please login to merge, or discard this patch.