View GitHub Repository shlink

Schedule Inspection
Subscribe
Completed
Pull Request — master (#554)
by Alejandro
14:05
created

2,105 -65 Covered Lines

2,182 -63 Total Lines

96.5 % -0.188% Code Coverage

PHP Classes Changes

 
 ⇢
92.59%
BackwardsCompatibleProblemDetailsMiddleware added
 
 ⇢
100%
NotFoundTemplateHandler added
 
 ⇢
100%
NotFoundRedirectHandler added
 
 ⇢
100%
ShortUrlNotFoundException added
 
 ⇢
100%
TagNotFoundException added
100%
 ↘
87.5%
 RestUtils got worse
92.73%
 ↗
96.23%
 UrlShortener improved
86.67%
 ↘
85.19%
 ResolveUrlCommand got worse
100%
 ↛
 
 HealthActionFactory removed
100%
 ↛
 
 EntityDoesNotExistException removed
100%
 ↛
 
 JsonErrorResponseGenerator removed
100%
 ↛
 
 InvalidShortCodeException removed
100%
 ↛
 
 NotFoundHandler removed

CRAP Changes

 
 ⇢
9
NotFoundRedirectHandler::createRedirectResponse() added
 
 ⇢
4.074
BackwardsCompatibleProblemDetailsMiddleware::proce... added
 
 ⇢
2
BackwardsCompatibleProblemDetailsMiddleware::isVer... added
 
 ⇢
2
BackwardsCompatibleProblemDetailsMiddleware::mapSt... added
 
 ⇢
2
ValidationException::invalidElementsToString() added
 
 ⇢
2
ShortUrlNotFoundException::fromNotFoundShortCode() added
 
 ⇢
2
NotFoundTemplateHandler::handle() added
 
 ⇢
1
BackwardsCompatibleProblemDetailsMiddleware::__con... added
 
 ⇢
1
BackwardsCompatibleProblemDetailsMiddleware::makeP... added
 
 ⇢
1
ValidationException::__toString() added
⋮ view more  
9
 ↗
9.1582
 RestUtils::getRestErrorCodeFromException() got worse
2.2109
 ↘
2.0185
 UrlShortener::shortCodeToUrl() improved
9
 ↛
 
 NotFoundHandler::createRedirectResponse() removed
4
 ↛
 
 NotFoundHandler::handle() removed
3
 ↛
 
 JsonErrorResponseGenerator::__invoke() removed
2
 ↛
 
 InvalidShortCodeException::fromCharset() removed
2
 ↛
 
 ValidationException::formMessagesToString() removed
2
 ↛
 
 EntityDoesNotExistException::serializeParams() removed
1
 ↛
 
 InvalidShortCodeException::fromNotFoundShortCode() removed
1
 ↛
 
 NotFoundHandler::__construct() removed
1
 ↛
 
 JsonErrorResponseGenerator::responsePhraseToCode() removed
1
 ↛
 
 HealthActionFactory::__invoke() removed
⋮ view more