shlinkio / shlink

Passed

Pull Request — master (#506)

by Alejandro

created 2019-10-11 09:29 UTC

Changes

	3 issues (3 minor) were introduced. 1 issue was fixed.
	14 added classes/operations
		A	ShortUrlRepositoryTest::shortCodeIsInUseLooksForShortUrlInProperSetOfT... added
		A	UrlShortener::verifyShortCodeUniqueness() added
		A	generateRandomShortCode() added
		A	UrlShortenerTest::shortCodeIsRegeneratedIfAlreadyInUse() added
		A	UrlShortenerTest::transactionIsRolledBackAndExceptionRethrownWhenExcep... added
		A	ShortCodeCannotBeRegeneratedException::forShortUrlAlreadyPersisted() added
		A	ShortCodeCannotBeRegeneratedException::forShortUrlWithCustomSlug() added
		A	ShortUrlTest::regenerateShortCodeProperlyChangesTheValueOnValidShortUr... added
		A	ShortUrlTest::regenerateShortCodeThrowsExceptionIfStateIsInvalid() added
		A	ShortUrlTest::provideInvalidShortUrls() added
B	↗	A	UrlShortener::urlToShortCode() improved
view all

9.96

▶ ± 0

Test Coverage

97%

▶ ±0%

Head	Alejandro Celaya 2019-10-11 11:29 GMT+0200 Merge 5bd7b53e0acfd26b20b2df44aae2d8b4638db308 into c8d950e04d6f867fda077256639795708b5b99fc
⋮	4 more commits
Base	Alejandro Celaya 2019-10-06 10:37 UTC Merge pull request #504 from acelaya-forks/feature/mariadb