Completed
Pull Request — master (#209)
by Alejandro
04:24
created
module/Core/src/Service/UrlShortener.php 1 patch
Doc Comments   +6 added lines patch added patch discarded remove patch
@@ -51,6 +51,9 @@  discard block
 block discarded – undo
51 51
      */
52 52
     private $urlValidationEnabled;
53 53
 
54
+    /**
55
+     * @param boolean $urlValidationEnabled
56
+     */
54 57
     public function __construct(
55 58
         ClientInterface $httpClient,
56 59
         EntityManagerInterface $em,
@@ -173,6 +176,9 @@  discard block
 block discarded – undo
173 176
         return $this->chars[(int) $id] . $code;
174 177
     }
175 178
 
179
+    /**
180
+     * @param null|string $customSlug
181
+     */
176 182
     private function processCustomSlug($customSlug)
177 183
     {
178 184
         if ($customSlug === null) {
Please login to merge, or discard this patch.
module/Core/src/Model/CreateShortCodeData.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -39,7 +39,7 @@
 block discarded – undo
39 39
     }
40 40
 
41 41
     /**
42
-     * @return array
42
+     * @return string[]
43 43
      */
44 44
     public function getTags(): array
45 45
     {
Please login to merge, or discard this patch.
module/Rest/src/Action/ShortCode/ListShortCodesAction.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -57,7 +57,7 @@
 block discarded – undo
57 57
 
58 58
     /**
59 59
      * @param array $query
60
-     * @return array
60
+     * @return integer
61 61
      */
62 62
     private function queryToListParams(array $query): array
63 63
     {
Please login to merge, or discard this patch.
module/Core/src/Action/AbstractTrackingAction.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -11,7 +11,6 @@
 block discarded – undo
11 11
 use Psr\Log\NullLogger;
12 12
 use Shlinkio\Shlink\Core\Action\Util\ErrorResponseBuilderTrait;
13 13
 use Shlinkio\Shlink\Core\Exception\EntityDoesNotExistException;
14
-use Shlinkio\Shlink\Core\Exception\InvalidShortCodeException;
15 14
 use Shlinkio\Shlink\Core\Options\AppOptions;
16 15
 use Shlinkio\Shlink\Core\Service\UrlShortenerInterface;
17 16
 use Shlinkio\Shlink\Core\Service\VisitsTrackerInterface;
Please login to merge, or discard this patch.
module/Core/src/Action/PreviewAction.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -52,7 +52,7 @@
 block discarded – undo
52 52
      * @param Request $request
53 53
      * @param RequestHandlerInterface $handler
54 54
      *
55
-     * @return Response
55
+     * @return string|null
56 56
      */
57 57
     public function process(Request $request, RequestHandlerInterface $handler): Response
58 58
     {
Please login to merge, or discard this patch.
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -13,8 +13,6 @@
 block discarded – undo
13 13
 use Shlinkio\Shlink\Common\Service\PreviewGeneratorInterface;
14 14
 use Shlinkio\Shlink\Common\Util\ResponseUtilsTrait;
15 15
 use Shlinkio\Shlink\Core\Action\Util\ErrorResponseBuilderTrait;
16
-use Shlinkio\Shlink\Core\Exception\EntityDoesNotExistException;
17
-use Shlinkio\Shlink\Core\Exception\InvalidShortCodeException;
18 16
 use Shlinkio\Shlink\Core\Service\UrlShortenerInterface;
19 17
 
20 18
 class PreviewAction implements MiddlewareInterface
Please login to merge, or discard this patch.
module/Core/src/Action/QrCodeAction.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -13,7 +13,6 @@
 block discarded – undo
13 13
 use Shlinkio\Shlink\Common\Response\QrCodeResponse;
14 14
 use Shlinkio\Shlink\Core\Action\Util\ErrorResponseBuilderTrait;
15 15
 use Shlinkio\Shlink\Core\Exception\EntityDoesNotExistException;
16
-use Shlinkio\Shlink\Core\Exception\InvalidShortCodeException;
17 16
 use Shlinkio\Shlink\Core\Service\UrlShortenerInterface;
18 17
 use Zend\Expressive\Router\Exception\RuntimeException;
19 18
 use Zend\Expressive\Router\RouterInterface;
Please login to merge, or discard this patch.
module/Core/src/Entity/ShortUrl.php 1 patch
Doc Comments   +9 added lines patch added patch discarded remove patch
@@ -156,6 +156,9 @@  discard block
 block discarded – undo
156 156
         return $this->validSince;
157 157
     }
158 158
 
159
+    /**
160
+     * @param \DateTime|null $validSince
161
+     */
159 162
     public function setValidSince(?\DateTime $validSince): self
160 163
     {
161 164
         $this->validSince = $validSince;
@@ -167,6 +170,9 @@  discard block
 block discarded – undo
167 170
         return $this->validUntil;
168 171
     }
169 172
 
173
+    /**
174
+     * @param \DateTime|null $validUntil
175
+     */
170 176
     public function setValidUntil(?\DateTime $validUntil): self
171 177
     {
172 178
         $this->validUntil = $validUntil;
@@ -194,6 +200,9 @@  discard block
 block discarded – undo
194 200
         return $this->maxVisits;
195 201
     }
196 202
 
203
+    /**
204
+     * @param integer|null $maxVisits
205
+     */
197 206
     public function setMaxVisits(?int $maxVisits): self
198 207
     {
199 208
         $this->maxVisits = $maxVisits;
Please login to merge, or discard this patch.