Passed
Branch dev (7cf5cf)
by
unknown
02:40
created
src/lib/eveApi.php 2 patches
Doc Comments   +12 added lines, -1 removed lines patch added patch discarded remove patch
@@ -28,7 +28,7 @@  discard block
 block discarded – undo
28 28
 
29 29
 /**
30 30
  * @param $url
31
- * @return SimpleXMLElement|null|string
31
+ * @return SimpleXMLElement|null
32 32
  */
33 33
 function makeApiRequest($url)
34 34
 {
@@ -117,6 +117,11 @@  discard block
 block discarded – undo
117 117
  * @return mixed
118 118
  */
119 119
 ////Character name to ID
120
+/**
121
+ * @param string $characterName
122
+ *
123
+ * @return string
124
+ */
120 125
 function characterID($characterName)
121 126
 {
122 127
     $logger = new Logger('eveESI');
@@ -197,6 +202,9 @@  discard block
 block discarded – undo
197 202
  * @return mixed
198 203
  */
199 204
 ////Corp name to ID
205
+/**
206
+ * @param string $corpName
207
+ */
200 208
 function corpID($corpName)
201 209
 {
202 210
     $logger = new Logger('eveESI');
@@ -364,6 +372,9 @@  discard block
 block discarded – undo
364 372
 }
365 373
 
366 374
 ////Char/Object ID to name via CCP
375
+/**
376
+ * @param string $moonID
377
+ */
367 378
 function apiMoonName($moonID)
368 379
 {
369 380
     $url = "https://api.eveonline.com/eve/CharacterName.xml.aspx?IDs={$moonID}";
Please login to merge, or discard this patch.
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -101,7 +101,7 @@  discard block
 block discarded – undo
101 101
 function characterName($characterID)
102 102
 {
103 103
     $character = characterDetails($characterID);
104
-    $name = (string)$character['name'];
104
+    $name = (string) $character['name'];
105 105
     if (null === $name || '' === $name) { // Make sure it's always set.
106 106
         $url = "https://api.eveonline.com/eve/CharacterName.xml.aspx?ids={$characterID}";
107 107
         $xml = makeApiRequest($url);
@@ -127,7 +127,7 @@  discard block
 block discarded – undo
127 127
     try {
128 128
         $json = file_get_contents($url);
129 129
         $data = json_decode($json, TRUE);
130
-        $id = (int)$data['character'][0];
130
+        $id = (int) $data['character'][0];
131 131
 
132 132
     } catch (Exception $e) {
133 133
         $logger->error('EVE ESI Error: ' . $e->getMessage());
@@ -178,7 +178,7 @@  discard block
 block discarded – undo
178 178
     try {
179 179
         $json = file_get_contents($url);
180 180
         $data = json_decode($json, TRUE);
181
-        $name = (string)$data['solar_system_name'];
181
+        $name = (string) $data['solar_system_name'];
182 182
 
183 183
     } catch (Exception $e) {
184 184
         $logger->error('EVE ESI Error: ' . $e->getMessage());
@@ -207,7 +207,7 @@  discard block
 block discarded – undo
207 207
     try {
208 208
         $json = file_get_contents($url);
209 209
         $data = json_decode($json, TRUE);
210
-        $id = (int)$data['corporation'][0];
210
+        $id = (int) $data['corporation'][0];
211 211
 
212 212
     } catch (Exception $e) {
213 213
         $logger->error('EVE ESI Error: ' . $e->getMessage());
@@ -230,7 +230,7 @@  discard block
 block discarded – undo
230 230
 function corpName($corpID)
231 231
 {
232 232
     $corporation = corpDetails($corpID);
233
-    $name = (string)$corporation['corporation_name'];
233
+    $name = (string) $corporation['corporation_name'];
234 234
     if (null === $name || '' === $name) { // Make sure it's always set.
235 235
         $url = "https://api.eveonline.com/eve/CharacterName.xml.aspx?ids={$corpID}";
236 236
         $xml = makeApiRequest($url);
@@ -277,7 +277,7 @@  discard block
 block discarded – undo
277 277
     try {
278 278
         $json = file_get_contents($url);
279 279
         $data = json_decode($json, TRUE);
280
-        $name = (string)$data['alliance_name'];
280
+        $name = (string) $data['alliance_name'];
281 281
 
282 282
     } catch (Exception $e) {
283 283
         $url = "https://api.eveonline.com/eve/CharacterName.xml.aspx?ids={$allianceID}";
@@ -303,7 +303,7 @@  discard block
 block discarded – undo
303 303
     try {
304 304
         $json = file_get_contents($url);
305 305
         $data = json_decode($json, TRUE);
306
-        $id = (int)$data['solarsystem'][0];
306
+        $id = (int) $data['solarsystem'][0];
307 307
 
308 308
     } catch (Exception $e) {
309 309
         $logger->error('EVE ESI Error: ' . $e->getMessage());
@@ -329,7 +329,7 @@  discard block
 block discarded – undo
329 329
     try {
330 330
         $json = file_get_contents($url);
331 331
         $data = json_decode($json, TRUE);
332
-        $name = (string)$data['type_name'];
332
+        $name = (string) $data['type_name'];
333 333
 
334 334
     } catch (Exception $e) {
335 335
         $logger->error('EVE ESI Error: ' . $e->getMessage());
@@ -354,7 +354,7 @@  discard block
 block discarded – undo
354 354
     $url = "https://www.fuzzwork.co.uk/api/typeid.php?typename={$typeName}";
355 355
     $json = file_get_contents($url);
356 356
     $data = json_decode($json, TRUE);
357
-    $id = (int)$data['typeID'];
357
+    $id = (int) $data['typeID'];
358 358
 
359 359
     if (null === $id) { // Make sure it's always set.
360 360
         $id = 'Unknown';
Please login to merge, or discard this patch.