Issues in CalcSet.php (master) - Issues in master - sergej-kurakin/dicecalc - Measure and Improve Code Quality continuously with Scrutinizer

Issues (16)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/DiceCalc/CalcSet.php (9 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace DiceCalc;

/**
 * Class CalcSet
 *
 * @package DiceCalc
 * @author  Owen Winkler <[email protected]>
 * @license MIT http://opensource.org/licenses/MIT
 */
class CalcSet {
    protected $values = [];
    protected $label;

    public function __construct($set_value) {
        if (is_array($set_value)) {
            $this->values       = $set_value;
            $this->saved_values = $this->values;

            $this->label        = '[' . implode(', ', $set_value) . ']';
        } else {
            $this->label = $set_value;
            preg_match('%^(?P<multiple>\d*)\[(?P<set>[^\]]+)\]$%i', $set_value, $matches);
            $set_value = $matches['set'];
            $values    = explode(',', $set_value);
            for ($z = 0; $z < max(1, intval($matches['multiple'])); $z ++) {
// count() is called on each iteration
for ($i=0; $i < count($collection); $i++) { }

// count() is only called once
for ($i=0, $c=count($collection); $i<$c; $i++) { }
                foreach ($values as $set_value) {
                    $this->values[] = $set_value;
                }
            }
            $this->saved_values = $this->values;

            foreach ($this->values as $k => $set_value) {
                $calc             = new Calc($set_value);
                $this->values[$k] = $calc();
            }
            foreach ($this->values as $k => $value) {
                $calc             = new Calc($value);
                $this->values[$k] = $calc();
            }
        }
    }

    public function __toString() {
        $out = [];
        foreach (array_keys($this->saved_values) as $key) {

            $vout = $this->values[$key];
            if (!isset($this->values[$key])) {
                $vout = $this->saved_values[$key];

            }
            if ($vout === true) {
                $vout = '<span class="true">true</span>';
            }
            if ($vout === false) {
                $vout = '<span class="false">false</span>';
            }
            if (isset($this->values[$key])) {
                $out[] = $vout;
            } else {
                $out[] = '<s>' . $vout . '</s>';
            }
        }
        $out = '[' . implode(', ', $out) . ']';

        return $out;
    }

    public function calc($operator, $operand) {

        $out = [];
        foreach ($this->values as $value) {
            $out[] = CalcOperation::calc($operator, $operand, $value);
        }

        return new CalcSet($out);
    }

    public function rcalc($operator, $operand) {

        $out = [];
        foreach ($this->values as $value) {
            $out[] = CalcOperation::calc($operator, $value, $operand);
        }

        return new CalcSet($out);
    }

    public function mcalc($operator, $operand)

    {
        $out = [];
        foreach ($this->values as $value) {
            $out[] = $operand->rcalc($operator, $value);
        }

        return new CalcSet($out);
    }

    public function value()
    {
        $allnumeric = true;
        foreach ($this->values as $v) {
            if (is_numeric($v)) {
if (rand(1, 6) > 3) {
//print "Check failed";
} else {
    print "Check succeeded";
}
            } else {
                $allnumeric = false;
            }
        }

        if ($allnumeric) {
            return array_sum($this->values);
        } else {
            return $this;
        }
    }
}


1		<?php
2
3		namespace DiceCalc;
4
5		/**
6		* Class CalcSet
7		*
8		* @package DiceCalc
9		* @author Owen Winkler <[email protected]>
10		* @license MIT http://opensource.org/licenses/MIT
11		*/
12		class CalcSet {
13		protected $values = [];
14		protected $label;
15
16		public function __construct($set_value) {
17		if (is_array($set_value)) {
18		$this->values = $set_value;
19		$this->saved_values = $this->values;
		0 ignored issues – show Bug introduced 2016-05-26 19:45 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `saved_values` does not seem to exist. Did you mean `values`? An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history...
20		$this->label = '[' . implode(', ', $set_value) . ']';
21		} else {
22		$this->label = $set_value;
23		preg_match('%^(?P<multiple>\d*)\[(?P<set>[^\]]+)\]$%i', $set_value, $matches);
24		$set_value = $matches['set'];
25		$values = explode(',', $set_value);
26		for ($z = 0; $z < max(1, intval($matches['multiple'])); $z ++) {
		0 ignored issues – show Performance Best Practice introduced 2016-05-26 19:45 UTC by Report Bug Copy Issue Report Show Similar Issues like this Consider avoiding function calls on each iteration of the `for` loop. If you have a function call in the test part of a `for` loop, this function is executed on each iteration. Often such a function, can be moved to the initialization part and be cached. // count() is called on each iteration for ($i=0; $i < count($collection); $i++) { } // count() is only called once for ($i=0, $c=count($collection); $i<$c; $i++) { } Loading history...
27		foreach ($values as $set_value) {
28		$this->values[] = $set_value;
29		}
30		}
31		$this->saved_values = $this->values;
		0 ignored issues – show Bug introduced 2016-05-26 19:45 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `saved_values` does not seem to exist. Did you mean `values`? An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history...
32		foreach ($this->values as $k => $set_value) {
33		$calc = new Calc($set_value);
34		$this->values[$k] = $calc();
35		}
36		foreach ($this->values as $k => $value) {
37		$calc = new Calc($value);
38		$this->values[$k] = $calc();
39		}
40		}
41		}
42
43		public function __toString() {
44		$out = [];
45		foreach (array_keys($this->saved_values) as $key) {
		0 ignored issues – show Bug introduced 2016-05-26 19:45 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `saved_values` does not seem to exist. Did you mean `values`? An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history...
46		$vout = $this->values[$key];
47		if (!isset($this->values[$key])) {
48		$vout = $this->saved_values[$key];
		0 ignored issues – show Bug introduced 2016-05-26 19:45 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `saved_values` does not seem to exist. Did you mean `values`? An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history...
49		}
50		if ($vout === true) {
51		$vout = '<span class="true">true</span>';
52		}
53		if ($vout === false) {
54		$vout = '<span class="false">false</span>';
55		}
56		if (isset($this->values[$key])) {
57		$out[] = $vout;
58		} else {
59		$out[] = '<s>' . $vout . '</s>';
60		}
61		}
62		$out = '[' . implode(', ', $out) . ']';
63
64		return $out;
65		}
66
67	View Code Duplication	public function calc($operator, $operand) {
		0 ignored issues – show Duplication introduced 2016-05-26 19:45 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
68		$out = [];
69		foreach ($this->values as $value) {
70		$out[] = CalcOperation::calc($operator, $operand, $value);
71		}
72
73		return new CalcSet($out);
74		}
75
76	View Code Duplication	public function rcalc($operator, $operand) {
		0 ignored issues – show Duplication introduced 2016-05-26 19:45 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
77		$out = [];
78		foreach ($this->values as $value) {
79		$out[] = CalcOperation::calc($operator, $value, $operand);
80		}
81
82		return new CalcSet($out);
83		}
84
85	View Code Duplication	public function mcalc($operator, $operand)
		0 ignored issues – show Duplication introduced 2016-05-26 19:45 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
86		{
87		$out = [];
88		foreach ($this->values as $value) {
89		$out[] = $operand->rcalc($operator, $value);
90		}
91
92		return new CalcSet($out);
93		}
94
95		public function value()
96		{
97		$allnumeric = true;
98		foreach ($this->values as $v) {
99		if (is_numeric($v)) {
		0 ignored issues – show Unused Code introduced 2016-05-26 19:45 UTC by Report Bug Copy Issue Report Show Similar Issues like this This `if` statement is empty and can be removed. This check looks for the bodies of `if` statements that have no statements or where all statements have been commented out. This may be the result of changes for debugging or the code may simply be obsolete. These `if` bodies can be removed. If you have an empty if but statements in the `else` branch, consider inverting the condition. if (rand(1, 6) > 3) { //print "Check failed"; } else { print "Check succeeded"; } could be turned into if (rand(1, 6) <= 3) { print "Check succeeded"; } This is much more concise to read. Loading history...
100		} else {
101		$allnumeric = false;
102		}
103		}
104
105		if ($allnumeric) {
106		return array_sum($this->values);
107		} else {
108		return $this;
109		}
110		}
111		}
112

sergej-kurakin / dicecalc

Issues (16)

Security Analysis not enabled

src/DiceCalc/CalcSet.php (9 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like