DiceCalc\CalcSet

Complexity

Total Complexity

22

Size/Duplication

Total Lines	100
Duplicated Lines	25 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes	3
Bugs	0	Features	0

6 Methods

Rating	Name	Duplication	Size	Complexity
B	__construct()	0	26	6
B	__toString()	0	23	6
A	calc()	8	8	2
A	rcalc()	8	8	2
A	mcalc()	9	9	2
A	value()	0	16	4

<?php

namespace DiceCalc;

/**
 * Class CalcSet
 *
 * @package DiceCalc
 * @author  Owen Winkler <epithet@gmail.com>
 * @license MIT http://opensource.org/licenses/MIT
 */
class CalcSet {
    protected $values = [];
    protected $label;

    public function __construct($set_value) {
        if (is_array($set_value)) {
            $this->values       = $set_value;
            $this->saved_values = $this->values;

The property saved_values does not seem to exist. Did you mean values?

            $this->label        = '[' . implode(', ', $set_value) . ']';
        } else {
            $this->label = $set_value;
            preg_match('%^(?P<multiple>\d*)\[(?P<set>[^\]]+)\]$%i', $set_value, $matches);
            $set_value = $matches['set'];
            $values    = explode(',', $set_value);
            for ($z = 0; $z < max(1, intval($matches['multiple'])); $z ++) {

Consider avoiding function calls on each iteration of the for loop.

                foreach ($values as $set_value) {
                    $this->values[] = $set_value;
                }
            }
            $this->saved_values = $this->values;

The property saved_values does not seem to exist. Did you mean values?

            foreach ($this->values as $k => $set_value) {
                $calc             = new Calc($set_value);
                $this->values[$k] = $calc();
            }
            foreach ($this->values as $k => $value) {
                $calc             = new Calc($value);
                $this->values[$k] = $calc();
            }
        }
    }

    public function __toString() {
        $out = [];
        foreach (array_keys($this->saved_values) as $key) {

The property saved_values does not seem to exist. Did you mean values?

            $vout = $this->values[$key];
            if (!isset($this->values[$key])) {
                $vout = $this->saved_values[$key];

The property saved_values does not seem to exist. Did you mean values?

            }
            if ($vout === true) {
                $vout = '<span class="true">true</span>';
            }
            if ($vout === false) {
                $vout = '<span class="false">false</span>';
            }
            if (isset($this->values[$key])) {
                $out[] = $vout;
            } else {
                $out[] = '<s>' . $vout . '</s>';
            }
        }
        $out = '[' . implode(', ', $out) . ']';

        return $out;
    }

    public function calc($operator, $operand) {

This method seems to be duplicated in your project.

        $out = [];
        foreach ($this->values as $value) {
            $out[] = CalcOperation::calc($operator, $operand, $value);
        }

        return new CalcSet($out);
    }

    public function rcalc($operator, $operand) {

This method seems to be duplicated in your project.

        $out = [];
        foreach ($this->values as $value) {
            $out[] = CalcOperation::calc($operator, $value, $operand);
        }

        return new CalcSet($out);
    }

    public function mcalc($operator, $operand)

This method seems to be duplicated in your project.

    {
        $out = [];
        foreach ($this->values as $value) {
            $out[] = $operand->rcalc($operator, $value);
        }

        return new CalcSet($out);
    }

    public function value()
    {
        $allnumeric = true;
        foreach ($this->values as $v) {
            if (is_numeric($v)) {

This if statement is empty and can be removed.

            } else {
                $allnumeric = false;
            }
        }

        if ($allnumeric) {
            return array_sum($this->values);
        } else {
            return $this;
        }
    }
}