Issues in RepliesController.php (master) - Issues in master - seongbae/discuss - Measure and Improve Code Quality continuously with Scrutinizer

Issues (36)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Http/Controllers/RepliesController.php (6 issues)

Labels

Severity

Minor 6

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Seongbae\Discuss\Http\Controllers;


use Illuminate\Http\Request;
use Seongbae\Discuss\Models\Thread;
use Seongbae\Discuss\Models\Channel;
use Illuminate\Support\Facades\Auth;
use Seongbae\Discuss\Models\Reply;
use App\Http\Controllers\Controller;

class RepliesController extends Controller
{
    /**
     * Create a new RepliesController instance.
     */
    public function __construct()
    {
        $this->middleware('auth');
    }

    /**
     * Persist a new reply.
     *
     * @param  Thread $thread
     * @return \Illuminate\Http\RedirectResponse
     */
    public function store(Request $request, Channel $channel, Thread $thread)
    {
        $this->validate(request(), [
            'body'=>'required'
        ]);

        $reply = $thread->addReply([
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();
            'body' => request('body'),
            'user_id' => Auth::id(),
            'user_type' => $thread->user_type
        ], request('subscribe') == '1');

        if ($request->ajax())
            return $request->json([$reply], 200);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
       else
            return redirect()->back();
    }

    /**
     * Update the specified resource in storage.
     *
     * @param  \Illuminate\Http\Request  $request
     * @param  \App\Thread  $thread
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @return \Illuminate\Http\Response
     */
    public function update(Request $request, Reply $reply)
    {
         $this->validate(request(), [
             'body'=>'required'
         ]);

        $reply->update(request(['body']));

        if ($request->ajax())
            return $request->json([$reply], 200);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        else
            return redirect()->back();
    }

    /**
     * Remove the specified resource from storage.
     *
     * @param  \App\Thread  $thread
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @return \Illuminate\Http\Response
     */
    public function destroy(Reply $reply, Request $request)
    {
        $reply->delete();

        if ($request->ajax())
            return $request->json([], 200);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        else
            return redirect()->back();
    }
}


1			<?php
2
3			namespace Seongbae\Discuss\Http\Controllers;
4
5
6			use Illuminate\Http\Request;
7			use Seongbae\Discuss\Models\Thread;
8			use Seongbae\Discuss\Models\Channel;
9			use Illuminate\Support\Facades\Auth;
10			use Seongbae\Discuss\Models\Reply;
11			use App\Http\Controllers\Controller;
12
13			class RepliesController extends Controller
14			{
15			/**
16			* Create a new RepliesController instance.
17			*/
18			public function __construct()
19			{
20			$this->middleware('auth');
21			}
22
23			/**
24			* Persist a new reply.
25			*
26			* @param Thread $thread
27			* @return \Illuminate\Http\RedirectResponse
28			*/
29			public function store(Request $request, Channel $channel, Thread $thread)
30			{
31			$this->validate(request(), [
32			'body'=>'required'
33			]);
34
35			$reply = $thread->addReply([
			0 ignored issues – show Bug introduced 2020-12-21 00:46 UTC by Report Bug Copy Issue Report Show Similar Issues like this Are you sure the assignment to `$reply` is correct as `$thread->addReply(array(...st('subscribe') == '1')` (which targets `Seongbae\Discuss\Models\Thread::addReply()`) seems to always return null. This check looks for function or method calls that always return null and whose return value is assigned to a variable. class A { function getObject() { return null; } } $a = new A(); $object = $a->getObject(); The method `getObject()` can return nothing but null, so it makes no sense to assign that value to a variable. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
36			'body' => request('body'),
37			'user_id' => Auth::id(),
38			'user_type' => $thread->user_type
39			], request('subscribe') == '1');
40
41			if ($request->ajax())
42			return $request->json([$reply], 200);
			0 ignored issues – show Documentation introduced 2020-12-21 00:46 UTC by Report Bug Copy Issue Report Show Similar Issues like this `array($reply)` is of type `array<integer,null,{"0":"null"}>`, but the function expects a `string\|null`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
43			else
44			return redirect()->back();
45			}
46
47			/**
48			* Update the specified resource in storage.
49			*
50			* @param \Illuminate\Http\Request $request
51			* @param \App\Thread $thread
			0 ignored issues – show Bug introduced 2020-06-07 14:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this There is no parameter named `$thread`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
52			* @return \Illuminate\Http\Response
53			*/
54			public function update(Request $request, Reply $reply)
55			{
56			$this->validate(request(), [
57			'body'=>'required'
58			]);
59
60			$reply->update(request(['body']));
61
62			if ($request->ajax())
63			return $request->json([$reply], 200);
			0 ignored issues – show Documentation introduced 2020-12-21 00:46 UTC by Report Bug Copy Issue Report Show Similar Issues like this `array($reply)` is of type `array<integer,object<Seo...cuss\\Models\\Reply>"}>`, but the function expects a `string\|null`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
64			else
65			return redirect()->back();
66			}
67
68			/**
69			* Remove the specified resource from storage.
70			*
71			* @param \App\Thread $thread
			0 ignored issues – show Bug introduced 2020-06-07 14:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this There is no parameter named `$thread`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
72			* @return \Illuminate\Http\Response
73			*/
74			public function destroy(Reply $reply, Request $request)
75			{
76			$reply->delete();
77
78			if ($request->ajax())
79			return $request->json([], 200);
			0 ignored issues – show Documentation introduced 2020-12-21 00:46 UTC by Report Bug Copy Issue Report Show Similar Issues like this `array()` is of type `array`, but the function expects a `string\|null`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
80			else
81			return redirect()->back();
82			}
83			}
84

seongbae / discuss

Issues (36)

Security Analysis not enabled

src/Http/Controllers/RepliesController.php (6 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like