Seongbae\Discuss\Http\Controllers\RepliesController

Complexity

Total Complexity

7

Size/Duplication

Total Lines	71
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	5

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	store()	0	17	2
A	update()	0	13	2
A	destroy()	0	9	2

<?php

namespace Seongbae\Discuss\Http\Controllers;


use Illuminate\Http\Request;
use Seongbae\Discuss\Models\Thread;
use Seongbae\Discuss\Models\Channel;
use Illuminate\Support\Facades\Auth;
use Seongbae\Discuss\Models\Reply;
use App\Http\Controllers\Controller;

class RepliesController extends Controller
{
    /**
     * Create a new RepliesController instance.
     */
    public function __construct()
    {
        $this->middleware('auth');
    }

    /**
     * Persist a new reply.
     *
     * @param  Thread $thread
     * @return \Illuminate\Http\RedirectResponse
     */
    public function store(Request $request, Channel $channel, Thread $thread)
    {
        $this->validate(request(), [
            'body'=>'required'
        ]);

        $reply = $thread->addReply([

Are you sure the assignment to $reply is correct as $thread->addReply(array('body' => request('body'), 'user_id' => \Illuminate\Support\Facades\Auth::id(), 'user_type' => $thread->user_type), request('subscribe') == '1') (which targets Seongbae\Discuss\Models\Thread::addReply()) seems to always return null.

            'body' => request('body'),
            'user_id' => Auth::id(),
            'user_type' => $thread->user_type
        ], request('subscribe') == '1');

        if ($request->ajax())
            return $request->json([$reply], 200);

array($reply) is of type array<integer,null,{"0":"null"}>, but the function expects a string|null.

       else
            return redirect()->back();
    }

    /**
     * Update the specified resource in storage.
     *
     * @param  \Illuminate\Http\Request  $request
     * @param  \App\Thread  $thread

There is no parameter named $thread. Was it maybe removed?

     * @return \Illuminate\Http\Response
     */
    public function update(Request $request, Reply $reply)
    {
         $this->validate(request(), [
             'body'=>'required'
         ]);

        $reply->update(request(['body']));

        if ($request->ajax())
            return $request->json([$reply], 200);

array($reply) is of type array<integer,object<Seongbae\Discuss\Models\Reply>,{"0":"object<Seongbae\\Discuss\\Models\\Reply>"}>, but the function expects a string|null.

        else
            return redirect()->back();
    }

    /**
     * Remove the specified resource from storage.
     *
     * @param  \App\Thread  $thread

There is no parameter named $thread. Was it maybe removed?

     * @return \Illuminate\Http\Response
     */
    public function destroy(Reply $reply, Request $request)
    {
        $reply->delete();

        if ($request->ajax())
            return $request->json([], 200);

array() is of type array, but the function expects a string|null.

        else
            return redirect()->back();
    }
}