seboettg / citeproc-php

src/Seboettg/CiteProc/Rendering/Name/Name.php

Doc Comments +8 added lines, -2 removed lines

@@ -205,7 +205,7 @@ 
     }
 
     /**
-     * @param $name
+     * @param \stdClass $name
      * @return \stdClass
      */
     private function cloneNamePOSC($name)
@@ -498,6 +498,12 @@ 
     }
 
 
+    /**
+     * @param \stdClass $data
+     * @param integer $rank
+     *
+     * @return string
+     */
     private function nameOrder($data, $rank)
     {
         $nameAsSortOrder = (($this->nameAsSortOrder === "first" && $rank === 0) || $this->nameAsSortOrder === "all");
@@ -587,7 +593,7 @@ 
     }
 
     /**
-     * @return mixed
+     * @return string
      */
     public function getDelimiter()
     {

Spacing +6 added lines, -6 removed lines

@@ -92,7 +92,7 @@ 
         foreach ($node->attributes() as $attribute) {
             switch ($attribute->getName()) {
                 case 'form':
-                    $this->form = (string)$attribute;
+                    $this->form = (string) $attribute;
                     break;
             }
 
@@ -152,7 +152,7 @@ 
         cs:names element (taking into account the effects of et-al abbreviation and editor/translator collapsing),
         which allows for advanced sorting. */
         if ($this->form == 'count') {
-            return (int)count($resultNames);
+            return (int) count($resultNames);
         }
 
         return $text;
@@ -505,8 +505,8 @@ 
 
         if (StringHelper::isLatinString(NameHelper::normalizeName($data)) || StringHelper::isCyrillicString(NameHelper::normalizeName($data))) {
             if ($this->form === "long" && $nameAsSortOrder &&
-                ((string)$demoteNonDroppingParticle === DemoteNonDroppingParticle::NEVER ||
-                    (string)$demoteNonDroppingParticle === DemoteNonDroppingParticle::SORT_ONLY)
+                ((string) $demoteNonDroppingParticle === DemoteNonDroppingParticle::NEVER ||
+                    (string) $demoteNonDroppingParticle === DemoteNonDroppingParticle::SORT_ONLY)
             ) {
 
                 // [La] [Fontaine], [Jean] [de], [III]
@@ -519,7 +519,7 @@ 
                 $text .= !empty($data->suffix) ? $this->sortSeparator . $data->suffix : "";
             } else if ($this->form === "long" && $nameAsSortOrder &&
                 (is_null($demoteNonDroppingParticle) ||
-                    (string)$demoteNonDroppingParticle === DemoteNonDroppingParticle::DISPLAY_AND_SORT)
+                    (string) $demoteNonDroppingParticle === DemoteNonDroppingParticle::DISPLAY_AND_SORT)
             ) {
                 // [Fontaine], [Jean] [de] [La], [III]
 
@@ -549,7 +549,7 @@ 
                 $text = !empty($given) ? $given . " " . $family : $family;
             }
         } else {
-            $text = $this->form === "long" ? $data->family.$data->given : $data->family;
+            $text = $this->form === "long" ? $data->family . $data->given : $data->family;
         }
 
         return $text;

src/Seboettg/CiteProc/Util/NameHelper.php

Spacing +1 added lines, -1 removed lines

@@ -77,7 +77,7 @@
     {
         if (isset($data->{$particle}) && isset($data->{$namePart})) {
             $data->{$namePart} = $data->{$particle} . " " . $data->{$namePart}; //prepend $particle to $namePart
-            unset($data->{$particle});//remove particle from $data
+            unset($data->{$particle}); //remove particle from $data
         }
     }