Inspection of "Load collection helper in PHAR - issue #175" - sebastianfeldmann/phpbu - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 3a3e10...89e4e8 )

by Sebastian

created 2019-02-13 09:46 UTC

Status

Indentation +56 added lines, -56 removed lines patch added patch discarded remove patch

@@ -191,12 +191,12 @@  discard block
 block discarded – undo
             $info    = $this->getInfoHtml($result);
             $footer  = $this->getFooterHtml();
             $body    = '<html><body ' . TPL::getSnippet('sBody') . '>'
-                     . $header
-                     . $status
-                     . $errors
-                     . $info
-                     . $footer
-                     . '</body></html>';
+                        . $header
+                        . $status
+                        . $errors
+                        . $info
+                        . $footer
+                        . '</body></html>';
             $sent    = null;
             $state   = $result->allOk() ? 'OK' : ($result->backupOkButSkipsOrFails() ? 'WARNING' : 'ERROR');
 
@@ -360,7 +360,7 @@  discard block
 block discarded – undo
     protected function getHeaderHtml()
     {
         return '<table ' . TPL::getSnippet('sTableContent') . '><tr><td ' . TPL::getSnippet('sTableContentCol') . '>' .
-               '<table ' . TPL::getSnippet('sTableHeader') . '><tr><td>PHPBU - backup report</td></tr></table>';
+                '<table ' . TPL::getSnippet('sTableHeader') . '><tr><td>PHPBU - backup report</td></tr></table>';
     }
 
     /**
@@ -399,11 +399,11 @@  discard block
 block discarded – undo
             Str::appendPluralS('cleanup', $this->numCleanups)
         );
         $html = '<table ' . sprintf(TPL::getSnippet('sTableStatus'), $color) . '>' .
-                 '<tr><td>' .
-                  '<span ' . TPL::getSnippet('sTableStatusText') . '>' . date('Y-m-d H:i') . '</span>' .
-                  '<h1 ' . TPL::getSnippet('sTableStatusHead') . '>' . $status . '</h1>' .
-                  '<span ' . TPL::getSnippet('sTableStatusText') . '>' . $info . '</span>' .
-                 '</td></tr>' .
+                    '<tr><td>' .
+                    '<span ' . TPL::getSnippet('sTableStatusText') . '>' . date('Y-m-d H:i') . '</span>' .
+                    '<h1 ' . TPL::getSnippet('sTableStatusHead') . '>' . $status . '</h1>' .
+                    '<span ' . TPL::getSnippet('sTableStatusText') . '>' . $info . '</span>' .
+                    '</td></tr>' .
                 '</table>';
 
         return $html;
@@ -466,65 +466,65 @@  discard block
 block discarded – undo
                     $status = 'FAILURE';
                 }
                 $html .= '<tr>' .
-                          '<td ' . sprintf(TPL::getSnippet('sTableBackupStatusColumn'), $color) . ' colspan="4">' .
-                          sprintf('backup <em>%s</em>', $backup->getName()) .
-                          ' <span ' . TPL::getSnippet('sTableBackupStatusText') . '>' . $status . '</span>' .
-                          '</td>' .
-                         '</tr>' .
-                         '<tr>' .
-                          '<td ' . TPL::getSnippet('sRowHead') . '>&nbsp;</td>' .
-                          '<td ' . TPL::getSnippet('sRowHead') . ' align="right">executed</td>' .
-                          '<td ' . TPL::getSnippet('sRowHead') . ' align="right">skipped</td>' .
-                          '<td ' . TPL::getSnippet('sRowHead') . ' align="right">failed</td>' .
-                         '</tr>';
+                            '<td ' . sprintf(TPL::getSnippet('sTableBackupStatusColumn'), $color) . ' colspan="4">' .
+                            sprintf('backup <em>%s</em>', $backup->getName()) .
+                            ' <span ' . TPL::getSnippet('sTableBackupStatusText') . '>' . $status . '</span>' .
+                            '</td>' .
+                            '</tr>' .
+                            '<tr>' .
+                            '<td ' . TPL::getSnippet('sRowHead') . '>&nbsp;</td>' .
+                            '<td ' . TPL::getSnippet('sRowHead') . ' align="right">executed</td>' .
+                            '<td ' . TPL::getSnippet('sRowHead') . ' align="right">skipped</td>' .
+                            '<td ' . TPL::getSnippet('sRowHead') . ' align="right">failed</td>' .
+                            '</tr>';
 
                 $html .= '<tr>' .
-                          '<td ' . TPL::getSnippet('sRowCheck') . '>checks</td>' .
-                          '<td ' . TPL::getSnippet('sRowCheck') . ' align="right">' .
+                            '<td ' . TPL::getSnippet('sRowCheck') . '>checks</td>' .
+                            '<td ' . TPL::getSnippet('sRowCheck') . ' align="right">' .
                             $backup->checkCount() . '
                            </td>' .
-                          '<td ' . TPL::getSnippet('sRowCheck') . ' align="right">
+                            '<td ' . TPL::getSnippet('sRowCheck') . ' align="right">
                             &nbsp;
                            </td>' .
-                          '<td ' . TPL::getSnippet('sRowCheck') . ' align="right">' .
+                            '<td ' . TPL::getSnippet('sRowCheck') . ' align="right">' .
                             $backup->checkCountFailed() .
-                          '</td>' .
-                         '</tr>' .
-                         '<tr>' .
-                          '<td ' . TPL::getSnippet('sRowCrypt') . '>crypts</td>' .
-                          '<td ' . TPL::getSnippet('sRowCrypt') . ' align="right">' .
+                            '</td>' .
+                            '</tr>' .
+                            '<tr>' .
+                            '<td ' . TPL::getSnippet('sRowCrypt') . '>crypts</td>' .
+                            '<td ' . TPL::getSnippet('sRowCrypt') . ' align="right">' .
                             $backup->cryptCount() .
-                          '</td>' .
-                          '<td ' . TPL::getSnippet('sRowCrypt') . ' align="right">' .
+                            '</td>' .
+                            '<td ' . TPL::getSnippet('sRowCrypt') . ' align="right">' .
                             $backup->cryptCountSkipped() .
-                          '</td>' .
-                          '<td ' . TPL::getSnippet('sRowCrypt') . ' align="right">' .
+                            '</td>' .
+                            '<td ' . TPL::getSnippet('sRowCrypt') . ' align="right">' .
                             $backup->cryptCountFailed() .
-                          '</td>' .
-                         '</tr>' .
-                         '<tr>' .
-                          '<td ' . TPL::getSnippet('sRowSync') . '>syncs</td>' .
-                          '<td ' . TPL::getSnippet('sRowSync') . ' align="right">' .
+                            '</td>' .
+                            '</tr>' .
+                            '<tr>' .
+                            '<td ' . TPL::getSnippet('sRowSync') . '>syncs</td>' .
+                            '<td ' . TPL::getSnippet('sRowSync') . ' align="right">' .
                             $backup->syncCount() . '</td>' .
-                          '<td ' . TPL::getSnippet('sRowSync') . ' align="right">' .
+                            '<td ' . TPL::getSnippet('sRowSync') . ' align="right">' .
                             $backup->syncCountSkipped() .
-                          '</td>' .
-                          '<td ' . TPL::getSnippet('sRowSync') . ' align="right">' .
+                            '</td>' .
+                            '<td ' . TPL::getSnippet('sRowSync') . ' align="right">' .
                             $backup->syncCountFailed() .
-                          '</td>' .
-                         '</tr>' .
-                         '<tr>' .
-                          '<td ' . TPL::getSnippet('sRowCleanup') . '>cleanups</td>' .
-                          '<td ' . TPL::getSnippet('sRowCleanup') . ' align="right">' .
+                            '</td>' .
+                            '</tr>' .
+                            '<tr>' .
+                            '<td ' . TPL::getSnippet('sRowCleanup') . '>cleanups</td>' .
+                            '<td ' . TPL::getSnippet('sRowCleanup') . ' align="right">' .
                             $backup->cleanupCount() .
-                          '</td>' .
-                          '<td ' . TPL::getSnippet('sRowCleanup') . ' align="right">' .
+                            '</td>' .
+                            '<td ' . TPL::getSnippet('sRowCleanup') . ' align="right">' .
                             $backup->cleanupCountSkipped() .
-                          '</td>' .
-                          '<td ' . TPL::getSnippet('sRowCleanup') . ' align="right">' .
+                            '</td>' .
+                            '<td ' . TPL::getSnippet('sRowCleanup') . ' align="right">' .
                             $backup->cleanupCountFailed() .
-                          '</td>' .
-                         '</tr>';
+                            '</td>' .
+                            '</tr>';
 
             }
             $html .= '</table>';
@@ -541,6 +541,6 @@  discard block
 block discarded – undo
     protected function getFooterHtml()
     {
         return '<p ' . TPL::getSnippet('sStats') . '>' . Statistics::resourceUsage() . '</p>' .
-               '</td></tr></table>';
+                '</td></tr></table>';
     }
 }

Please login to merge, or discard this patch.

		@@ -191,12 +191,12 @@ discard block
		block discarded – undo
191	191	$info = $this->getInfoHtml($result);
192	192	$footer = $this->getFooterHtml();
193	193	$body = '<html><body ' . TPL::getSnippet('sBody') . '>'
194		- . $header
195		- . $status
196		- . $errors
197		- . $info
198		- . $footer
199		- . '</body></html>';
	194	+ . $header
	195	+ . $status
	196	+ . $errors
	197	+ . $info
	198	+ . $footer
	199	+ . '</body></html>';
200	200	$sent = null;
201	201	$state = $result->allOk() ? 'OK' : ($result->backupOkButSkipsOrFails() ? 'WARNING' : 'ERROR');
202	202
		@@ -360,7 +360,7 @@ discard block
		block discarded – undo
360	360	protected function getHeaderHtml()
361	361	{
362	362	return '<table ' . TPL::getSnippet('sTableContent') . '><tr><td ' . TPL::getSnippet('sTableContentCol') . '>' .
363		- '<table ' . TPL::getSnippet('sTableHeader') . '><tr><td>PHPBU - backup report</td></tr></table>';
	363	+ '<table ' . TPL::getSnippet('sTableHeader') . '><tr><td>PHPBU - backup report</td></tr></table>';
364	364	}
365	365
366	366	/**
		@@ -399,11 +399,11 @@ discard block
		block discarded – undo
399	399	Str::appendPluralS('cleanup', $this->numCleanups)
400	400	);
401	401	$html = '<table ' . sprintf(TPL::getSnippet('sTableStatus'), $color) . '>' .
402		- '<tr><td>' .
403		- '<span ' . TPL::getSnippet('sTableStatusText') . '>' . date('Y-m-d H:i') . '</span>' .
404		- '<h1 ' . TPL::getSnippet('sTableStatusHead') . '>' . $status . '</h1>' .
405		- '<span ' . TPL::getSnippet('sTableStatusText') . '>' . $info . '</span>' .
406		- '</td></tr>' .
	402	+ '<tr><td>' .
	403	+ '<span ' . TPL::getSnippet('sTableStatusText') . '>' . date('Y-m-d H:i') . '</span>' .
	404	+ '<h1 ' . TPL::getSnippet('sTableStatusHead') . '>' . $status . '</h1>' .
	405	+ '<span ' . TPL::getSnippet('sTableStatusText') . '>' . $info . '</span>' .
	406	+ '</td></tr>' .
407	407	'</table>';
408	408
409	409	return $html;
		@@ -466,65 +466,65 @@ discard block
		block discarded – undo
466	466	$status = 'FAILURE';
467	467	}
468	468	$html .= '<tr>' .
469		- '<td ' . sprintf(TPL::getSnippet('sTableBackupStatusColumn'), $color) . ' colspan="4">' .
470		- sprintf('backup <em>%s</em>', $backup->getName()) .
471		- ' <span ' . TPL::getSnippet('sTableBackupStatusText') . '>' . $status . '</span>' .
472		- '</td>' .
473		- '</tr>' .
474		- '<tr>' .
475		- '<td ' . TPL::getSnippet('sRowHead') . '> </td>' .
476		- '<td ' . TPL::getSnippet('sRowHead') . ' align="right">executed</td>' .
477		- '<td ' . TPL::getSnippet('sRowHead') . ' align="right">skipped</td>' .
478		- '<td ' . TPL::getSnippet('sRowHead') . ' align="right">failed</td>' .
479		- '</tr>';
	469	+ '<td ' . sprintf(TPL::getSnippet('sTableBackupStatusColumn'), $color) . ' colspan="4">' .
	470	+ sprintf('backup <em>%s</em>', $backup->getName()) .
	471	+ ' <span ' . TPL::getSnippet('sTableBackupStatusText') . '>' . $status . '</span>' .
	472	+ '</td>' .
	473	+ '</tr>' .
	474	+ '<tr>' .
	475	+ '<td ' . TPL::getSnippet('sRowHead') . '> </td>' .
	476	+ '<td ' . TPL::getSnippet('sRowHead') . ' align="right">executed</td>' .
	477	+ '<td ' . TPL::getSnippet('sRowHead') . ' align="right">skipped</td>' .
	478	+ '<td ' . TPL::getSnippet('sRowHead') . ' align="right">failed</td>' .
	479	+ '</tr>';
480	480
481	481	$html .= '<tr>' .
482		- '<td ' . TPL::getSnippet('sRowCheck') . '>checks</td>' .
483		- '<td ' . TPL::getSnippet('sRowCheck') . ' align="right">' .
	482	+ '<td ' . TPL::getSnippet('sRowCheck') . '>checks</td>' .
	483	+ '<td ' . TPL::getSnippet('sRowCheck') . ' align="right">' .
484	484	$backup->checkCount() . '
485	485	</td>' .
486		- '<td ' . TPL::getSnippet('sRowCheck') . ' align="right">
	486	+ '<td ' . TPL::getSnippet('sRowCheck') . ' align="right">
487	487
488	488	</td>' .
489		- '<td ' . TPL::getSnippet('sRowCheck') . ' align="right">' .
	489	+ '<td ' . TPL::getSnippet('sRowCheck') . ' align="right">' .
490	490	$backup->checkCountFailed() .
491		- '</td>' .
492		- '</tr>' .
493		- '<tr>' .
494		- '<td ' . TPL::getSnippet('sRowCrypt') . '>crypts</td>' .
495		- '<td ' . TPL::getSnippet('sRowCrypt') . ' align="right">' .
	491	+ '</td>' .
	492	+ '</tr>' .
	493	+ '<tr>' .
	494	+ '<td ' . TPL::getSnippet('sRowCrypt') . '>crypts</td>' .
	495	+ '<td ' . TPL::getSnippet('sRowCrypt') . ' align="right">' .
496	496	$backup->cryptCount() .
497		- '</td>' .
498		- '<td ' . TPL::getSnippet('sRowCrypt') . ' align="right">' .
	497	+ '</td>' .
	498	+ '<td ' . TPL::getSnippet('sRowCrypt') . ' align="right">' .
499	499	$backup->cryptCountSkipped() .
500		- '</td>' .
501		- '<td ' . TPL::getSnippet('sRowCrypt') . ' align="right">' .
	500	+ '</td>' .
	501	+ '<td ' . TPL::getSnippet('sRowCrypt') . ' align="right">' .
502	502	$backup->cryptCountFailed() .
503		- '</td>' .
504		- '</tr>' .
505		- '<tr>' .
506		- '<td ' . TPL::getSnippet('sRowSync') . '>syncs</td>' .
507		- '<td ' . TPL::getSnippet('sRowSync') . ' align="right">' .
	503	+ '</td>' .
	504	+ '</tr>' .
	505	+ '<tr>' .
	506	+ '<td ' . TPL::getSnippet('sRowSync') . '>syncs</td>' .
	507	+ '<td ' . TPL::getSnippet('sRowSync') . ' align="right">' .
508	508	$backup->syncCount() . '</td>' .
509		- '<td ' . TPL::getSnippet('sRowSync') . ' align="right">' .
	509	+ '<td ' . TPL::getSnippet('sRowSync') . ' align="right">' .
510	510	$backup->syncCountSkipped() .
511		- '</td>' .
512		- '<td ' . TPL::getSnippet('sRowSync') . ' align="right">' .
	511	+ '</td>' .
	512	+ '<td ' . TPL::getSnippet('sRowSync') . ' align="right">' .
513	513	$backup->syncCountFailed() .
514		- '</td>' .
515		- '</tr>' .
516		- '<tr>' .
517		- '<td ' . TPL::getSnippet('sRowCleanup') . '>cleanups</td>' .
518		- '<td ' . TPL::getSnippet('sRowCleanup') . ' align="right">' .
	514	+ '</td>' .
	515	+ '</tr>' .
	516	+ '<tr>' .
	517	+ '<td ' . TPL::getSnippet('sRowCleanup') . '>cleanups</td>' .
	518	+ '<td ' . TPL::getSnippet('sRowCleanup') . ' align="right">' .
519	519	$backup->cleanupCount() .
520		- '</td>' .
521		- '<td ' . TPL::getSnippet('sRowCleanup') . ' align="right">' .
	520	+ '</td>' .
	521	+ '<td ' . TPL::getSnippet('sRowCleanup') . ' align="right">' .
522	522	$backup->cleanupCountSkipped() .
523		- '</td>' .
524		- '<td ' . TPL::getSnippet('sRowCleanup') . ' align="right">' .
	523	+ '</td>' .
	524	+ '<td ' . TPL::getSnippet('sRowCleanup') . ' align="right">' .
525	525	$backup->cleanupCountFailed() .
526		- '</td>' .
527		- '</tr>';
	526	+ '</td>' .
	527	+ '</tr>';
528	528
529	529	}
530	530	$html .= '</table>';
		@@ -541,6 +541,6 @@ discard block
		block discarded – undo
541	541	protected function getFooterHtml()
542	542	{
543	543	return '<p ' . TPL::getSnippet('sStats') . '>' . Statistics::resourceUsage() . '</p>' .
544		- '</td></tr></table>';
	544	+ '</td></tr></table>';
545	545	}
546	546	}

sebastianfeldmann / phpbu

Push — master ( 3a3e10...89e4e8 )

Status

Category

Indentation +56 added lines, -56 removed lines patch added patch discarded remove patch