Passed
Branch master (051205)
by Dan Michael O.
04:47
created
src/Analytics/Report.php 1 patch
Doc Comments   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -37,6 +37,9 @@  discard block
 block discarded – undo
37 37
         }
38 38
     }
39 39
 
40
+    /**
41
+     * @param string $resumptionToken
42
+     */
40 43
     protected function fetchRows($resumptionToken = null)
41 44
     {
42 45
         $results = $this->client->getXML('/analytics/reports', [
@@ -54,7 +57,7 @@  discard block
 block discarded – undo
54 57
     }
55 58
 
56 59
     /**
57
-     * @return \Generator|Row[]
60
+     * @return \Generator
58 61
      */
59 62
     public function getRows()
60 63
     {
Please login to merge, or discard this patch.
src/Client.php 1 patch
Doc Comments   +6 added lines, -3 removed lines patch added patch discarded remove patch
@@ -84,7 +84,7 @@  discard block
 block discarded – undo
84 84
     }
85 85
 
86 86
     /**
87
-     * @param $regionCode
87
+     * @param string $regionCode
88 88
      *
89 89
      * @throws \ErrorException
90 90
      */
@@ -99,7 +99,7 @@  discard block
 block discarded – undo
99 99
     }
100 100
 
101 101
     /**
102
-     * @param $url
102
+     * @param string $url
103 103
      *
104 104
      * @return string
105 105
      */
@@ -143,6 +143,9 @@  discard block
 block discarded – undo
143 143
         }
144 144
     }
145 145
 
146
+    /**
147
+     * @param \Psr\Http\Message\ResponseInterface|null $response
148
+     */
146 149
     public function handleError($response)
147 150
     {
148 151
         $msg = $response->getBody();
@@ -173,7 +176,7 @@  discard block
 block discarded – undo
173 176
      * @param string $url
174 177
      * @param array  $query
175 178
      *
176
-     * @return mixed
179
+     * @return QuiteSimpleXMLElement
177 180
      */
178 181
     public function getXML($url, $query = [])
179 182
     {
Please login to merge, or discard this patch.
src/Providers/AlmaServiceProvider.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -61,7 +61,7 @@
 block discarded – undo
61 61
     /**
62 62
      * Get the services provided by the provider.
63 63
      *
64
-     * @return array
64
+     * @return string[]
65 65
      */
66 66
     public function provides()
67 67
     {
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -2,7 +2,6 @@
 block discarded – undo
2 2
 
3 3
 namespace Scriptotek\Alma\Providers;
4 4
 
5
-use Illuminate\Foundation\Application;
6 5
 use Illuminate\Support\ServiceProvider;
7 6
 use Scriptotek\Alma\Client as AlmaClient;
8 7
 use Scriptotek\Sru\Client as SruClient;
Please login to merge, or discard this patch.