scriptotek / php-alma-client

spec/Bibs/BibSpec.php

Unused Use Statements -1 removed lines

@@ -7,7 +7,6 @@
 use Psr\Http\Message\UriInterface;
 use Scriptotek\Alma\Bibs\Bib;
 use Scriptotek\Alma\Bibs\Bibs;
-use Scriptotek\Alma\Bibs\Holding;
 use Scriptotek\Alma\Bibs\Holdings;
 use Scriptotek\Alma\Client as AlmaClient;
 use Scriptotek\Alma\Exception\ResourceNotFound;

Doc Comments +4 added lines

@@ -22,6 +22,10 @@
         $this->beConstructedWith($client, $mms_id);
     }
 
+    /**
+     * @param AlmaClient $client
+     * @param UriInterface $url
+     */
     protected function expectRequest($client, $url)
     {
         $client->buildUrl('/bibs/999104760474702204', [])

spec/Bibs/HoldingSpec.php

Unused Use Statements -1 removed lines

@@ -3,7 +3,6 @@
 namespace spec\Scriptotek\Alma\Bibs;
 
 use PhpSpec\ObjectBehavior;
-use Prophecy\Argument;
 use Psr\Http\Message\UriInterface;
 use Scriptotek\Alma\Bibs\Bib;
 use Scriptotek\Alma\Bibs\Holding;

spec/Conf/LibrarySpec.php

Unused Use Statements -1 removed lines

@@ -5,7 +5,6 @@
 use Scriptotek\Alma\Client as AlmaClient;
 use Scriptotek\Alma\Conf\Library;
 use PhpSpec\ObjectBehavior;
-use Prophecy\Argument;
 use Scriptotek\Alma\Conf\Locations;
 
 class LibrarySpec extends ObjectBehavior

spec/Conf/LocationSpec.php

Unused Use Statements -1 removed lines

@@ -6,7 +6,6 @@
 use Scriptotek\Alma\Conf\Library;
 use Scriptotek\Alma\Conf\Location;
 use PhpSpec\ObjectBehavior;
-use Prophecy\Argument;
 
 class LocationSpec extends ObjectBehavior
 {

src/Client.php

Unused Use Statements -1 removed lines

@@ -21,7 +21,6 @@
 use Scriptotek\Alma\Bibs\Bibs;
 use Scriptotek\Alma\Bibs\Items;
 use Scriptotek\Alma\Conf\Conf;
-use Scriptotek\Alma\Conf\Libraries;
 use Scriptotek\Alma\Exception\ClientException as AlmaClientException;
 use Scriptotek\Alma\Exception\InvalidApiKey;
 use Scriptotek\Alma\Exception\MaxNumberOfAttemptsExhausted;

Doc Comments +2 added lines, -5 removed lines

@@ -167,7 +167,7 @@ 
     /**
      * Set the Alma region code ('na' for North America, 'eu' for Europe, 'ap' for Asia Pacific).
      *
-     * @param $regionCode
+     * @param string $regionCode
      *
      * @throws \ErrorException
      *
@@ -187,7 +187,6 @@ 
      * Extend an URL (UriInterface or string) with query string parameters
      * and return an UriInterface object.
      *
-     * @param string $url|UriInterface
      * @param array  $query
      *
      * @return UriInterface
@@ -270,7 +269,6 @@ 
     /**
      * Make a GET request.
      *
-     * @param string $url|UriInterface
      * @param array  $query
      * @param string $contentType
      *
@@ -291,7 +289,6 @@ 
     /**
      * Make a GET request, accepting JSON.
      *
-     * @param string $url|UriInterface
      * @param array  $query
      *
      * @return \stdClass JSON response as an object.
@@ -306,8 +303,8 @@ 
     /**
      * Make a GET request, accepting XML.
      *
-     * @param string $url|UriInterface
      * @param array  $query
+     * @param UriInterface $url
      *
      * @return QuiteSimpleXMLElement
      */

spec/Analytics/ReportSpec.php

Unused Use Statements -1 removed lines

@@ -6,7 +6,6 @@
 use Psr\Http\Message\UriInterface;
 use Scriptotek\Alma\Analytics\Report;
 use Scriptotek\Alma\Analytics\Row;
-use Scriptotek\Alma\Analytics\Rows;
 use Scriptotek\Alma\Client;
 use Scriptotek\Alma\Exception\ResourceNotFound;
 use spec\Scriptotek\Alma\SpecHelper;

src/Analytics/Report.php

Doc Comments +2 added lines, -2 removed lines

@@ -78,8 +78,8 @@
     /**
      * Convert a retrieved resource to an object.
      *
-     * @param $data
-     * @return mixed
+     * @param QuiteSimpleXMLElement $data
+     * @return Row
      */
     protected function convertToResource($data)
     {

spec/Users/FeeSpec.php

Unused Use Statements -2 removed lines

@@ -3,8 +3,6 @@
 namespace spec\Scriptotek\Alma\Users;
 
 use PhpSpec\ObjectBehavior;
-use Prophecy\Argument;
-use Psr\Http\Message\UriInterface;
 use Scriptotek\Alma\Client as AlmaClient;
 use Scriptotek\Alma\Users\Fee;
 use Scriptotek\Alma\Users\User;

src/Bibs/Bib.php

Doc Comments +1 added lines

@@ -86,6 +86,7 @@
 
     /**
      * Get the MMS ID of the linked record in network zone.
+     * @return string
      */
     public function getNzMmsId()
     {