LibrariesSpec::let() - Code Metrics - Inspection of "Add item checkout and scan-in" - scriptotek/php-alma-client - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — master ( c6b6d3...528954 )

by Dan Michael O.

created 2018-07-26 20:10 UTC

LibrariesSpec::let() A

↳ Parent: LibrariesSpec

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
nc	1
nop	1
dl	0
loc	4
rs	10
c	0
b	0
f	0

<?php

namespace spec\Scriptotek\Alma\Conf;

use Psr\Http\Message\UriInterface;
use Scriptotek\Alma\Client as AlmaClient;
use Scriptotek\Alma\Conf\Libraries;
use Scriptotek\Alma\Conf\Library;
use PhpSpec\ObjectBehavior;
use spec\Scriptotek\Alma\SpecHelper;

class LibrariesSpec extends ObjectBehavior
{
    public function let(AlmaClient $client)
    {
        $this->beConstructedWith($client);
    }

    function it_is_muh()
    {
        $this->shouldBeAnInstanceOf(Libraries::class);
        $this->shouldImplement(\Countable::class);
        $this->shouldImplement(\Iterator::class);
    }

    function it_provides_a_lazy_interface_to_libary_objects(AlmaClient $client)

    {
        SpecHelper::expectNoRequests($client);

        $libraryCode = 'THAT_LIBRARY';
        $library = $this->get($libraryCode);

        $library->shouldBeAnInstanceOf(Library::class);
        $library->code->shouldBe($libraryCode);
    }

    function it_provides_libraries(AlmaClient $client, UriInterface $url)

    {
        $client->buildUrl('/conf/libraries', [])
            ->shouldBeCalled()
            ->willReturn($url);

        $client->getJSON($url)
            ->shouldBeCalled()
            ->willReturn(SpecHelper::getDummyData('libraries_response.json'));

        $this->shouldHaveCount(27);
        $this->all()->shouldBeArray();
        $this->all()[0]->shouldBeAnInstanceOf(Library::class);
    }
}


1		<?php
2
3		namespace spec\Scriptotek\Alma\Conf;
4
5		use Psr\Http\Message\UriInterface;
6		use Scriptotek\Alma\Client as AlmaClient;
7		use Scriptotek\Alma\Conf\Libraries;
8		use Scriptotek\Alma\Conf\Library;
9		use PhpSpec\ObjectBehavior;
10		use spec\Scriptotek\Alma\SpecHelper;
11
12		class LibrariesSpec extends ObjectBehavior
13		{
14		public function let(AlmaClient $client)
15		{
16		$this->beConstructedWith($client);
17		}
18
19		function it_is_muh()
20		{
21		$this->shouldBeAnInstanceOf(Libraries::class);
22		$this->shouldImplement(\Countable::class);
23		$this->shouldImplement(\Iterator::class);
24		}
25
26	View Code Duplication	function it_provides_a_lazy_interface_to_libary_objects(AlmaClient $client)
		0 ignored issues – show Duplication introduced 2018-07-26 20:14 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
27		{
28		SpecHelper::expectNoRequests($client);
29
30		$libraryCode = 'THAT_LIBRARY';
31		$library = $this->get($libraryCode);
32
33		$library->shouldBeAnInstanceOf(Library::class);
34		$library->code->shouldBe($libraryCode);
35		}
36
37	View Code Duplication	function it_provides_libraries(AlmaClient $client, UriInterface $url)
		0 ignored issues – show Duplication introduced 2018-07-26 20:14 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
38		{
39		$client->buildUrl('/conf/libraries', [])
40		->shouldBeCalled()
41		->willReturn($url);
42
43		$client->getJSON($url)
44		->shouldBeCalled()
45		->willReturn(SpecHelper::getDummyData('libraries_response.json'));
46
47		$this->shouldHaveCount(27);
48		$this->all()->shouldBeArray();
49		$this->all()[0]->shouldBeAnInstanceOf(Library::class);
50		}
51		}
52

scriptotek / php-alma-client

Push — master ( c6b6d3...528954 )

LibrariesSpec::let() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like