spec\Scriptotek\Alma\Conf\LibrariesSpec

Complexity

Total Complexity

4

Size/Duplication

Total Lines	40
Duplicated Lines	60 %

Coupling/Cohesion

Components	0
Dependencies	3

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	let()	0	4	1
A	it_is_muh()	0	6	1
A	it_provides_a_lazy_interface_to_libary_objects()	10	10	1
A	it_provides_libraries()	14	14	1

<?php

namespace spec\Scriptotek\Alma\Conf;

use Psr\Http\Message\UriInterface;
use Scriptotek\Alma\Client as AlmaClient;
use Scriptotek\Alma\Conf\Libraries;
use Scriptotek\Alma\Conf\Library;
use PhpSpec\ObjectBehavior;
use spec\Scriptotek\Alma\SpecHelper;

class LibrariesSpec extends ObjectBehavior
{
    public function let(AlmaClient $client)
    {
        $this->beConstructedWith($client);
    }

    function it_is_muh()
    {
        $this->shouldBeAnInstanceOf(Libraries::class);
        $this->shouldImplement(\Countable::class);
        $this->shouldImplement(\Iterator::class);
    }

    function it_provides_a_lazy_interface_to_libary_objects(AlmaClient $client)

This method seems to be duplicated in your project.

    {
        SpecHelper::expectNoRequests($client);

        $libraryCode = 'THAT_LIBRARY';
        $library = $this->get($libraryCode);

        $library->shouldBeAnInstanceOf(Library::class);
        $library->code->shouldBe($libraryCode);
    }

    function it_provides_libraries(AlmaClient $client, UriInterface $url)

This method seems to be duplicated in your project.

    {
        $client->buildUrl('/conf/libraries', [])
            ->shouldBeCalled()
            ->willReturn($url);

        $client->getJSON($url)
            ->shouldBeCalled()
            ->willReturn(SpecHelper::getDummyData('libraries_response.json'));

        $this->shouldHaveCount(27);
        $this->all()->shouldBeArray();
        $this->all()[0]->shouldBeAnInstanceOf(Library::class);
    }
}