scriptotek / php-alma-client

src/Client.php

Doc Comments +6 added lines, -3 removed lines

@@ -84,7 +84,7 @@ 
     }
 
     /**
-     * @param $regionCode
+     * @param string $regionCode
      *
      * @throws \ErrorException
      */
@@ -99,7 +99,7 @@ 
     }
 
     /**
-     * @param $url
+     * @param string $url
      *
      * @return string
      */
@@ -143,6 +143,9 @@ 
         }
     }
 
+    /**
+     * @param \Psr\Http\Message\ResponseInterface|null $response
+     */
     public function handleError($response)
     {
         $msg = $response->getBody();
@@ -173,7 +176,7 @@ 
      * @param string $url
      * @param array  $query
      *
-     * @return mixed
+     * @return QuiteSimpleXMLElement
      */
     public function getXML($url, $query = [])
     {

src/Providers/AlmaServiceProvider.php

Doc Comments +1 added lines, -1 removed lines

@@ -61,7 +61,7 @@
     /**
      * Get the services provided by the provider.
      *
-     * @return array
+     * @return string[]
      */
     public function provides()
     {

Unused Use Statements -1 removed lines

@@ -2,7 +2,6 @@
 
 namespace Scriptotek\Alma\Providers;
 
-use Illuminate\Foundation\Application;
 use Illuminate\Support\ServiceProvider;
 use Scriptotek\Alma\Client as AlmaClient;
 use Scriptotek\Sru\Client as SruClient;

spec/Bibs/BibsSpec.php

Unused Use Statements -1 removed lines

@@ -2,7 +2,6 @@
 
 namespace spec\Scriptotek\Alma\Bibs;
 
-use Danmichaelo\QuiteSimpleXMLElement\QuiteSimpleXMLElement;
 use PhpSpec\ObjectBehavior;
 use Prophecy\Argument;
 use Scriptotek\Alma\Bibs\Bib;

src/Users/User.php

Doc Comments +3 added lines

@@ -42,6 +42,9 @@
         return $this->data;
     }
 
+    /**
+     * @param string $id_type
+     */
     public function getIdOfType($id_type)
     {
         foreach ($this->user_identifier as $identifier) {

src/Analytics/Report.php

Doc Comments +5 added lines, -2 removed lines

@@ -37,6 +37,9 @@ 
         }
     }
 
+    /**
+     * @param string $resumptionToken
+     */
     protected function fetchRows($resumptionToken = null)
     {
         $results = $this->client->getXML('/analytics/reports', [
@@ -56,7 +59,7 @@ 
     }
 
     /**
-     * @param $results
+     * @param \Danmichaelo\QuiteSimpleXMLElement\QuiteSimpleXMLElement $results
      */
     protected function readResponseHeaders($results)
     {
@@ -75,7 +78,7 @@ 
     }
 
     /**
-     * @return \Generator|Row[]
+     * @return \Generator
      */
     public function getRows()
     {