Test Setup Failed
Pull Request — master (#26)
by
unknown
01:59
created
src/Bibs/Bib.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -86,6 +86,7 @@
 block discarded – undo
86 86
 
87 87
     /**
88 88
      * Get the MMS ID of the linked record in network zone.
89
+     * @return string
89 90
      */
90 91
     public function getNzMmsId()
91 92
     {
Please login to merge, or discard this patch.
spec/Bibs/BibSpec.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -21,6 +21,9 @@
 block discarded – undo
21 21
         $this->beConstructedWith($client, '999104760474702204');
22 22
     }
23 23
 
24
+    /**
25
+     * @param AlmaClient $client
26
+     */
24 27
     protected function expectRequest($client)
25 28
     {
26 29
         $client->getXML('/bibs/999104760474702204')
Please login to merge, or discard this patch.
src/Client.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -167,7 +167,7 @@
 block discarded – undo
167 167
     /**
168 168
      * Set the Alma region code ('na' for North America, 'eu' for Europe, 'ap' for Asia Pacific).
169 169
      *
170
-     * @param $regionCode
170
+     * @param string $regionCode
171 171
      *
172 172
      * @throws \ErrorException
173 173
      *
Please login to merge, or discard this patch.
spec/Bibs/HoldingSpec.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -19,6 +19,9 @@
 block discarded – undo
19 19
         $this->beConstructedWith($client, $bib, $holdings_id);
20 20
     }
21 21
 
22
+    /**
23
+     * @param AlmaClient $client
24
+     */
22 25
     protected function expectRequest($client)
23 26
     {
24 27
         $client->getXML('/bibs/abc/holdings/123')
Please login to merge, or discard this patch.
src/Model/LazyResource.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -90,7 +90,7 @@
 block discarded – undo
90 90
     /**
91 91
      * Get and return the model data.
92 92
      *
93
-     * @return object
93
+     * @return \stdClass
94 94
      */
95 95
     protected function fetchData()
96 96
     {
Please login to merge, or discard this patch.
spec/Bibs/PortfolioSpec.php 2 patches
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -25,6 +25,9 @@
 block discarded – undo
25 25
         $this->shouldHaveType(Portfolio::class);
26 26
     }
27 27
 
28
+    /**
29
+     * @param AlmaClient $client
30
+     */
28 31
     protected function expectRequest($client)
29 32
     {
30 33
         $client->getJSON('/bibs/abc/portfolios/123')
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -5,7 +5,6 @@
 block discarded – undo
5 5
 use PhpSpec\ObjectBehavior;
6 6
 use Scriptotek\Alma\Bibs\Bib;
7 7
 use Scriptotek\Alma\Bibs\Portfolio;
8
-use Scriptotek\Alma\Bibs\Portfolios;
9 8
 use Scriptotek\Alma\Client as AlmaClient;
10 9
 use Scriptotek\Alma\Electronic\Collection;
11 10
 use spec\Scriptotek\Alma\SpecHelper;
Please login to merge, or discard this patch.
spec/Bibs/RepresentationSpec.php 2 patches
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -20,6 +20,9 @@
 block discarded – undo
20 20
         $this->beConstructedWith($client, $bib, $representation_id);
21 21
     }
22 22
 
23
+    /**
24
+     * @param AlmaClient $client
25
+     */
23 26
     protected function expectRequest($client)
24 27
     {
25 28
         $client->getJSON('/bibs/abc/representations/123')
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -6,7 +6,6 @@
 block discarded – undo
6 6
 use Scriptotek\Alma\Bibs\Bib;
7 7
 use Scriptotek\Alma\Bibs\File;
8 8
 use Scriptotek\Alma\Bibs\Representation;
9
-use Scriptotek\Alma\Bibs\Representations;
10 9
 use Scriptotek\Alma\Client as AlmaClient;
11 10
 use spec\Scriptotek\Alma\SpecHelper;
12 11
 
Please login to merge, or discard this patch.