scriptotek / colligator-backend

app/Document.php

Doc Comments +1 added lines

@@ -60,6 +60,7 @@
 
     /**
      * Get enrichments associated with this document.
+     * @param string $serviceName
      */
     public function enrichmentsByService($serviceName)
     {

app/GoogleBooksService.php

Unused Use Statements -1 removed lines

@@ -3,7 +3,6 @@
 namespace Colligator;
 
 use Scriptotek\GoogleBooks\GoogleBooks;
-use Scriptotek\GoogleBooks\Exceptions\UsageRateExceeded;
 
 class GoogleBooksService implements EnrichmentService
 {

Spacing +4 added lines, -4 removed lines

@@ -19,7 +19,7 @@ 
     {
         foreach ($isbns as $isbn) {
             $volume = $this->books->volumes->byIsbn($isbn);
-            \Log::debug('[GoogleBooksService] - ' . $isbn . ': ' . (is_null($volume) ? 'not found' : 'found'));
+            \Log::debug('[GoogleBooksService] - '.$isbn.': '.(is_null($volume) ? 'not found' : 'found'));
             if (!is_null($volume)) {
                 return $volume;
             }
@@ -29,7 +29,7 @@ 
 
     public function enrich(Document $doc)
     {
-        \Log::debug('[GoogleBooksService] Checking document ' . $doc->id);
+        \Log::debug('[GoogleBooksService] Checking document '.$doc->id);
 
         $volume = $this->get($doc->bibliographic['isbns']);
 
@@ -47,11 +47,11 @@ 
         if ($volume) {
             $cover_url = $volume->getCover();
             if (!is_null($cover_url) && is_null($doc->cover)) {
-                \Log::debug('[GoogleBooksService] Setting new cover to document #' . $doc->id);
+                \Log::debug('[GoogleBooksService] Setting new cover to document #'.$doc->id);
                 try {
                     $doc->storeCover($cover_url);
                 } catch (\ErrorException $e) {
-                    \Log::error('[GoogleBooksService] Failed to store cover: ' . $cover_url . "\n" . $e->getMessage());
+                    \Log::error('[GoogleBooksService] Failed to store cover: '.$cover_url."\n".$e->getMessage());
                 }
             }
         }

app/Console/Commands/EnrichDocuments.php

Spacing +6 added lines, -6 removed lines

@@ -71,7 +71,7 @@ 
 
     public function handleDocuments(EnrichmentService $service, $docs)
     {
-        \Log::info('[EnrichDocuments] Starting job. ' . count($docs) . ' documents to be checked using the "' . $service::$serviceName . '" service.');
+        \Log::info('[EnrichDocuments] Starting job. '.count($docs).' documents to be checked using the "'.$service::$serviceName.'" service.');
 
         // $this->output->progressStart(count($docs));
         foreach ($docs as $doc) {
@@ -107,22 +107,22 @@ 
         $collectionId = intval($this->option('collection'));
 
         if (!isset($this->services[$serviceName])) {
-            $this->error('Service "' . $serviceName . '" is not defined. Available servies: "' . implode('", "', array_keys($this->services)) . '".');
+            $this->error('Service "'.$serviceName.'" is not defined. Available servies: "'.implode('", "', array_keys($this->services)).'".');
             return;
         }
 
         if ($verbose) {
-            \DB::listen(function ($query, $bindings) {
-                $this->comment('Query: ' . $query . '. Bindings: ' . implode(', ', $bindings));
+            \DB::listen(function($query, $bindings) {
+                $this->comment('Query: '.$query.'. Bindings: '.implode(', ', $bindings));
             });
         }
 
-        $collectionHelp = ($collectionId > 0) ? ' in collection ' . $collectionId : '';
+        $collectionHelp = ($collectionId > 0) ? ' in collection '.$collectionId : '';
 
         $docs = $this->getDocumentsToBeChecked($serviceName, $force, $collectionId);
 
         if (!count($docs)) {
-            $this->info('No new documents' . $collectionHelp . '. Exiting.');
+            $this->info('No new documents'.$collectionHelp.'. Exiting.');
             \Log::info('[EnrichDocuments] No new documents to be checked.');
             return;
         }

app/Cover.php

Spacing +3 added lines, -3 removed lines

@@ -78,7 +78,7 @@ 
     public function invalidateCache()
     {
         if (!is_null($this->width) && !is_null($this->height)) {
-            \Log::debug('[Cover] Invalidating cache. Old version was ' . $this->width . ' x ' . $this->height);
+            \Log::debug('[Cover] Invalidating cache. Old version was '.$this->width.' x '.$this->height);
         }
         $this->width = null;
         $this->height = null;
@@ -123,12 +123,12 @@ 
             throw new \ErrorException('[Cover] Cannot cache when no URL set.');
         }
         if ($this->isCached()) {
-            \Log::debug('[Cover] Already cached: ' . $this->url);
+            \Log::debug('[Cover] Already cached: '.$this->url);
 
             return;
         }
 
-        \Log::debug('[Cover] Add to cache: ' . $this->url);
+        \Log::debug('[Cover] Add to cache: '.$this->url);
 
         $orig = \CoverCache::put($this->url);
 

app/Providers/BroadcastServiceProvider.php

Spacing +1 added lines, -1 removed lines

@@ -19,7 +19,7 @@
         /*
          * Authenticate the user's personal channel...
          */
-        Broadcast::channel('Colligator.User.{userId}', function ($user, $userId) {
+        Broadcast::channel('Colligator.User.{userId}', function($user, $userId) {
             return (int) $user->id === (int) $userId;
         });
     }

app/Providers/RouteServiceProvider.php

Spacing +2 added lines, -2 removed lines

@@ -41,7 +41,7 @@ 
         Route::group([
             'middleware' => 'web',
             'namespace' => $this->namespace,
-        ], function () {
+        ], function() {
             require base_path('routes/web.php');
         });
     }
@@ -58,7 +58,7 @@ 
             'middleware' => 'api',
             'namespace' => $this->namespace,
             // 'prefix' => 'api',
-        ], function () {
+        ], function() {
             require base_path('routes/api.php');
         });
     }

app/CachedImage.php

Spacing +8 added lines, -8 removed lines

@@ -21,7 +21,7 @@ 
         $this->imageManager = $imageManager ?: app('Intervention\Image\ImageManager');
         $maxAge = 3153600; // 30 days
         $this->fsConfig = new FlysystemConfig([
-            'CacheControl' => 'max-age=' . $maxAge . ', public',
+            'CacheControl' => 'max-age='.$maxAge.', public',
         ]);
     }
 
@@ -69,7 +69,7 @@ 
 
     public function basename()
     {
-        return sha1($this->sourceUrl . $this->maxHeight);
+        return sha1($this->sourceUrl.$this->maxHeight);
     }
 
     /**
@@ -95,28 +95,28 @@ 
     {
         $data = $this->download();
         if (!$data) {
-            throw new \ErrorException('[CoverCache] Failed to download ' . $this->sourceUrl);
+            throw new \ErrorException('[CoverCache] Failed to download '.$this->sourceUrl);
         }
 
         $img = $this->imageManager->make($data);
         if ($this->maxHeight && $img->height() > $this->maxHeight) {
-            \Log::debug('[CachedImage] Resizing from ' . $img->height() . ' to ' . $this->maxHeight);
+            \Log::debug('[CachedImage] Resizing from '.$img->height().' to '.$this->maxHeight);
             $img->heighten($this->maxHeight);
             $data = strval($img->encode('jpg'));
         }
 
         if ($img->width() / $img->height() > 1.4) {
-            throw new \ErrorException('[CoverCache] Not accepting images with w/h ratio > 1.4: ' . $this->sourceUrl);
+            throw new \ErrorException('[CoverCache] Not accepting images with w/h ratio > 1.4: '.$this->sourceUrl);
         }
 
         $this->setMetadata($data, $img);
 
-        \Log::debug('[CachedImage] Storing image as ' . $img->width() . ' x ' . $img->height() . ', ' . strlen($data) . ' bytes');
+        \Log::debug('[CachedImage] Storing image as '.$img->width().' x '.$img->height().', '.strlen($data).' bytes');
         if (!$this->filesystem->write($this->basename(), $data, $this->fsConfig)) {
-            throw new \ErrorException('[CoverCache] Failed to upload to S3: ' . $this->sourceUrl);
+            throw new \ErrorException('[CoverCache] Failed to upload to S3: '.$this->sourceUrl);
         }
 
-        \Log::debug('[CachedImage] Wrote cached version of ' . $this->sourceUrl . ' as ' . $this->basename());
+        \Log::debug('[CachedImage] Wrote cached version of '.$this->sourceUrl.' as '.$this->basename());
 
         return $this;
     }