Handler::report() - Code Metrics - Inspection of "Update .htaccess" - scriptotek/colligator-backend - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 8bfd95...2626ba )

by Dan Michael O.

created 2016-12-11 12:00 UTC

Handler::report() A

↳ Parent: Handler

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	4
rs	10
cc	1
eloc	2
nc	1
nop	1

<?php

namespace Colligator\Exceptions;

use Exception;
use Illuminate\Auth\AuthenticationException;
use Illuminate\Database\Eloquent\ModelNotFoundException;
use Illuminate\Foundation\Exceptions\Handler as ExceptionHandler;
use Illuminate\Validation\ValidationException;
use Illuminate\Auth\Access\AuthorizationException;
use Symfony\Component\HttpKernel\Exception\HttpException;
use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;


class Handler extends ExceptionHandler
{
    /**
     * A list of the exception types that should not be reported.
     *
     * @var array
     */
    protected $dontReport = [
        AuthorizationException::class,
        HttpException::class,
        ModelNotFoundException::class,
        ValidationException::class,
    ];

    /**
     * Render an exception into an HTTP response.
     *
     * @param \Illuminate\Http\Request $request
     * @param \Exception               $e
     *
     * @return \Symfony\Component\HttpFoundation\Response
     */
    public function render($request, Exception $e)
    {
        if ($e instanceof NotFoundHttpException) {
            return \Response::make([
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                'error' => 'not_found',
                'error_message' => 'Please check the URL you submitted'
            ], 404);
        }
        if ($e instanceof ModelNotFoundException) {
            abort(404);
        }
        if (method_exists($e, 'render')) {
            return $e->render();
        }

        return parent::render($request, $e);
    }

    /**
     * Convert an authentication exception into an unauthenticated response.
     *
     * @param  \Illuminate\Http\Request  $request
     * @param  \Illuminate\Auth\AuthenticationException  $exception
     * @return \Illuminate\Http\Response
     */
    protected function unauthenticated($request, AuthenticationException $exception)

    {
        if ($request->expectsJson()) {
            return response()->json(['error' => 'Unauthenticated.'], 401);
        }

        return redirect()->guest('login');
    }
}


1			<?php
2
3			namespace Colligator\Exceptions;
4
5			use Exception;
6			use Illuminate\Auth\AuthenticationException;
7			use Illuminate\Database\Eloquent\ModelNotFoundException;
8			use Illuminate\Foundation\Exceptions\Handler as ExceptionHandler;
9			use Illuminate\Validation\ValidationException;
10			use Illuminate\Auth\Access\AuthorizationException;
11			use Symfony\Component\HttpKernel\Exception\HttpException;
12			use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
13
14
15			class Handler extends ExceptionHandler
16			{
17			/**
18			* A list of the exception types that should not be reported.
19			*
20			* @var array
21			*/
22			protected $dontReport = [
23			AuthorizationException::class,
24			HttpException::class,
25			ModelNotFoundException::class,
26			ValidationException::class,
27			];
28
29			/**
30			* Render an exception into an HTTP response.
31			*
32			* @param \Illuminate\Http\Request $request
33			* @param \Exception $e
34			*
35			* @return \Symfony\Component\HttpFoundation\Response
36			*/
37			public function render($request, Exception $e)
38			{
39			if ($e instanceof NotFoundHttpException) {
40			return \Response::make([
			0 ignored issues – show Documentation introduced 2016-12-11 12:12 UTC by Report Bug Copy Issue Report `array('error' => 'not_fo...the URL you submitted')` is of type `array<string,string,{"er...ror_message":"string"}>`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
41			'error' => 'not_found',
42			'error_message' => 'Please check the URL you submitted'
43			], 404);
44			}
45			if ($e instanceof ModelNotFoundException) {
46			abort(404);
47			}
48			if (method_exists($e, 'render')) {
49			return $e->render();
50			}
51
52			return parent::render($request, $e);
53			}
54
55			/**
56			* Convert an authentication exception into an unauthenticated response.
57			*
58			* @param \Illuminate\Http\Request $request
59			* @param \Illuminate\Auth\AuthenticationException $exception
60			* @return \Illuminate\Http\Response
61			*/
62			protected function unauthenticated($request, AuthenticationException $exception)
			0 ignored issues – show Unused Code introduced 2016-12-11 12:12 UTC by Report Bug Copy Issue Report The parameter `$exception` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
63			{
64			if ($request->expectsJson()) {
65			return response()->json(['error' => 'Unauthenticated.'], 401);
66			}
67
68			return redirect()->guest('login');
69			}
70			}
71

scriptotek / colligator-backend

Push — master ( 8bfd95...2626ba )

Handler::report() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like