scriptotek / colligator-backend

app/Search/DocumentsIndex.php

Spacing +19 added lines, -19 removed lines

@@ -95,7 +95,7 @@ 
     public function sanitizeForQuery($value)
     {
         $chars = preg_quote('\\+-&|!(){}[]^~*?:');
-        $value = preg_replace('/([' . $chars . '])/', '\\\\\1', $value);
+        $value = preg_replace('/(['.$chars.'])/', '\\\\\1', $value);
 
         return $value;
         //
@@ -127,20 +127,20 @@ 
         }
         if ($request->has('collection')) {
             $col = Collection::findOrFail($request->collection);
-            $query[] = 'collections:"' . $this->sanitizeForQuery($col->name) . '"';
+            $query[] = 'collections:"'.$this->sanitizeForQuery($col->name).'"';
         }
         if ($request->has('subject')) {
-            $query[] = '(subjects.noubomn.prefLabel:"' . $this->sanitizeForQuery($request->subject) . '"' .
-                    ' OR subjects.NOTrBIB.prefLabel:"' . $this->sanitizeForQuery($request->subject) . '"' .
-                    ' OR genres.noubomn.prefLabel:"' . $this->sanitizeForQuery($request->subject) . '")';
+            $query[] = '(subjects.noubomn.prefLabel:"'.$this->sanitizeForQuery($request->subject).'"'.
+                    ' OR subjects.NOTrBIB.prefLabel:"'.$this->sanitizeForQuery($request->subject).'"'.
+                    ' OR genres.noubomn.prefLabel:"'.$this->sanitizeForQuery($request->subject).'")';
                 // TODO: Vi bør vel antakelig skille mellom X som emne og X som form/sjanger ?
                 //       Men da må frontend si fra hva den ønsker, noe den ikke gjør enda.
         }
         if ($request->has('language')) {
-            $query[] = 'language:"' . $this->sanitizeForQuery($request->language) . '"' ;
+            $query[] = 'language:"'.$this->sanitizeForQuery($request->language).'"';
         }
         if ($request->has('genre')) {
-            $query[] = 'genres.noubomn.prefLabel:"' . $this->sanitizeForQuery($request->genre) . '"';
+            $query[] = 'genres.noubomn.prefLabel:"'.$this->sanitizeForQuery($request->genre).'"';
         }
         if ($request->has('real')) {
             dd('`real` is (very) deprecated, please use `subject` instead.');
@@ -178,7 +178,7 @@ 
     public function getUsageCount($id, $type)
     {
         $this->getFullType($type);
-        $arg = $type . '.' . $id;
+        $arg = $type.'.'.$id;
         if (is_null(array_get($this->usage, $arg))) {
             $this->addToUsageCache($id, $type);
         }
@@ -207,11 +207,11 @@ 
             ->get();
 
         foreach ($entity_ids as $sid) {
-            array_set($this->usage, $type . '.' . $sid, 0);
+            array_set($this->usage, $type.'.'.$sid, 0);
         }
 
         foreach ($res as $row) {
-            array_set($this->usage, $type . '.' . $row->entity_id, intval($row->doc_count));
+            array_set($this->usage, $type.'.'.$row->entity_id, intval($row->doc_count));
         }
     }
 
@@ -221,10 +221,10 @@ 
         $query = \DB::table('entities')
                     ->select(['entity_id', 'entity_type', \DB::raw('count(document_id) as doc_count')])
                     ->groupBy('entity_id', 'entity_type');
-        $query->chunk(5000, function ($rows) use ($typemap) {
+        $query->chunk(5000, function($rows) use ($typemap) {
             foreach ($rows as $row) {
                 $type = $typemap[$row->entity_type];
-                array_set($this->usage, $type . '.' . $row->entity_id, intval($row->doc_count));
+                array_set($this->usage, $type.'.'.$row->entity_id, intval($row->doc_count));
             }
         });
     }
@@ -241,7 +241,7 @@ 
     {
         $payload = $this->basePayload();
         if (!is_null($indexVersion)) {
-            $payload['index'] = $this->esIndex . '_v' . $indexVersion;
+            $payload['index'] = $this->esIndex.'_v'.$indexVersion;
         }
         $payload['id'] = $doc->id;
 
@@ -251,8 +251,8 @@ 
         try {
             $this->client->index($payload);
         } catch (BadRequest400Exception $e) {
-            \Log::error('ElasticSearch returned error: ' . $e->getMessage() . '. Our request: ' . var_export($payload, true));
-            throw new \ErrorException('ElasticSearch failed to index the document ' . $doc->id . '. Please see the log for payload and full error response. Error message: ' . $e->getMessage());
+            \Log::error('ElasticSearch returned error: '.$e->getMessage().'. Our request: '.var_export($payload, true));
+            throw new \ErrorException('ElasticSearch failed to index the document '.$doc->id.'. Please see the log for payload and full error response. Error message: '.$e->getMessage());
         }
     }
 
@@ -273,7 +273,7 @@ 
         if (is_null($version)) {
             $version = $this->getCurrentVersion() + 1;
         }
-        $indexParams = ['index' => $this->esIndex . '_v' . $version];
+        $indexParams = ['index' => $this->esIndex.'_v'.$version];
         $indexParams['body']['settings']['analysis']['char_filter']['isbn_filter'] = [
             'type'        => 'pattern_replace',
             'pattern'     => '-',
@@ -315,7 +315,7 @@ 
     {
         try {
             $this->client->indices()->delete([
-                'index' => $this->esIndex . '_v' . $version,
+                'index' => $this->esIndex.'_v'.$version,
             ]);
         } catch (Missing404Exception $e) {
             # Didn't exist in the beginning, that's ok.
@@ -325,7 +325,7 @@ 
     public function addAction(&$actions, $action, $version)
     {
         if ($version) {
-            $actions[] = [$action => ['index' => $this->esIndex . '_v' . $version, 'alias' => $this->esIndex]];
+            $actions[] = [$action => ['index' => $this->esIndex.'_v'.$version, 'alias' => $this->esIndex]];
         }
     }
 
@@ -342,7 +342,7 @@ 
 
     public function versionExists($version)
     {
-        return $this->client->indices()->exists(['index' => $this->esIndex . '_v' . $version]);
+        return $this->client->indices()->exists(['index' => $this->esIndex.'_v'.$version]);
     }
 
     public function getCurrentVersion()

app/Console/Commands/OaiPmhHarvest.php

Spacing +6 added lines, -6 removed lines

@@ -48,7 +48,7 @@ 
         $this->comment('Available configurations:');
         $config = \Config::get('oaipmh.harvests', null);
         foreach (array_keys($config) as $key) {
-            $this->comment(' - ' . $key);
+            $this->comment(' - '.$key);
         }
     }
 
@@ -59,7 +59,7 @@ 
 
             return false;
         }
-        $harvestConfig = \Config::get('oaipmh.harvests.' . $this->argument('name'), null);
+        $harvestConfig = \Config::get('oaipmh.harvests.'.$this->argument('name'), null);
         if (is_null($harvestConfig)) {
             $this->error('Unknown configuration specified.');
             $this->listConfigurations();
@@ -108,16 +108,16 @@ 
         }
 
         $harvestName = $this->argument('name');
-        $harvestConfig = \Config::get('oaipmh.harvests.' . $harvestName, null);
+        $harvestConfig = \Config::get('oaipmh.harvests.'.$harvestName, null);
 
         $this->comment(sprintf('Dispatching new harvest job'));
 
         if ($this->option('from-dump')) {
             $this->comment(' - From local dump');
         } else {
-            $this->comment(' - Repo: ' . $harvestConfig['url']);
-            $this->comment(' - Schema: ' . $harvestConfig['schema']);
-            $this->comment(' - Set: ' . $harvestConfig['set']);
+            $this->comment(' - Repo: '.$harvestConfig['url']);
+            $this->comment(' - Schema: '.$harvestConfig['schema']);
+            $this->comment(' - Set: '.$harvestConfig['set']);
 
             foreach (['from', 'until', 'resume', 'daily'] as $key) {
                 if (!is_null($this->option($key))) {

app/Jobs/OaiPmhHarvest.php

Spacing +10 added lines, -10 removed lines

@@ -88,7 +88,7 @@ 
      */
     public function fromDump()
     {
-        $files = Storage::disk('local')->files('harvests/' . $this->name);
+        $files = Storage::disk('local')->files('harvests/'.$this->name);
         $recordsHarvested = 0;
         foreach ($files as $filename) {
             if (!preg_match('/.xml$/', $filename)) {
@@ -111,11 +111,11 @@ 
 
     public function fromNetwork()
     {
-        $dest_path = 'harvests/' . $this->name . '/';
+        $dest_path = 'harvests/'.$this->name.'/';
 
         Storage::disk('local')->deleteDir($dest_path);
 
-        $latest = $dest_path . 'latest.xml';
+        $latest = $dest_path.'latest.xml';
 
         $client = new OaiPmhClient($this->url, [
             'schema'              => $this->schema,
@@ -124,12 +124,12 @@ 
             'sleep-time-on-error' => $this->sleepTimeOnError,
         ]);
 
-        $client->on('request.error', function ($msg) {
+        $client->on('request.error', function($msg) {
             $this->error($msg);
         });
 
         // Store each response to disk just in case
-        $client->on('request.complete', function ($verb, $args, $body) use ($latest) {
+        $client->on('request.complete', function($verb, $args, $body) use ($latest) {
             Storage::disk('local')->put($latest, $body);
         });
 
@@ -153,9 +153,9 @@ 
             if ($this->resume != $records->getResumptionToken()) {
                 $this->resume = $records->getResumptionToken();
                 if (is_null($this->resume)) {
-                    Storage::disk('local')->delete($dest_path . '/resumption_token');
+                    Storage::disk('local')->delete($dest_path.'/resumption_token');
                 } else {
-                    Storage::disk('local')->put($dest_path . '/resumption_token', $this->resume);
+                    Storage::disk('local')->put($dest_path.'/resumption_token', $this->resume);
                 }
             }
 
@@ -188,7 +188,7 @@ 
                 } catch (BadRequestError $e) {
                     $this->error($e->getMessage());
                     $this->error($e->getCode());
-                    $this->error('Bad request. Attempt ' . $attempt . ' of 100. Sleeping 10 secs.');
+                    $this->error('Bad request. Attempt '.$attempt.' of 100. Sleeping 10 secs.');
                     if ($attempt > 100) {
                         throw $e;
                     }
@@ -209,7 +209,7 @@ 
      */
     public function handle()
     {
-        Log::info('[OaiPmhHarvest] Starting job. Requesting records from ' . ($this->start ?: '(no limit)') . ' until ' . ($this->until ?: '(no limit)') . '.');
+        Log::info('[OaiPmhHarvest] Starting job. Requesting records from '.($this->start ?: '(no limit)').' until '.($this->until ?: '(no limit)').'.');
 
         // For timing
         $this->startTime = $this->batchTime = microtime(true) - 1;
@@ -227,7 +227,7 @@ 
             $recordsHarvested = $this->fromNetwork();
         }
 
-        Log::info('[OaiPmhHarvest] Harvest complete, got ' . $recordsHarvested . ' records.');
+        Log::info('[OaiPmhHarvest] Harvest complete, got '.$recordsHarvested.' records.');
     }
 
     /**

app/DescriptionScraper.php

Spacing +7 added lines, -7 removed lines

@@ -40,8 +40,8 @@ 
         $msg = vsprintf($msg, $args);
         $docLink = sprintf('<http://colligator.biblionaut.net/api/documents/%s|#%s> ', $doc->id, $doc->id);
         \Slack::attach([
-            'fallback' => '#' . $doc->id . ' ' . $msg,
-            'text'     => $docLink . $msg,
+            'fallback' => '#'.$doc->id.' '.$msg,
+            'text'     => $docLink.$msg,
             'color'    => $level,
         ])->send();
     }
@@ -65,10 +65,10 @@ 
      */
     public function updateDocument(Document $doc, $url)
     {
-        \Log::debug('[DescriptionScraper] Looking for decription for ' . $doc->id . ' at ' . $url);
+        \Log::debug('[DescriptionScraper] Looking for decription for '.$doc->id.' at '.$url);
 
         if (preg_match('/(damm.no)/', $url)) {
-            \Log::debug('[DescriptionScraper] Ignoring URL: ' . $url);
+            \Log::debug('[DescriptionScraper] Ignoring URL: '.$url);
 
             return;
         }
@@ -76,18 +76,18 @@ 
         try {
             $result = $this->scrape($url);
         } catch (TransferException $e) {
-            \Log::error('[DescriptionScraper] Transfer failed: ' . $e->getMessage());
+            \Log::error('[DescriptionScraper] Transfer failed: '.$e->getMessage());
             $this->notify('*DescriptionScraper* failed to fetch: %s', $doc, [$url]);
 
             return;
         } catch (Scrapers\ScrapeException $e) {
-            \Log::error('[DescriptionScraper] Scraping of ' . $url . ' failed: ' . $e->getMessage());
+            \Log::error('[DescriptionScraper] Scraping of '.$url.' failed: '.$e->getMessage());
             $this->notify('*DescriptionScraper* / %s failed to find a text at: %s', $doc, [$e->getMessage(), $url]);
 
             return;
         }
         if (is_null($result)) {
-            \Log::error('Encountered URL not recognized by any scraper: ' . $url);
+            \Log::error('Encountered URL not recognized by any scraper: '.$url);
             $this->notify('*DescriptionScraper* encountered URL not recognized by any sraper: %s', $doc, [$url]);
 
             return;